Skip to contentSkip to conversation

drm/amd/amdgpu: Add PCI info to gca_config debugfs

PATCH In review Tom St Denis 4 participants 5 messages Jan 18, 2017 4 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Add PCI info to gca_config debugfs

So we can determine which device the entry is before connecting a display.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +7 -1
index 28681286d57c..8640f9216d93 100644
@@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 		return -ENOMEM;
 
 	/* version, increment each time something is added */
-	config[no_regs++] = 2;
+	config[no_regs++] = 3;
 	config[no_regs++] = adev->gfx.config.max_shader_engines;
 	config[no_regs++] = adev->gfx.config.max_tile_pipes;
 	config[no_regs++] = adev->gfx.config.max_cu_per_sh;
@@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
 	config[no_regs++] = adev->family;
 	config[no_regs++] = adev->external_rev_id;
 
+	/* rev==3 */
+	config[no_regs++] = adev->pdev->device;
+	config[no_regs++] = adev->pdev->revision;
+	config[no_regs++] = adev->pdev->subsystem_device;
+	config[no_regs++] = adev->pdev->subsystem_vendor;
+
 	while (size && (*pos < no_regs * 4)) {
 		uint32_t value;
 
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#2 lore raw
Quoted 22 lines · Tom St Denis

So we can determine which device the entry is before connecting a display.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 28681286d57c..8640f9216d93 100644
@@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                return -ENOMEM;
 
        /* version, increment each time something is added */
-       config[no_regs++] = 2;
+       config[no_regs++] = 3;
        config[no_regs++] = adev->gfx.config.max_shader_engines;
        config[no_regs++] = adev->gfx.config.max_tile_pipes;
        config[no_regs++] = adev->gfx.config.max_cu_per_sh;

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, · line 3008

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
        config[no_regs++] = adev->family;
        config[no_regs++] = adev->external_rev_id;
 
+       /* rev==3 */
+       config[no_regs++] = adev->pdev->device;
+       config[no_regs++] = adev->pdev->revision;
+       config[no_regs++] = adev->pdev->subsystem_device;
+       config[no_regs++] = adev->pdev->subsystem_vendor;

For completeness, please add pdev->revision as well. With that:

Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
+
        while (size && (*pos < no_regs * 4)) {
                uint32_t value;
 
--

2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_NxDYM4=jp-y3czqoeVJEygbFaukoit+kRBGZdehjcxRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Reviewed-by Alex Deucher
#4 lore raw

I am grabbing revision. Unless there's some other PCI revision value I'm missing :-)

Tom

________________________________
From: Alex Deucher <[email protected]>
Sent: Wednesday, January 18, 2017 13:40
To: Tom St Denis
Cc: amd-gfx list; StDenis, Tom
Subject: Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

Quoted 22 lines · Tom St Denis

So we can determine which device the entry is before connecting a display.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 28681286d57c..8640f9216d93 100644
@@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                return -ENOMEM;
 
        /* version, increment each time something is added */
-       config[no_regs++] = 2;
+       config[no_regs++] = 3;
        config[no_regs++] = adev->gfx.config.max_shader_engines;
        config[no_regs++] = adev->gfx.config.max_tile_pipes;
        config[no_regs++] = adev->gfx.config.max_cu_per_sh;

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, · line 3008

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
        config[no_regs++] = adev->family;
        config[no_regs++] = adev->external_rev_id;
 
+       /* rev==3 */
+       config[no_regs++] = adev->pdev->device;
+       config[no_regs++] = adev->pdev->revision;
+       config[no_regs++] = adev->pdev->subsystem_device;
+       config[no_regs++] = adev->pdev->subsystem_vendor;

For completeness, please add pdev->revision as well. With that:

Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
+
        while (size && (*pos < no_regs * 4)) {
                uint32_t value;
 
--

2.11.0

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1764670B2DCBBF1150C02F18F77F0-/b2+HYfkarS51p+Siuid1wdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

Reviewed-by Alex Deucher
#6 lore raw

Whoops, sorry, I glanced quickly and thought you were grabbing the vendor and device ids, not the revision. Carry on :)

From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf Of StDenis, Tom
Sent: Wednesday, January 18, 2017 1:45 PM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

I am grabbing revision. Unless there's some other PCI revision value I'm missing :-)

Tom

________________________________
From: Alex Deucher <[email protected]<mailto:[email protected]>>
Sent: Wednesday, January 18, 2017 13:40
To: Tom St Denis
Cc: amd-gfx list; StDenis, Tom
Subject: Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

Quoted 22 lines · On Wed, Jan 18, 2017 at 1:25 PM, Tom St Denis…

So we can determine which device the entry is before connecting a display.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 28681286d57c..8640f9216d93 100644
@@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                return -ENOMEM;
 
        /* version, increment each time something is added */
-       config[no_regs++] = 2;
+       config[no_regs++] = 3;
        config[no_regs++] = adev->gfx.config.max_shader_engines;
        config[no_regs++] = adev->gfx.config.max_tile_pipes;
        config[no_regs++] = adev->gfx.config.max_cu_per_sh;

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, · line 3008

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
        config[no_regs++] = adev->family;
        config[no_regs++] = adev->external_rev_id;
 
+       /* rev==3 */
+       config[no_regs++] = adev->pdev->device;
+       config[no_regs++] = adev->pdev->revision;
+       config[no_regs++] = adev->pdev->subsystem_device;
+       config[no_regs++] = adev->pdev->subsystem_vendor;

For completeness, please add pdev->revision as well. With that:

Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
+
        while (size && (*pos < no_regs * 4)) {
                uint32_t value;
 
--

2.11.0

_______________________________________________
amd-gfx mailing list [email protected]<mailto:[email protected]>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB16529ECC0DE7C81FFB53C422F77F0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

Reviewed-by Alex Deucher
#8 lore raw

Coo, pushed to staging.

Tom

________________________________
From: Deucher, Alexander
Sent: Wednesday, January 18, 2017 13:47
To: StDenis, Tom; Alex Deucher
Cc: amd-gfx list
Subject: RE: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

Whoops, sorry, I glanced quickly and thought you were grabbing the vendor and device ids, not the revision. Carry on :)

From: amd-gfx [mailto:amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org] On Behalf Of StDenis, Tom
Sent: Wednesday, January 18, 2017 1:45 PM
To: Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

I am grabbing revision. Unless there's some other PCI revision value I'm missing :-)

Tom

________________________________

From: Alex Deucher <[email protected]<mailto:[email protected]>>
Sent: Wednesday, January 18, 2017 13:40
To: Tom St Denis
Cc: amd-gfx list; StDenis, Tom
Subject: Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs

Quoted 22 lines · On Wed, Jan 18, 2017 at 1:25 PM, Tom St Denis…

So we can determine which device the entry is before connecting a display.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 28681286d57c..8640f9216d93 100644
@@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
                return -ENOMEM;
 
        /* version, increment each time something is added */
-       config[no_regs++] = 2;
+       config[no_regs++] = 3;
        config[no_regs++] = adev->gfx.config.max_shader_engines;
        config[no_regs++] = adev->gfx.config.max_tile_pipes;
        config[no_regs++] = adev->gfx.config.max_cu_per_sh;

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, · line 3008

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
        config[no_regs++] = adev->family;
        config[no_regs++] = adev->external_rev_id;
 
+       /* rev==3 */
+       config[no_regs++] = adev->pdev->device;
+       config[no_regs++] = adev->pdev->revision;
+       config[no_regs++] = adev->pdev->subsystem_device;
+       config[no_regs++] = adev->pdev->subsystem_vendor;

For completeness, please add pdev->revision as well. With that:

Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
+
        while (size && (*pos < no_regs * 4)) {
                uint32_t value;
 
--

2.11.0

_______________________________________________
amd-gfx mailing list [email protected]<mailto:[email protected]>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

amd-gfx Info Page - lists.freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>

lists.freedesktop.org

To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx