pc104: Mask PC/104 Kconfig options

PATCH In review William Breathitt Gray 4 participants 13 messages Jan 10, 2017 – Mar 15, 2017

Subsystems (2)

GPIO IIO

lore

Share & tools

lore

William Breathitt Gray

author

2017-01-10 18:50 UTC #0 lore raw

cover pc104: Mask PC/104 Kconfig options

PC/104 form factor devices serve a specific niche of embedded system users. Since PC/104 devices and hardware are typically used by just a subset of Linux users, it would be appropriate to filter PC/104 related Kconfig options for those uninterested.

This patchset introduces the PC104 Kconfig option, and uses it to mask PC/104 specific device drivers and options, so that only those users interested in PC/104 related Kconfig options are exposed to them.

William Breathitt Gray (3):
pc104: Introduce the PC104 Kconfig option
gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option
iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

 drivers/gpio/Kconfig        | 8 ++++----
 drivers/iio/adc/Kconfig     | 2 +-
 drivers/iio/counter/Kconfig | 2 +-
 init/Kconfig                | 7 +++++++
 4 files changed, 13 insertions(+), 6 deletions(-)

Signature · 1 line

2.11.0

William Breathitt Gray

author

2017-01-10 18:50 UTC #1 lore raw

PATCH 1/3 pc104: Introduce the PC104 Kconfig option

PC/104 form factor devices serve a specific niche of embedded system users; most Linux users will not have PC/104 form factor devices. This patch introduces the PC104 Kconfig option, which should be used to filter PC/104 specific device drivers and options, so that only those users interested in PC/104 related options are exposed to them.

Signed-off-by William Breathitt Gray <[email protected]>

---
 init/Kconfig | 7 +++++++
 1 file changed, 7 insertions(+)

init/Kconfig +7 -0

index 223b734abccd..12841d75a04d 100644
@@ -1716,6 +1716,13 @@ config PERF_USE_VMALLOC
 	help
 	  See tools/perf/design.txt for details
 
+config PC104
+	bool "PC/104 support"
+	help
+	  Expose PC/104 form factor device drivers and options available for
+	  selection and configuration. Enable this option if your target
+	  machine has a PC/104 bus.
+
 menu "Kernel Performance Events And Counters"
 
 config PERF_EVENTS

Signature · 1 line

2.11.0

William Breathitt Gray

author

2017-01-10 18:51 UTC #2 lore raw

PATCH 2/3 gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option

In reply to William Breathitt Gray

PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.

Cc Linus Walleij <[email protected]>

Cc Alexandre Courbot <[email protected]>

Signed-off-by William Breathitt Gray <[email protected]>

---
 drivers/gpio/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

drivers/gpio/Kconfig +4 -4

index d5d36549ecc1..ad7084d98c60 100644
@@ -539,7 +539,7 @@ menu "Port-mapped I/O GPIO drivers"
 
 config GPIO_104_DIO_48E
 	tristate "ACCES 104-DIO-48E GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-DIO-48E series (104-DIO-48E,

@@ -549,7 +549,7 @@ config GPIO_104_DIO_48E
 
 config GPIO_104_IDIO_16
 	tristate "ACCES 104-IDIO-16 GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDIO-16 family (104-IDIO-16,

@@ -560,7 +560,7 @@ config GPIO_104_IDIO_16
 
 config GPIO_104_IDI_48
 	tristate "ACCES 104-IDI-48 GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDI-48 family (104-IDI-48A,

@@ -580,7 +580,7 @@ config GPIO_F7188X
 
 config GPIO_GPIO_MM
 	tristate "Diamond Systems GPIO-MM GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	help
 	  Enables GPIO support for the Diamond Systems GPIO-MM and GPIO-MM-12.

Signature · 1 line

2.11.0

Linus Walleij

2017-03-14 15:25 UTC #3 lore raw

Re: [PATCH 2/3] gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option

Quoted 7 lines · William Breathitt Gray

PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.
Cc Linus Walleij <[email protected]>
Cc Alexandre Courbot <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>

Patch applied.

Yours,
Linus Walleij

William Breathitt Gray

author

2017-01-10 18:51 UTC #4 lore raw

PATCH 3/3 iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

In reply to William Breathitt Gray

PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.

Cc Jonathan Cameron <[email protected]>

Cc Hartmut Knaack <[email protected]>

Cc Lars-Peter Clausen <lars-Qo5EllUWu/[email protected]>

Cc Peter Meerwald-Stadler <[email protected]>

Signed-off-by William Breathitt Gray <[email protected]>

---
 drivers/iio/adc/Kconfig     | 2 +-
 drivers/iio/counter/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/iio/adc/Kconfig +1 -1

index 9c8b558ba19e..dc897b443a17 100644
@@ -465,7 +465,7 @@ config STM32_ADC
 
 config STX104
 	tristate "Apex Embedded Systems STX104 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	select GPIOLIB
 	help
 	  Say yes here to build support for the Apex Embedded Systems STX104

drivers/iio/counter/Kconfig +1 -1

index 44627f6e4861..b37e5fc03149 100644
@@ -7,7 +7,7 @@ menu "Counters"
 
 config 104_QUAD_8
 	tristate "ACCES 104-QUAD-8 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	help
 	  Say yes here to build support for the ACCES 104-QUAD-8 quadrature
 	  encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).

Signature · 1 line

2.11.0

Jonathan Cameron

maintainer Acked-by on v1 3/3

2017-01-10 21:13 UTC #5 lore raw

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

Quoted 9 lines · William Breathitt Gray

PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>

Acked-by Jonathan Cameron <[email protected]>

Now the question is how to merge this one. Let me know if you want me to take this one via IIO after the first patch is in. If you want to take it another route I'm fine with that.

Jonathan

Quoted 32 lines

---
 drivers/iio/adc/Kconfig     | 2 +-
 drivers/iio/counter/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/iio/adc/Kconfig +1 -1

index 9c8b558ba19e..dc897b443a17 100644
@@ -465,7 +465,7 @@ config STM32_ADC
 
 config STX104
 	tristate "Apex Embedded Systems STX104 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	select GPIOLIB
 	help
 	  Say yes here to build support for the Apex Embedded Systems STX104

drivers/iio/counter/Kconfig +1 -1

index 44627f6e4861..b37e5fc03149 100644
@@ -7,7 +7,7 @@ menu "Counters"
 
 config 104_QUAD_8
 	tristate "ACCES 104-QUAD-8 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	help
 	  Say yes here to build support for the ACCES 104-QUAD-8 quadrature
 	  encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).

William Breathitt Gray

author

2017-01-10 21:45 UTC #6 lore raw

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

Quoted 10 lines · Jonathan Cameron

Quoted 9 lines · William Breathitt Gray
PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <lars-Qo5EllUWu/[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>

Quoted 7 lines

Acked-by Jonathan Cameron <[email protected]>
Now the question is how to merge this one. Let me know if you want me to take this one via IIO after the first patch is in. If you want to take it another route I'm fine with that.
Jonathan

This is such a simple patchset that I envision Greg K-H picking up all three patches via driver-core; however, I'm pretty indifferent about the ultimate path in the end. I'll leave it up to Greg K-H to decide.

William Breathitt Gray

Linus Walleij

2017-01-11 15:45 UTC #7 lore raw

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

Quoted 17 lines · William Breathitt Gray

Quoted 16 lines · Jonathan Cameron
Quoted 9 lines · William Breathitt Gray
PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>
Acked-by Jonathan Cameron <[email protected]>
Now the question is how to merge this one. Let me know if you want me to take this one via IIO after the first patch is in. If you want to take it another route I'm fine with that.

Quoted 5 lines

Quoted 1 line
Jonathan
This is such a simple patchset that I envision Greg K-H picking up all three patches via driver-core; however, I'm pretty indifferent about the ultimate path in the end. I'll leave it up to Greg K-H to decide.

As long as Greg merges the first patch we can merge the two others orthogonally I think.

It's just Kconfig symbols, not things that break compile.

(But I bet someone will come with automated warnings about unused symbols in the kernel...)

Yours,
Linus Walleij

Greg KH

2017-01-19 11:41 UTC #8 lore raw

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

Quoted 25 lines · Linus Walleij

Quoted 17 lines · William Breathitt Gray
Quoted 16 lines · Jonathan Cameron
Quoted 9 lines · William Breathitt Gray
PC/104 drivers should be hidden on machines which do not support PC/104 devices. This patch adds the PC104 Kconfig option as a dependency for the relevant PC/104 device driver Kconfig options.
Cc Jonathan Cameron <[email protected]>
Cc Hartmut Knaack <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc Peter Meerwald-Stadler <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>
Acked-by Jonathan Cameron <[email protected]>
Now the question is how to merge this one. Let me know if you want me to take this one via IIO after the first patch is in. If you want to take it another route I'm fine with that.
Quoted 5 lines
Quoted 1 line
Jonathan
This is such a simple patchset that I envision Greg K-H picking up all three patches via driver-core; however, I'm pretty indifferent about the ultimate path in the end. I'll leave it up to Greg K-H to decide.

Quoted 7 lines

As long as Greg merges the first patch we can merge the two others orthogonally I think.
It's just Kconfig symbols, not things that break compile.
(But I bet someone will come with automated warnings about unused symbols in the kernel...)

We already have that tool, scripts/checkkconfigsymbols.pl :)

I'll go merge this first patch now.

thanks,

greg k-h

Linus Walleij

2017-01-11 15:26 UTC #9 lore raw

In reply to William Breathitt Gray

Quoted 8 lines · William Breathitt Gray

PC/104 form factor devices serve a specific niche of embedded system users. Since PC/104 devices and hardware are typically used by just a subset of Linux users, it would be appropriate to filter PC/104 related Kconfig options for those uninterested.
This patchset introduces the PC104 Kconfig option, and uses it to mask PC/104 specific device drivers and options, so that only those users interested in PC/104 related Kconfig options are exposed to them.

Tell me when/if the PC104 option is merged and I can merge the GPIO patch.

Yours,
Linus Walleij

William Breathitt Gray

author

2017-03-01 20:46 UTC #10 lore raw

Quoted 12 lines · Linus Walleij

Quoted 8 lines · William Breathitt Gray
PC/104 form factor devices serve a specific niche of embedded system users. Since PC/104 devices and hardware are typically used by just a subset of Linux users, it would be appropriate to filter PC/104 related Kconfig options for those uninterested.
This patchset introduces the PC104 Kconfig option, and uses it to mask PC/104 specific device drivers and options, so that only those users interested in PC/104 related Kconfig options are exposed to them.

Quoted 5 lines

Tell me when/if the PC104 option is merged and I can merge the GPIO patch.
Yours,
Linus Walleij

Jonathan and Linus,

Now that the PC104 option is merged for 4.11, it should be all right to merge in the GPIO and IIO patches without worry of warnings. Please merge the relevant patch to your respective tree after you pull in the PC104 option.

Thank you,

William Breathitt Gray

Jonathan Cameron

maintainer

2017-03-05 12:48 UTC #11 lore raw

Quoted 19 lines · William Breathitt Gray

Quoted 12 lines · Linus Walleij
Quoted 8 lines · William Breathitt Gray
PC/104 form factor devices serve a specific niche of embedded system users. Since PC/104 devices and hardware are typically used by just a subset of Linux users, it would be appropriate to filter PC/104 related Kconfig options for those uninterested.
This patchset introduces the PC104 Kconfig option, and uses it to mask PC/104 specific device drivers and options, so that only those users interested in PC/104 related Kconfig options are exposed to them.
Quoted 5 lines
Tell me when/if the PC104 option is merged and I can merge the GPIO patch.
Yours,
Linus Walleij

Quoted 6 lines

Jonathan and Linus,
Now that the PC104 option is merged for 4.11, it should be all right to merge in the GPIO and IIO patches without worry of warnings. Please merge the relevant patch to your respective tree after you pull in the PC104 option.

If it looks like I've forgotten this, feel free to poke me again!

At least replying to you should get it back into my recent threads in my email client ;)

Jonathan

Quoted 9 lines

Thank you,
William Breathitt Gray
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jonathan Cameron

maintainer

2017-03-15 22:00 UTC #12 lore raw

Quoted 22 lines · Jonathan Cameron

Quoted 21 lines · William Breathitt Gray
Quoted 12 lines · Linus Walleij
Quoted 8 lines · William Breathitt Gray
PC/104 form factor devices serve a specific niche of embedded system users. Since PC/104 devices and hardware are typically used by just a subset of Linux users, it would be appropriate to filter PC/104 related Kconfig options for those uninterested.
This patchset introduces the PC104 Kconfig option, and uses it to mask PC/104 specific device drivers and options, so that only those users interested in PC/104 related Kconfig options are exposed to them.
Quoted 5 lines
Tell me when/if the PC104 option is merged and I can merge the GPIO patch.
Yours,
Linus Walleij
Jonathan and Linus,

Quoted 9 lines

Quoted 4 lines
Now that the PC104 option is merged for 4.11, it should be all right to merge in the GPIO and IIO patches without worry of warnings. Please merge the relevant patch to your respective tree after you pull in the PC104 option.
If it looks like I've forgotten this, feel free to poke me again!
At least replying to you should get it back into my recent threads in my email client ;)

Done,. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 16 lines

Jonathan
Quoted 9 lines
Thank you,
William Breathitt Gray
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html