fs/affs: affs_bread() doesn't return ERR_PTRs

PATCH New Dan Carpenter 1 participant 1 message Jan 21, 2017

Subsystems (3)

VFS Kernel janitors Affs file system

lore

Share & tools

lore

Dan Carpenter

author

2017-01-21 04:48 UTC #0 lore raw

PATCH 1/1 fs/affs: affs_bread() doesn't return ERR_PTRs

We're checking IS_ERR() here, but we should be checking for NULL.

Fixes e393e82a7d09 ("fs/affs: make export work with cold dcache")

Signed-off-by Dan Carpenter <[email protected]>

fs/affs/namei.c +2 -2

index a3df8a6..706dd06 100644
@@ -453,8 +453,8 @@ static struct dentry *affs_get_parent(struct dentry *child)
 	struct buffer_head *bh;
 
 	bh = affs_bread(child->d_sb, d_inode(child)->i_ino);
-	if (IS_ERR(bh))
-		return ERR_CAST(bh);
+	if (bh)
+		return ERR_PTR(-EIO);
 
 	parent = affs_iget(child->d_sb,
 			   be32_to_cpu(AFFS_TAIL(child->d_sb, bh)->parent));