iio: adc: Add Renesas GyroADC bindings
PATCH 1/2 iio: adc: Add Renesas GyroADC bindings
Add DT bindings for the Renesas RCar GyroADC block. This block is a simple 4/8-channel ADC which samples 12/15/24 bits of data every cycle from all channels.
--- .../bindings/iio/adc/renesas,gyroadc.txt | 93 ++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +93 -0
@@ -0,0 +1,93 @@ +* Renesas RCar GyroADC device driver + +Required properties: +- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc". + Use "renesas,r8a7792-gyroadc" for a GyroADC with interrupt + block found in R8A7792. +- reg: Address and length of the register set for the device +- clocks: References to all the clocks specified in the clock-names + property as specified in + Documentation/devicetree/bindings/clock/clock-bindings.txt. +- clock-names: Shall contain "fck" and "if". The "fck" is the GyroADC block + clock, the "if" is the interface clock. +- power-domains: Must contain a reference to the PM domain, if available. +- #address-cells: Should be <1> (setting for the subnodes) for all ADCs + except for "fujitsu,mb88101a". Should be <0> (setting for + only subnode) for "fujitsu,mb88101a". +- #size-cells: Should be <0> (setting for the subnodes) + +Sub-nodes: +Optionally you can define subnodes which select the connected ADC type and +reference voltage for the GyroADC channels. + +Required properties for subnodes: +- compatible: Should be either of: + "fujitsu,mb88101a" + - Fujitsu MB88101A compatible mode, + 12bit sampling, up to 4 channels can be sampled in + round-robin fashion. One Fujitsu chip supplies four + GyroADC channels with data as it contains four ADCs + on the chip and thus for 4-channel operation, single + MB88101A is required. The Cx chipselect lines of the + MB88101A connect directly to two CHS lines of the + GyroADC, no demuxer is required. The data out line + of each MB88101A connects to a shared input pin of + the GyroADC. + "ti,adcs7476" or "ti,adc121" or "adi,ad7476" + - TI ADCS7476 / TI ADC121 / ADI AD7476 compatible mode, + 15bit sampling, up to 8 channels can be sampled in + round-robin fashion. One TI/ADI chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the TI/ADI chips + to the GyroADC, while MISO line of each TI/ADI ADC + connects to a shared input pin of the GyroADC. + "maxim,max1162" or "maxim,max11100" + - Maxim MAX1162 / Maxim MAX11100 compatible mode, + 16bit sampling, up to 8 channels can be sampled in + round-robin fashion. One Maxim chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the MAX chips + to the GyroADC, while MISO line of each Maxim ADC + connects to a shared input pin of the GyroADC. +- reg: Should be the number of the analog input. Should be present + for all ADCs except "fujitsu,mb88101a". +- vref-supply: Reference to the channel reference voltage regulator. + +Example: + vref_max1162: regulator-vref-max1162 { + compatible = "regulator-fixed"; + + regulator-name = "MAX1162 Vref"; + regulator-min-microvolt = <4096000>; + regulator-max-microvolt = <4096000>; + }; + + &adc { + compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc"; + reg = <0 0xe6e54000 0 64>; + clocks = <&mstp9_clks R8A7791_CLK_GYROADC>, <&clk_65m>; + clock-names = "fck", "if"; + power-domains = <&sysc R8A7791_PD_ALWAYS_ON>; + + pinctrl-0 = <&adc_pins>; + pinctrl-names = "default"; + + status = "okay"; + + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + reg = <0>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + + adc@1 { + reg = <1>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + };
Signature · 1 line
2.11.0
PATCH v7 2/2 iio: adc: Add Renesas GyroADC driver
Add IIO driver for the Renesas RCar GyroADC block. This block is a simple 4/8-channel ADC which samples 12/15/24 bits of data every cycle from all channels.
---
V2: - Spelling fixes
- Rename the driver source file to rcar-gyroadc
- Rework the channel sample width handling
- Use iio_device_claim_mode_direct()
- Rename "renesas,rcar-gyroadc" to "renesas,r8a7791-gyroadc" and rename "renesas,rcar-gyroadc-r8a7792" to "renesas,r8a7792-gyroadc" to match the new naming scheme (WARNING: scif uses the old one!)
- Switch to using regulators for channel voltage reference, add new properties renesas,gyroadc-vref-chN-supply for N in 0..7
- Handle vref regulators as optional to, make channels without vref regulator return EINVAL on read.
- Fix module license to GPL
- Drop interrupt.h include
- Rename clk to iclk
- Rename RCar to R-Car
- Rework the invalid mode handling
- Don't print error message on EPROBE_DEFER
- Drop fclk handling, use runtime PM for that instead
V3: - More R-Car spelling fixes
- Flip checks for V2H, since that's the only one that has interrupt registers
- Replace if-else statement with switch statement in init_mode
- Use unsigned types where applicable
- Rework timing calculation slightly to drop if-else block
- Use DIV_ROUND_CLOSEST
V4: - Add renesas,rcar-gyroadc fallback compatible string into the bindings
- Rework the ADC bindings to use per-channel subdevs
- Support more compatible ADC chips
V5: - Reword the DT bindings, improve the description of the modes
- Improve the description in Kconfig
- Implement special DT bindings for the MB88101A 4-channel ADC and add special handling for this chip into the driver.
- Add missing ADC stop on failure, wrap it into a function
- Fail hard in case the DT properties are incorrect or missing
- Fix reporting of scale, so that channel * scale value is in mV
- Use fractional scale instead of int plus nano
- Use pm_runtime to disable the sampling 2 seconds after last used
V6: - Replace the indio_dev->name with "rcar-gyroadc" instead of OF node name
V7: - Split the DT bindings out of this patch
--- MAINTAINERS | 6 + drivers/iio/adc/Kconfig | 13 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/rcar-gyroadc.c | 631 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 651 insertions(+) create mode 100644 drivers/iio/adc/rcar-gyroadc.c
MAINTAINERS +6 -0
@@ -10445,6 +10445,12 @@ L: [email protected] F: drivers/net/ethernet/renesas/ F: include/linux/sh_eth.h +RENESAS R-CAR GYROADC DRIVER +M: Marek Vasut <[email protected]> +L: [email protected] +S: Supported +F: drivers/iio/adc/rcar_gyro_adc.c + RENESAS USB2 PHY DRIVER M: Yoshihiro Shimoda <[email protected]> L: [email protected]
drivers/iio/adc/Kconfig +13 -0
@@ -430,6 +430,19 @@ config QCOM_SPMI_VADC To compile this driver as a module, choose M here: the module will be called qcom-spmi-vadc. +config RCAR_GYRO_ADC + tristate "Renesas R-Car GyroADC driver" + depends on ARCH_RCAR_GEN2 || (ARM && COMPILE_TEST) + help + Say yes here to build support for the GyroADC found in Renesas + R-Car Gen2 SoCs. This block is a simple SPI offload engine for + reading data out of attached compatible ADCs in a round-robin + fashion. Up to 4 or 8 ADC channels are supported by this block, + depending on which ADCs are attached. + + To compile this driver as a module, choose M here: the + module will be called rcar-gyroadc. + config ROCKCHIP_SARADC tristate "Rockchip SARADC driver" depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
drivers/iio/adc/Makefile +1 -0
@@ -41,6 +41,7 @@ obj-$(CONFIG_NAU7802) += nau7802.o obj-$(CONFIG_PALMAS_GPADC) += palmas_gpadc.o obj-$(CONFIG_QCOM_SPMI_IADC) += qcom-spmi-iadc.o obj-$(CONFIG_QCOM_SPMI_VADC) += qcom-spmi-vadc.o +obj-$(CONFIG_RCAR_GYRO_ADC) += rcar-gyroadc.o obj-$(CONFIG_ROCKCHIP_SARADC) += rockchip_saradc.o obj-$(CONFIG_STX104) += stx104.o obj-$(CONFIG_STM32_ADC_CORE) += stm32-adc-core.o
drivers/iio/adc/rcar-gyroadc.c new file +631 -0
631 lines not on this page · raw message
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170121144212.8858-1-marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoted 3 lines · Marek Vasut
Add DT bindings for the Renesas RCar GyroADC block. This block is a simple 4/8-channel ADC which samples 12/15/24 bits of data every cycle from all channels.
Isn't this v7?
Quoted 20 lines
Signed-off-by Marek Vasut <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Simon Horman <horms+renesas-/[email protected]>Cc Jonathan Cameron <[email protected]>Cc Wolfram Sang <wsa-z923LK4zBo2bacvFa/[email protected]>Cc Rob Herring <[email protected]>--- .../bindings/iio/adc/renesas,gyroadc.txt | 93 ++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txtDocumentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +0
-0
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 1
Quoted 1 line
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +1
-0@@ -0,0 +1,93 @@ +* Renesas RCar GyroADC device driver
What's a GyroADC?
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 4
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +3
-0+ +Required properties: +- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
Need to enumerate <chip>.
Quoted 7 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +7
-0+ Use "renesas,r8a7792-gyroadc" for a GyroADC with interrupt + block found in R8A7792. +- reg: Address and length of the register set for the device +- clocks: References to all the clocks specified in the clock-names + property as specified in + Documentation/devicetree/bindings/clock/clock-bindings.txt. +- clock-names: Shall contain "fck" and "if". The "fck" is the GyroADC block
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 21
Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +10
-0+ clock, the "if" is the interface clock. +- power-domains: Must contain a reference to the PM domain, if available. +- #address-cells: Should be <1> (setting for the subnodes) for all ADCs + except for "fujitsu,mb88101a". Should be <0> (setting for + only subnode) for "fujitsu,mb88101a". +- #size-cells: Should be <0> (setting for the subnodes) + +Sub-nodes: +Optionally you can define subnodes which select the connected ADC type and +reference voltage for the GyroADC channels.
Seems strange to be optional. How many nodes are possible?
Quoted 46 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +46
-0+ +Required properties for subnodes: +- compatible: Should be either of: + "fujitsu,mb88101a" + - Fujitsu MB88101A compatible mode, + 12bit sampling, up to 4 channels can be sampled in + round-robin fashion. One Fujitsu chip supplies four + GyroADC channels with data as it contains four ADCs + on the chip and thus for 4-channel operation, single + MB88101A is required. The Cx chipselect lines of the + MB88101A connect directly to two CHS lines of the + GyroADC, no demuxer is required. The data out line + of each MB88101A connects to a shared input pin of + the GyroADC. + "ti,adcs7476" or "ti,adc121" or "adi,ad7476" + - TI ADCS7476 / TI ADC121 / ADI AD7476 compatible mode, + 15bit sampling, up to 8 channels can be sampled in + round-robin fashion. One TI/ADI chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the TI/ADI chips + to the GyroADC, while MISO line of each TI/ADI ADC + connects to a shared input pin of the GyroADC. + "maxim,max1162" or "maxim,max11100" + - Maxim MAX1162 / Maxim MAX11100 compatible mode, + 16bit sampling, up to 8 channels can be sampled in + round-robin fashion. One Maxim chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the MAX chips + to the GyroADC, while MISO line of each Maxim ADC + connects to a shared input pin of the GyroADC. +- reg: Should be the number of the analog input. Should be present + for all ADCs except "fujitsu,mb88101a". +- vref-supply: Reference to the channel reference voltage regulator. + +Example: + vref_max1162: regulator-vref-max1162 { + compatible = "regulator-fixed"; + + regulator-name = "MAX1162 Vref"; + regulator-min-microvolt = <4096000>; + regulator-max-microvolt = <4096000>; + }; + + &adc {
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 77
Quoted 10 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +10
-0+ compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc"; + reg = <0 0xe6e54000 0 64>; + clocks = <&mstp9_clks R8A7791_CLK_GYROADC>, <&clk_65m>; + clock-names = "fck", "if"; + power-domains = <&sysc R8A7791_PD_ALWAYS_ON>; + + pinctrl-0 = <&adc_pins>; + pinctrl-names = "default"; + + status = "okay";
Drop status from examples.
Quoted 19 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +16
-0+ + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + reg = <0>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + + adc@1 { + reg = <1>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + };Signature · 1 line
2.11.0
Quoted 6 lines · Rob Herring
Quoted 3 lines · Marek Vasut
Add DT bindings for the Renesas RCar GyroADC block. This block is a simple 4/8-channel ADC which samples 12/15/24 bits of data every cycle from all channels.
Isn't this v7?
Technically yes, it was part of the 2/2 until now.
Quoted 13 lines
Quoted 13 lines
Signed-off-by Marek Vasut <[email protected]>Cc Geert Uytterhoeven <[email protected]>Cc Simon Horman <horms+renesas-/[email protected]>Cc Jonathan Cameron <[email protected]>Cc Wolfram Sang <wsa-z923LK4zBo2bacvFa/[email protected]>Cc Rob Herring <[email protected]>--- .../bindings/iio/adc/renesas,gyroadc.txt | 93 ++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt
Quoted 9 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 1
Quoted 7 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +1
-0@@ -0,0 +1,93 @@ +* Renesas RCar GyroADC device driverWhat's a GyroADC?
The GyroADC block is a reduced SPI block with up to 8 chipselect lines, which supports the SPI protocol of a selected few SPI ADCs. The SPI ADCs are sampled by the GyroADC block in a round-robin fashion and the result presented in the GyroADC registers.
Good ?
Quoted 5 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 4
Quoted 3 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +3
-0+ +Required properties: +- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".Need to enumerate <chip>.
It's enumerated below , the only special-case we handle at this point is the r8a7792 , which has extra interrupt block which we don't use anyway, but the driver disables those interrupts.
Quoted 2 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 6
Quoted 2 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +2
-0+ Use "renesas,r8a7792-gyroadc" for a GyroADC with interrupt + block found in R8A7792.
I can add .... otherwise use the matching SoC model in <chip> field.
Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +9
-0+- reg: Address and length of the register set for the device +- clocks: References to all the clocks specified in the clock-names + property as specified in + Documentation/devicetree/bindings/clock/clock-bindings.txt. +- clock-names: Shall contain "fck" and "if". The "fck" is the GyroADC block + clock, the "if" is the interface clock. +- power-domains: Must contain a reference to the PM domain, if available. +- #address-cells: Should be <1> (setting for the subnodes) for all ADCs + except for "fujitsu,mb88101a". Should be <0> (setting for
Quoted 8 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 21
Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +6
-0+ only subnode) for "fujitsu,mb88101a". +- #size-cells: Should be <0> (setting for the subnodes) + +Sub-nodes: +Optionally you can define subnodes which select the connected ADC type and +reference voltage for the GyroADC channels.Seems strange to be optional. How many nodes are possible?
1, up-to 4 or up-to 8, depending on the ADC you connect.
I guess it can be made mandatory as not having any ADC attached would make it pretty pointless to enable this block in the first place ...
Quoted 50 lines
Quoted 50 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +50
-0+ +Required properties for subnodes: +- compatible: Should be either of: + "fujitsu,mb88101a" + - Fujitsu MB88101A compatible mode, + 12bit sampling, up to 4 channels can be sampled in + round-robin fashion. One Fujitsu chip supplies four + GyroADC channels with data as it contains four ADCs + on the chip and thus for 4-channel operation, single + MB88101A is required. The Cx chipselect lines of the + MB88101A connect directly to two CHS lines of the + GyroADC, no demuxer is required. The data out line + of each MB88101A connects to a shared input pin of + the GyroADC. + "ti,adcs7476" or "ti,adc121" or "adi,ad7476" + - TI ADCS7476 / TI ADC121 / ADI AD7476 compatible mode, + 15bit sampling, up to 8 channels can be sampled in + round-robin fashion. One TI/ADI chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the TI/ADI chips + to the GyroADC, while MISO line of each TI/ADI ADC + connects to a shared input pin of the GyroADC. + "maxim,max1162" or "maxim,max11100" + - Maxim MAX1162 / Maxim MAX11100 compatible mode, + 16bit sampling, up to 8 channels can be sampled in + round-robin fashion. One Maxim chip supplies single + ADC channel with data, thus for 8-channel operation, + 8 chips are required. A 3:8 chipselect demuxer is + required to connect the nCS line of the MAX chips + to the GyroADC, while MISO line of each Maxim ADC + connects to a shared input pin of the GyroADC. +- reg: Should be the number of the analog input. Should be present + for all ADCs except "fujitsu,mb88101a". +- vref-supply: Reference to the channel reference voltage regulator. + +Example: + vref_max1162: regulator-vref-max1162 { + compatible = "regulator-fixed"; + + regulator-name = "MAX1162 Vref"; + regulator-min-microvolt = <4096000>; + regulator-max-microvolt = <4096000>; + }; + + &adc { + compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc"; + reg = <0 0xe6e54000 0 64>; + clocks = <&mstp9_clks R8A7791_CLK_GYROADC>, <&clk_65m>; + clock-names = "fck", "if";
Quoted 8 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt line 77
Quoted 6 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +6
-0+ power-domains = <&sysc R8A7791_PD_ALWAYS_ON>; + + pinctrl-0 = <&adc_pins>; + pinctrl-names = "default"; + + status = "okay";Drop status from examples.
Dropped.
Quoted 19 lines
Quoted 19 lines
Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +16
-0+ + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + reg = <0>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + + adc@1 { + reg = <1>; + compatible = "maxim,max1162"; + vref-supply = <&vref_max1162>; + }; + };Signature · 1 line
2.11.0
Signature · 6 lines
Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 63b3660b-6ce0-134c-ef79-c06430c735c5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Hi Marek,
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Rob Herring
Quoted 4 lines · Marek Vasut
new file mode 100644
index 000000000000..081947367135Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +0
-0
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
+Required properties:
+- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".Need to enumerate <chip>.
It's enumerated below , the only special-case we handle at this point is the r8a7792 , which has extra interrupt block which we don't use anyway, but the driver disables those interrupts.
It is not enumerated below. You just give an example for r8a7791.
Please list all supported/tested compatible values, so checkpatch can validate compatible values in DTS patches adding GyroADC device nodes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): CAMuHMdUVwQoqQbrsGtbvxK9PoHae3n=UuJYijTMToUsdc=8=mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 19 lines · Geert Uytterhoeven
Hi Marek,
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Rob Herring
Quoted 4 lines · Marek Vasut
new file mode 100644
index 000000000000..081947367135Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +0
-0Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
+Required properties:
+- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".Need to enumerate <chip>.
It's enumerated below , the only special-case we handle at this point is the r8a7792 , which has extra interrupt block which we don't use anyway, but the driver disables those interrupts.
Quoted 5 lines
It is not enumerated below. You just give an example for r8a7791.
Please list all supported/tested compatible values, so checkpatch can validate compatible values in DTS patches adding GyroADC device nodes.
What about this ?
- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
The <chip> can be either of:
r8a7791 - for the GyroADC block present in r8a7791 SoC r8a7792 - for the GyroADC with interrupt block present
in r8a7792 SoC
Signature · 2 lines
Best regards, Marek Vasut
A message that is not in the archive (sent off-list or not yet received): d4fc63bf-c455-2ac4-15d2-6f240799d3e9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Hi Marek,
Quoted 24 lines · Marek Vasut
Quoted 17 lines · Geert Uytterhoeven
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Rob Herring
Quoted 4 lines · Marek Vasut
new file mode 100644
index 000000000000..081947367135Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +0
-0Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
+Required properties:
+- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".Need to enumerate <chip>.
It's enumerated below , the only special-case we handle at this point is the r8a7792 , which has extra interrupt block which we don't use anyway, but the driver disables those interrupts.
Quoted 5 lines
It is not enumerated below. You just give an example for r8a7791.
Please list all supported/tested compatible values, so checkpatch can validate compatible values in DTS patches adding GyroADC device nodes.
Quoted 7 lines
What about this ?
- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
The <chip> can be either of:
r8a7791 - for the GyroADC block present in r8a7791 SoC r8a7792 - for the GyroADC with interrupt block present
in r8a7792 SoC
No, we need the exact string in the document, cfr. all other Renesas bindings.
"renesas,r8a7791-gyroadc"
"renesas,r8a7792-gyroadc"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 35 lines · Geert Uytterhoeven
Hi Marek,
Quoted 24 lines · Marek Vasut
Quoted 17 lines · Geert Uytterhoeven
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Rob Herring
Quoted 4 lines · Marek Vasut
new file mode 100644
index 000000000000..081947367135Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt new file +0
-0Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
+Required properties:
+- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".Need to enumerate <chip>.
It's enumerated below , the only special-case we handle at this point is the r8a7792 , which has extra interrupt block which we don't use anyway, but the driver disables those interrupts.
Quoted 5 lines
It is not enumerated below. You just give an example for r8a7791.
Please list all supported/tested compatible values, so checkpatch can validate compatible values in DTS patches adding GyroADC device nodes.
Quoted 7 lines
What about this ?
- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
The <chip> can be either of:
r8a7791 - for the GyroADC block present in r8a7791 SoC r8a7792 - for the GyroADC with interrupt block present
in r8a7792 SoC
Quoted 4 lines
No, we need the exact string in the document, cfr. all other Renesas bindings.
"renesas,r8a7791-gyroadc"
"renesas,r8a7792-gyroadc"
This ?
- compatible: Should be "<soc-specific>", "renesas,rcar-gyroadc".
The <soc-specific> should be one of:
renesas,r8a7791-gyroadc - for the GyroADC block present
in r8a7791 SoC
renesas,r8a7792-gyroadc - for the GyroADC with interrupt
block present in r8a7792 SoC
Signature · 2 lines
Best regards, Marek Vasut
Hi Marek,
Quoted 15 lines · Marek Vasut
Quoted 9 lines · Geert Uytterhoeven
Quoted 7 lines · Marek Vasut
What about this ?
- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
The <chip> can be either of:
r8a7791 - for the GyroADC block present in r8a7791 SoC r8a7792 - for the GyroADC with interrupt block present
in r8a7792 SoCQuoted 4 lines
No, we need the exact string in the document, cfr. all other Renesas bindings.
"renesas,r8a7791-gyroadc"
"renesas,r8a7792-gyroadc"
Quoted 8 lines
This ?
- compatible: Should be "<soc-specific>", "renesas,rcar-gyroadc".
The <soc-specific> should be one of:
renesas,r8a7791-gyroadc - for the GyroADC block present
in r8a7791 SoC
renesas,r8a7792-gyroadc - for the GyroADC with interrupt
block present in r8a7792 SoC
Yes. I had expected that double quotes were mandatory, but apparently checkpatch doesn't require that.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds