drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

So I decided to fix this with the following follow-up patch. I hope this is the right approach (vs. reverting the commit and instead using a fixed v2 of the original patch).

From 41775d2c8a14873f522667a57b66cfbe119e28a4 Mon Sep 17 00:00:00 2001
From: Nils Holland <[email protected]>
Date: Tue, 24 Jan 2017 01:36:45 +0100
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

Remove mistakedly placed ; that prevents the code from compiling. No functional change.

Signed-off-by Nils Holland <[email protected]>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1 -1

index f71fe41c1c99..89d32131e3f5 100644
@@ -377,7 +377,7 @@ int amdgpu_bo_create_restricted(struct amdgpu_device *adev,
 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
 	 thanks to write-combining
 
-	if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
+	if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC)
 		DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "
 			      "better performance thanks to write-combining\n");
 	bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;

Quoted 8 lines · Nils Holland

So I decided to fix this with the following follow-up patch. I hope this is the right approach (vs. reverting the commit and instead using a fixed v2 of the original patch).

From 41775d2c8a14873f522667a57b66cfbe119e28a4 Mon Sep 17 00:00:00 2001
From: Nils Holland <[email protected]>
Date: Tue, 24 Jan 2017 01:36:45 +0100
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

Note that the way your e-mail was formatted, the above commentary and mail headers would end up in the Git commit log, unless the person applying the patch pays attention and removes them. Commentary that isn't to be part of the commit log should be added between the --- marker below and the actual code diff.

Reviewed-by Michel Dänzer <[email protected]>

Quoted 9 lines · Nils Holland

Quoted 8 lines

So I decided to fix this with the following follow-up patch. I hope this is the right approach (vs. reverting the commit and instead using a fixed v2 of the original patch).

From 41775d2c8a14873f522667a57b66cfbe119e28a4 Mon Sep 17 00:00:00 2001
From: Nils Holland <[email protected]>
Date: Tue, 24 Jan 2017 01:36:45 +0100
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

Quoted 5 lines

Note that the way your e-mail was formatted, the above commentary and mail headers would end up in the Git commit log, unless the person applying the patch pays attention and removes them. Commentary that isn't to be part of the commit log should be added between the --- marker below and the actual code diff.

Ah, I see! Making the job unnecessarily difficult for a maintainer is no good idea, so I will certainly do this better / correctly the next time I submit something!

Quoted 1 line

Reviewed-by Michel Dänzer <[email protected]>

Thanks!!

Greetings
Nils
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Am 24.01.2017 um 08:43 schrieb Nils Holland:

Quoted 15 lines · Michel Dänzer

Quoted 14 lines · Nils Holland

Quoted 8 lines

So I decided to fix this with the following follow-up patch. I hope this is the right approach (vs. reverting the commit and instead using a fixed v2 of the original patch).

From 41775d2c8a14873f522667a57b66cfbe119e28a4 Mon Sep 17 00:00:00 2001
From: Nils Holland <[email protected]>
Date: Tue, 24 Jan 2017 01:36:45 +0100
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

Note that the way your e-mail was formatted, the above commentary and mail headers would end up in the Git commit log, unless the person applying the patch pays attention and removes them. Commentary that isn't to be part of the commit log should be added between the --- marker below and the actual code diff.

Quoted 5 lines

Ah, I see! Making the job unnecessarily difficult for a maintainer is no good idea, so I will certainly do this better / correctly the next time I submit something!

Quoted 1 line

Reviewed-by Michel Dänzer <[email protected]>

Reviewed-by Christian König <[email protected]> as well.