ARM: imx6: fix min/max voltage of anatop 2p5 regulator
Subsystems (2)
PATCH 1/2 ARM: imx6: fix min/max voltage of anatop 2p5 regulator
The regulation bound of this regulator are 2.1V to 2.875V, the wrong DT values cause the driver to miscalculate the effective voltage.
This isn't really an issue right now, as nobody actively changes the regulator voltage, but better fix it now.
--- arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +2 -2
@@ -661,8 +661,8 @@ anatop-vol-bit-shift = <8>; anatop-vol-bit-width = <5>; anatop-min-bit-val = <0>; - anatop-min-voltage = <2000000>; - anatop-max-voltage = <2750000>; + anatop-min-voltage = <2100000>; + anatop-max-voltage = <2875000>; }; reg_arm: regulator-vddcore {
Signature · 1 line
2.11.0
PATCH 2/2 ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5
Fix the min/max voltage constraints for the anatop 1p1 and 2p5 regulator to match the typical operating range mentioned in the datasheet.
--- arch/arm/boot/dts/imx6qdl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +3 -3
@@ -626,8 +626,8 @@ regulator-1p1 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd1p1"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1375000>; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1200000>; regulator-always-on; anatop-reg-offset = <0x110>; anatop-vol-bit-shift = <8>;
@@ -654,7 +654,7 @@ regulator-2p5 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd2p5"; - regulator-min-microvolt = <2000000>; + regulator-min-microvolt = <2250000>; regulator-max-microvolt = <2750000>; regulator-always-on; anatop-reg-offset = <0x130>;
Signature · 1 line
2.11.0
PATCH 2/2 ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5
Quoted 25 lines · Lucas Stach
Fix the min/max voltage constraints for the anatop 1p1 and 2p5 regulator to match the typical operating range mentioned in the datasheet.
Signed-off-by Lucas Stach <[email protected]>--- arch/arm/boot/dts/imx6qdl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/imx6qdl.dtsi +2
-2@@ -626,8 +626,8 @@ regulator-1p1 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd1p1"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1375000>; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1200000>; regulator-always-on; anatop-reg-offset = <0x110>; anatop-vol-bit-shift = <8>;
arch/arm/boot/dts/imx6qdl.dtsi line 660
Quoted 8 lines
arch/arm/boot/dts/imx6qdl.dtsi +1
-1@@ -654,7 +654,7 @@ regulator-2p5 { compatible = "fsl,anatop-regulator"; regulator-name = "vdd2p5"; - regulator-min-microvolt = <2000000>; + regulator-min-microvolt = <2250000>; regulator-max-microvolt = <2750000>; regulator-always-on; anatop-reg-offset = <0x130>;
regards
Philipp
PATCH 1/2 ARM: imx6: fix min/max voltage of anatop 2p5 regulator
In reply to Lucas StachQuoted 3 lines · Lucas Stach
The regulation bound of this regulator are 2.1V to 2.875V, the wrong DT values cause the driver to miscalculate the effective voltage.
As easily checked with
$ grep vdd2p5 /sys/kernel/debug/regulator/regulator_summary - vdd2p5 0 0 0 2400mV 0mA 2000mV 2750mV + vdd2p5 0 0 0 2500mV 0mA 2000mV 2750mV
Quoted 13 lines
This isn't really an issue right now, as nobody actively changes the regulator voltage, but better fix it now.
Signed-off-by Lucas Stach <[email protected]>--- arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/imx6qdl.dtsi +0
-0
arch/arm/boot/dts/imx6qdl.dtsi line 668
Quoted 10 lines
arch/arm/boot/dts/imx6qdl.dtsi +2
-2@@ -661,8 +661,8 @@ anatop-vol-bit-shift = <8>; anatop-vol-bit-width = <5>; anatop-min-bit-val = <0>; - anatop-min-voltage = <2000000>; - anatop-max-voltage = <2750000>; + anatop-min-voltage = <2100000>; + anatop-max-voltage = <2875000>; }; reg_arm: regulator-vddcore {
regards
Philipp
Shawn Guo
AppliedPATCH 1/2 ARM: imx6: fix min/max voltage of anatop 2p5 regulator
In reply to Lucas StachQuoted 8 lines · Lucas Stach
The regulation bound of this regulator are 2.1V to 2.875V, the wrong DT values cause the driver to miscalculate the effective voltage.
This isn't really an issue right now, as nobody actively changes the regulator voltage, but better fix it now.
Signed-off-by Lucas Stach <[email protected]>
Applied both, thanks.