Skip to contentSkip to conversation

xfs/122 failure for a while

DISCUSSION Christoph Hellwig 2 participants 2 messages Jan 24, 2017

lore
Share & tools
lore
#0 lore raw

xfs/122 has been failing for me for a while with this error:

-sizeof(xfs_dsb_t) = 272
+sizeof(xfs_dsb_t) = 264

That 272 numbers comes from:

908ce96f ("xfs/122: add the realtime rmapbt inode and btree fields"), which don't seem to be features that made it into the kernel and xfsprogs so far.

#1 lore raw
Quoted 10 lines · Christoph Hellwig

xfs/122 has been failing for me for a while with this error:

(quoted diff) +1 -1
-sizeof(xfs_dsb_t) = 272
+sizeof(xfs_dsb_t) = 264

That 272 numbers comes from:

908ce96f ("xfs/122: add the realtime rmapbt inode and btree fields"), which don't seem to be features that made it into the kernel and xfsprogs so far.

Yeah... the realtime rmapbt tests got sucked into xfstests back when I thought we were closer to landing that feature. Then I decided to let it sit on the backburner behind online scrub so that the disk format could stay the same for longer.

I've wondered for a while if it would make sense to special-case xfs_dsb_t not to complain about a smaller value (because if features start falling off the kernel you're likely to notice) but arranging the parsing for all that made my head hurt.

For now I'll just set it back to 264.

--D

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html