Skip to contentSkip to conversation

sctp: fix some debug output

PATCH In review Dan Carpenter 3 participants 6 messages Jan 24, 2017

Subsystems (4)
Networking Network drivers Kernel janitors SCTP protocol
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sctp: fix some debug output

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>
net/sctp/debug.c +1 -0
index 95d7b15dad21..c5f4ed5242ac 100644
@@ -159,6 +159,7 @@ static const char *const sctp_timer_tbl[] = {
 	"TIMEOUT_T4_RTO",
 	"TIMEOUT_T5_SHUTDOWN_GUARD",
 	"TIMEOUT_HEARTBEAT",
+	"TIMEOUT_RECONF",
 	"TIMEOUT_SACK",
 	"TIMEOUT_AUTOCLOSE",
 };
maintainer
#1 lore raw
Quoted 5 lines · Dan Carpenter

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>

Weird, seems your patch is missing the --- marker here. Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.

Quoted 18 lines
net/sctp/debug.c +1 -1
index 95d7b15dad21..c5f4ed5242ac 100644
@@ -159,6 +159,7 @@ static const char *const sctp_timer_tbl[] = {
 	"TIMEOUT_T4_RTO",
 	"TIMEOUT_T5_SHUTDOWN_GUARD",
 	"TIMEOUT_HEARTBEAT",
+	"TIMEOUT_RECONF",
 	"TIMEOUT_SACK",
 	"TIMEOUT_AUTOCLOSE",
 };
--

To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 10 lines · Marcelo Ricardo Leitner
Quoted 5 lines · Dan Carpenter

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>

Weird, seems your patch is missing the --- marker here. Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.

Colin, if you wanted, you could CC kernel-janitors with static checker fixes. There are several of us on that list.

regards,
dan carpenter

#3 lore raw
Quoted 8 lines · Dan Carpenter
Quoted 7 lines · Marcelo Ricardo Leitner
Quoted 5 lines · Dan Carpenter

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>
Quoted 6 lines
Quoted 3 lines

Weird, seems your patch is missing the --- marker here. Colin (Cc'ed) is supposed to post a v3 of his patch containing this fix.

Colin, if you wanted, you could CC kernel-janitors with static checker fixes. There are several of us on that list.

OK, thanks for the heads-up on that Dan.

Colin

Quoted 4 lines

regards,
dan carpenter

author
#4 lore raw
In reply to Marcelo Ricardo Leitner
Quoted 8 lines · Marcelo Ricardo Leitner
Quoted 5 lines · Dan Carpenter

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>

Weird, seems your patch is missing the --- marker here.

Are there tools that require the --- marker? I normally leave it out when it's not required.

regards,
dan carpenter

maintainer
#5 lore raw
Quoted 5 lines · Dan Carpenter
Quoted 4 lines · Marcelo Ricardo Leitner
Quoted 3 lines · Dan Carpenter

We added SCTP_EVENT_TIMEOUT_RECONF but we didn't update this array so it causes an off-by-one read overflow.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Fixes 7b9438de0cd4 ("sctp: add stream reconf timer")
Signed-off-by Dan Carpenter <[email protected]>

Weird, seems your patch is missing the --- marker here.

Are there tools that require the --- marker? I normally leave it out when it's not required.

Yeah I don't think it's required. It's usually there to split it between changelog and non-changelog stuff like the diffstat output, which is not there too, so it should be okay.

Marcelo