Skip to contentSkip to conversation

ARM: dts: support I2SE Duckbill devices

PATCH Superseded Michael Heimpold 4 participants 18 messages Jan 22, 2017 – Jan 24, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: support I2SE Duckbill devices

This series updates/adds Device Tree support for I2SE's Duckbill device family.

The Duckbill devices are small, pen-drive sized boards based on NXP's i.MX28 SoC. While the initial variants (Duckbill series) were equipped with a micro SD card slot only, the latest generation (Duckbill 2 series) have an additional internal eMMC onboard.

Both device generations consists of four "family members":

- Duckbill/Duckbill 2: generic board, intended to be used as baseboard for custom designs and/or as development board

- Duckbill EnOcean/Duckbill 2 EnOcean: come with an EnOcean daugther board equipped with the popular TCM310 module

- Duckbill 485/Duckbill 2 485: as the name implies, these devices are intended to be used as Ethernet - RS485 converters

- Duckbill SPI/Duckbill 2 SPI: not sold separately, but used in I2SE's development kits for Green PHY HomePlug Powerline communication

Because the Duckbill series is EOL, this patch series only adds support for the latest Duckbill 2 series devices. However, support for the generic Duckbill board was already mainline, so update it to match vendor tree DT.

Changes since v1:
- dropped device tree include (shared common definitions)
- added patch 9 (DT documentation file)
- applied reviewers hints
- rebased

Michael Heimpold (9):
ARM: dts: imx28: add alternative pinmuxing for mmc2
ARM: dts: imx28: rename mmc2_sck_cfg to prepare for an alternative
muxing setup
ARM: dts: imx28: add alternative muxing for mmc2_sck_cfg
ARM: dts: imx28-duckbill: enable spi, i2c and uart pins
ARM: dts: add support for I2SE Duckbill 2 boards
ARM: dts: add support for I2SE Duckbill 2 485
ARM: dts: add support for I2SE Duckbill 2 EnOcean
ARM: dts: add support for I2SE Duckbill 2 SPI
Documentation: DT: add entries for I2SE boards

 Documentation/devicetree/bindings/arm/i2se.txt |  22 +++
 arch/arm/boot/dts/Makefile                     |   4 +
 arch/arm/boot/dts/imx28-duckbill-2-485.dts     | 189 +++++++++++++++++++++
 arch/arm/boot/dts/imx28-duckbill-2-enocean.dts | 220 +++++++++++++++++++++++++
 arch/arm/boot/dts/imx28-duckbill-2-spi.dts     | 199 ++++++++++++++++++++++
 arch/arm/boot/dts/imx28-duckbill-2.dts         | 183 ++++++++++++++++++++
 arch/arm/boot/dts/imx28-duckbill.dts           |  81 ++++++---
 arch/arm/boot/dts/imx28-m28cu3.dts             |   2 +-
 arch/arm/boot/dts/imx28.dtsi                   |  28 +++-
 9 files changed, 901 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/i2se.txt
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-485.dts
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-enocean.dts
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-spi.dts
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2.dts
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/9 ARM: dts: imx28: add alternative pinmuxing for mmc2

From: Michael Heimpold <[email protected]>

---
 arch/arm/boot/dts/imx28.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/imx28.dtsi +16 -0
index 3aabf65..bc5cf41 100644
@@ -581,6 +581,22 @@
 					fsl,pull-up = <MXS_PULL_ENABLE>;
 				};
 
+				mmc2_4bit_pins_b: mmc2-4bit at 1 {
+					reg = <1>;
+					fsl,pinmux-ids = <
+						MX28_PAD_SSP2_SCK__SSP2_SCK
+						MX28_PAD_SSP2_MOSI__SSP2_CMD
+						MX28_PAD_SSP2_MISO__SSP2_D0
+						MX28_PAD_SSP2_SS0__SSP2_D3
+						MX28_PAD_SSP2_SS1__SSP2_D1
+						MX28_PAD_SSP2_SS2__SSP2_D2
+						MX28_PAD_AUART1_RX__SSP2_CARD_DETECT
+					>;
+					fsl,drive-strength = <MXS_DRIVE_8mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_ENABLE>;
+				};
+
 				mmc2_cd_cfg: mmc2-cd-cfg {
 					fsl,pinmux-ids = <
 						MX28_PAD_AUART1_RX__SSP2_CARD_DETECT
Signature · 1 line
2.7.4
#2 lore raw

PATCH v2 2/9 ARM: dts: imx28: rename mmc2_sck_cfg to prepare for an alternative muxing setup

In reply to Michael Heimpold

From: Michael Heimpold <[email protected]>

---
 arch/arm/boot/dts/imx28-m28cu3.dts | 2 +-
 arch/arm/boot/dts/imx28.dtsi       | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx28-m28cu3.dts +1 -1
index 2df63be..bb53294 100644
@@ -57,7 +57,7 @@
 				pinctrl-names = "default";
 				pinctrl-0 = <&mmc2_4bit_pins_a
 					     &mmc2_cd_cfg
-					     &mmc2_sck_cfg>;
+					     &mmc2_sck_cfg_a>;
 				bus-width = <4>;
 				vmmc-supply = <&reg_vddio_sd1>;
 				status = "okay";
arch/arm/boot/dts/imx28.dtsi +2 -1
index bc5cf41..857ca37 100644
@@ -604,7 +604,8 @@
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
-				mmc2_sck_cfg: mmc2-sck-cfg {
+				mmc2_sck_cfg_a: mmc2-sck-cfg at 0 {
+					reg = <0>;
 					fsl,pinmux-ids = <
 						MX28_PAD_SSP0_DATA7__SSP2_SCK
 					>;
Signature · 1 line
2.7.4
#3 lore raw

PATCH v2 3/9 ARM: dts: imx28: add alternative muxing for mmc2_sck_cfg

In reply to Michael Heimpold

From: Michael Heimpold <[email protected]>

---
 arch/arm/boot/dts/imx28.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/imx28.dtsi +9 -0
index 857ca37..5c65fa1 100644
@@ -613,6 +613,15 @@
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
+				mmc2_sck_cfg_b: mmc2-sck-cfg at 1 {
+					reg = <1>;
+					fsl,pinmux-ids = <
+						MX28_PAD_SSP2_SCK__SSP2_SCK
+					>;
+					fsl,drive-strength = <MXS_DRIVE_12mA>;
+					fsl,pull-up = <MXS_PULL_DISABLE>;
+				};
+
 				i2c0_pins_a: i2c0 at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
Signature · 1 line
2.7.4
#4 lore raw

PATCH v2 4/9 ARM: dts: imx28-duckbill: enable spi, i2c and uart pins

In reply to Michael Heimpold

While at tweak some more settings for the default product:
- enable lradc
- adjust USB dr mode
- add default triggers for LEDs
- get rid of regulators simple-bus container
- adjust phy reset duration

---
 arch/arm/boot/dts/imx28-duckbill.dts | 81 +++++++++++++++++++++++++-----------
 1 file changed, 56 insertions(+), 25 deletions(-)
arch/arm/boot/dts/imx28-duckbill.dts +56 -25
index ce1a7ef..3e4385d 100644
@@ -1,5 +1,6 @@
 /*
- * Copyright (C) 2013 Michael Heimpold <[email protected]>
+ * Copyright (C) 2013-2014,2016 Michael Heimpold <[email protected]>
+ * Copyright (C) 2015-2017 I2SE GmbH <[email protected]>
  *
  * The code contained herein is licensed under the GNU General Public
  * License. You may obtain a copy of the GNU General Public License
@@ -10,6 +11,7 @@
  */
 
 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
 #include "imx28.dtsi"
 
 / {
@@ -32,6 +34,13 @@
 				status = "okay";
 			};
 
+			ssp2: ssp at 80014000 {
+				compatible = "fsl,imx28-spi";
+				pinctrl-names = "default";
+				pinctrl-0 = <&spi2_pins_a>;
+				status = "okay";
+			};
+
 			pinctrl at 80018000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&hog_pins_a>;
@@ -39,14 +48,24 @@
 				hog_pins_a: hog at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
-						MX28_PAD_SSP0_DATA7__GPIO_2_7 /* PHY Reset */
+						MX28_PAD_LCD_D17__GPIO_1_17    /* Revision detection */
+					>;
+					fsl,drive-strength = <MXS_DRIVE_4mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_DISABLE>;
+				};
+
+				mac0_phy_reset_pin: mac0-phy-reset at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						MX28_PAD_SSP0_DATA7__GPIO_2_7    /* PHY Reset */
 					>;
 					fsl,drive-strength = <MXS_DRIVE_4mA>;
 					fsl,voltage = <MXS_VOLTAGE_HIGH>;
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
-				led_pins_a: led_gpio at 0 {
+				led_pins: leds at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
 						MX28_PAD_AUART1_RX__GPIO_3_4
@@ -60,6 +79,22 @@
 		};
 
 		apbx at 80040000 {
+			lradc at 80050000 {
+				status = "okay";
+			};
+
+			i2c0: i2c@80058000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&i2c0_pins_a>;
+				status = "okay";
+			};
+
+			auart0: serial at 8006a000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&auart0_2pins_a>;
+				status = "okay";
+			};
+
 			duart: serial at 80074000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&duart_pins_a>;
@@ -75,47 +110,43 @@
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
 			status = "okay";
+			dr_mode = "peripheral";
 		};
 
 		mac0: ethernet at 800f0000 {
 			phy-mode = "rmii";
 			pinctrl-names = "default";
-			pinctrl-0 = <&mac0_pins_a>;
+			pinctrl-0 = <&mac0_pins_a>, <&mac0_phy_reset_pin>;
 			phy-supply = <&reg_3p3v>;
 			phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
-			phy-reset-duration = <100>;
+			phy-reset-duration = <25>;
 			status = "okay";
 		};
 	};
 
-	regulators {
-		compatible = "simple-bus";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		reg_3p3v: regulator at 0 {
-			compatible = "regulator-fixed";
-			reg = <0>;
-			regulator-name = "3P3V";
-			regulator-min-microvolt = <3300000>;
-			regulator-max-microvolt = <3300000>;
-			regulator-always-on;
-		};
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
 	};
 
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
-		pinctrl-0 = <&led_pins_a>;
+		pinctrl-0 = <&led_pins>;
 
-		status {
-			label = "duckbill:green:status";
-			gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
-		};
-
-		failure {
+		status-red {
 			label = "duckbill:red:status";
 			gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+		};
+
+		status-green {
+			label = "duckbill:green:status";
+			gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
 		};
 	};
 };
Signature · 1 line
2.7.4
#5 lore raw

PATCH v2 4/9 ARM: dts: imx28-duckbill: enable spi, i2c and uart pins

Hi,

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 6 lines

While at tweak some more settings for the default product:
- enable lradc
- adjust USB dr mode
- add default triggers for LEDs
- get rid of regulators simple-bus container
- adjust phy reset duration

since the subject line suggests something different as the actual complete patch does, this needs to be changed.

@Shawn, @Fabio: Do we need a single patch for every point or is it possible to squash some?

#6 lore raw

PATCH v2 4/9 ARM: dts: imx28-duckbill: enable spi, i2c and uart pins

Quoted 10 lines · Stefan Wahren

Hi,

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 6 lines

While at tweak some more settings for the default product:
- enable lradc
- adjust USB dr mode
- add default triggers for LEDs
- get rid of regulators simple-bus container
- adjust phy reset duration

Quoted 5 lines

since the subject line suggests something different as the actual complete patch does, this needs to be changed.

@Shawn, @Fabio: Do we need a single patch for every point or is it possible to squash some?

I prefer to squash if possible.

Shawn

#7 lore raw

PATCH v2 5/9 ARM: dts: add support for I2SE Duckbill 2 boards

In reply to Michael Heimpold

This machine is an USB pen drive sized development board, based on NXP's i.MX28 CPU. In contrast to the previous model "Duckbill", the "Duckbill 2" series has internal eMMC storage.

---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/imx28-duckbill-2.dts | 183 +++++++++++++++++++++++++++++++++
 2 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2.dts
arch/arm/boot/dts/Makefile +1 -0
index f10fe85..fa4664b 100644
@@ -475,6 +475,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx28-cfa10056.dtb \
 	imx28-cfa10057.dtb \
 	imx28-cfa10058.dtb \
+	imx28-duckbill-2.dtb \
 	imx28-duckbill.dtb \
 	imx28-eukrea-mbmx283lc.dtb \
 	imx28-eukrea-mbmx287lc.dtb \
arch/arm/boot/dts/imx28-duckbill-2.dts new file +183 -0

183 lines not on this page · raw message

Signature · 1 line
2.7.4
#8 lore raw

PATCH v2 6/9 ARM: dts: add support for I2SE Duckbill 2 485

In reply to Michael Heimpold

This machine is based on I2SE's Duckbill 2 board and features a RS-485 daugther board. This device is intended to be used for e.g. home automation purposes.

---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/imx28-duckbill-2-485.dts | 189 +++++++++++++++++++++++++++++
 2 files changed, 190 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-485.dts
arch/arm/boot/dts/Makefile +1 -0
index fa4664b..e0f3f4e 100644
@@ -475,6 +475,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx28-cfa10056.dtb \
 	imx28-cfa10057.dtb \
 	imx28-cfa10058.dtb \
+	imx28-duckbill-2-485.dts \
 	imx28-duckbill-2.dtb \
 	imx28-duckbill.dtb \
 	imx28-eukrea-mbmx283lc.dtb \
arch/arm/boot/dts/imx28-duckbill-2-485.dts new file +189 -0

189 lines not on this page · raw message

Signature · 1 line
2.7.4
#9 lore raw

PATCH v2 6/9 ARM: dts: add support for I2SE Duckbill 2 485

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 17 lines

This machine is based on I2SE's Duckbill 2 board and features a RS-485 daugther board. This device is intended to be used for e.g. home automation purposes.

---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/imx28-duckbill-2-485.dts | 189 +++++++++++++++++++++++++++++
 2 files changed, 190 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-485.dts
arch/arm/boot/dts/Makefile +0 -0
index fa4664b..e0f3f4e 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_MXS) += \ · line 478

Quoted 4 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -475,6 +475,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx28-cfa10056.dtb \
 	imx28-cfa10057.dtb \
 	imx28-cfa10058.dtb \
+	imx28-duckbill-2-485.dts \

The file ending should be dtb. This issue applies also to patch 7 and 8.

#10 lore raw

PATCH v2 7/9 ARM: dts: add support for I2SE Duckbill 2 EnOcean

In reply to Michael Heimpold

This machine is based on I2SE's Duckbill 2 board and features a EnOcean daugther board based on the popular TCM310 chipset. This product is intended to be used for e.g. home automation purposes.

---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/imx28-duckbill-2-enocean.dts | 220 +++++++++++++++++++++++++
 2 files changed, 221 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-enocean.dts
arch/arm/boot/dts/Makefile +1 -0
index e0f3f4e..d7fcb4dc 100644
@@ -477,6 +477,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx28-cfa10058.dtb \
 	imx28-duckbill-2-485.dts \
 	imx28-duckbill-2.dtb \
+	imx28-duckbill-2-enocean.dts \
 	imx28-duckbill.dtb \
 	imx28-eukrea-mbmx283lc.dtb \
 	imx28-eukrea-mbmx287lc.dtb \
arch/arm/boot/dts/imx28-duckbill-2-enocean.dts new file +220 -0

220 lines not on this page · raw message

Signature · 1 line
2.7.4
#11 lore raw

PATCH v2 8/9 ARM: dts: add support for I2SE Duckbill 2 SPI

In reply to Michael Heimpold

This machine is based on I2SE's Duckbill 2 board and is sold as part of I2SE's PLC Bundle for IoT. This is a development kit for Homeplug Green PHY based powerline products based on Qualcomms QCA7000 chip.

---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/imx28-duckbill-2-spi.dts | 199 +++++++++++++++++++++++++++++
 2 files changed, 200 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-spi.dts
arch/arm/boot/dts/Makefile +1 -0
index d7fcb4dc..d2d2486 100644
@@ -478,6 +478,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx28-duckbill-2-485.dts \
 	imx28-duckbill-2.dtb \
 	imx28-duckbill-2-enocean.dts \
+	imx28-duckbill-2-spi.dts \
 	imx28-duckbill.dtb \
 	imx28-eukrea-mbmx283lc.dtb \
 	imx28-eukrea-mbmx287lc.dtb \
arch/arm/boot/dts/imx28-duckbill-2-spi.dts new file +199 -0

199 lines not on this page · raw message

Signature · 1 line
2.7.4
#12 lore raw

PATCH v2 8/9 ARM: dts: add support for I2SE Duckbill 2 SPI

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 12 lines

This machine is based on I2SE's Duckbill 2 board and is sold as part of I2SE's PLC Bundle for IoT. This is a development kit for Homeplug Green PHY based powerline products based on Qualcomms QCA7000 chip.

---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/imx28-duckbill-2-spi.dts | 199 +++++++++++++++++++++++++++++
 2 files changed, 200 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx28-duckbill-2-spi.dts

...

Quoted 49 lines
arch/arm/boot/dts/imx28-duckbill-2-spi.dts new file +43 -0
new file mode 100644
index 0000000..738eaa7
@@ -0,0 +1,199 @@
+/*
+ * Copyright (C) 2015-2017 I2SE GmbH <[email protected]>
+ * Copyright (C) 2016 Michael Heimpold <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/gpio/gpio.h>
+#include "imx28.dtsi"
+
+/ {
+	model = "I2SE Duckbill 2 SPI";
+	compatible = "i2se,duckbill", "fsl,imx28";
+
+	aliases {
+		ethernet1 = &qca7000;
+	};
+
+	memory {
+		reg = <0x40000000 0x08000000>;
+	};
+
+	apb at 80000000 {
+		apbh at 80000000 {
+			ssp0: ssp at 80010000 {
+				compatible = "fsl,imx28-mmc";
+				pinctrl-names = "default";
+				pinctrl-0 = <&mmc0_8bit_pins_a
+					&mmc0_cd_cfg &mmc0_sck_cfg>;
+				bus-width = <8>;
+				vmmc-supply = <&reg_3p3v>;
+				status = "okay";
+				non-removable;
+			};
+
+			ssp2: ssp at 80014000 {

arch/arm/boot/dts/imx28-duckbill-2-spi.dts line 53

Quoted 10 lines
arch/arm/boot/dts/imx28-duckbill-2-spi.dts new file +10 -0
+				compatible = "fsl,imx28-spi";
+				pinctrl-names = "default";
+				pinctrl-0 = <&spi2_pins_a>;
+				status = "okay";
+
+				qca7000: ethernet at 0 {
+					compatible = "qca,qca7000";
+					pinctrl-names = "default";
+					pinctrl-0 = <&qca7000_pins>;
+					reg = <0>;

Just a nit. Please place the reg property before the compatible in order to keep it like the others.

#13 lore raw

PATCH v2 9/9 Documentation: DT: add entries for I2SE boards

In reply to Michael Heimpold

This patch adds the missing devicetree binding documentation for I2SE's Duckbill and Duckbill 2 series boards.

---
 Documentation/devicetree/bindings/arm/i2se.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/i2se.txt
Documentation/devicetree/bindings/arm/i2se.txt new file +22 -0
new file mode 100644
index 0000000..9f30382
@@ -0,0 +1,22 @@
+I2SE Device Tree Bindings
+-------------------------
+
+Duckbill Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 485 Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 EnOcean Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 SPI Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
Signature · 1 line
2.7.4
#14 lore raw

PATCH v2 9/9 Documentation: DT: add entries for I2SE boards

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 28 lines

This patch adds the missing devicetree binding documentation for I2SE's Duckbill and Duckbill 2 series boards.

---
 Documentation/devicetree/bindings/arm/i2se.txt | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/i2se.txt
Documentation/devicetree/bindings/arm/i2se.txt new file +12 -0
new file mode 100644
index 0000000..9f30382
@@ -0,0 +1,22 @@
+I2SE Device Tree Bindings
+-------------------------
+
+Duckbill Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 485 Board

Documentation/devicetree/bindings/arm/i2se.txt line 22

Quoted 10 lines
Documentation/devicetree/bindings/arm/i2se.txt new file +10 -0
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 EnOcean Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";
+
+Duckbill 2 SPI Board
+Required root node properties:
+    - compatible = "i2se,duckbill", "fsl.imx28";

Please replace all fsl.imx28 with fsl,imx28

Maybe this patch should come before adding the Duckbill 2 board dts files.

#15 lore raw

v2 cover ARM: dts: support I2SE Duckbill devices

In reply to Michael Heimpold

Am 22.01.2017 um 23:22 schrieb Michael Heimpold:

Quoted 19 lines

This series updates/adds Device Tree support for I2SE's Duckbill device family.

The Duckbill devices are small, pen-drive sized boards based on NXP's i.MX28 SoC. While the initial variants (Duckbill series) were equipped with a micro SD card slot only, the latest generation (Duckbill 2 series) have an additional internal eMMC onboard.

Both device generations consists of four "family members":

- Duckbill/Duckbill 2: generic board, intended to be used as baseboard for custom designs and/or as development board

- Duckbill EnOcean/Duckbill 2 EnOcean: come with an EnOcean daugther board equipped with the popular TCM310 module

- Duckbill 485/Duckbill 2 485: as the name implies, these devices are intended to be used as Ethernet - RS485 converters

Quoted 8 lines

- Duckbill SPI/Duckbill 2 SPI: not sold separately, but used in I2SE's development kits for Green PHY HomePlug Powerline communication

Because the Duckbill series is EOL, this patch series only adds support for the latest Duckbill 2 series devices. However, support for the generic Duckbill board was already mainline, so update it to match vendor tree DT.

for patches 1,2,3,5

reviewer
#16 lore raw

v2 cover ARM: dts: support I2SE Duckbill devices

In reply to Michael Heimpold

Hi Michael,

Quoted 2 lines · Michael Heimpold

- Duckbill 485/Duckbill 2 485: as the name implies, these devices are intended to be used as Ethernet - RS485 converters

Just curious: do you use mxs-auart to interface to a rs485 transceiver? If so, would you have mxs-auart patches that add rs485?

Thanks

#17 lore raw

v2 cover ARM: dts: support I2SE Duckbill devices

Hi Fabio,

Zitat von Fabio Estevam <[email protected]>:

Quoted 9 lines

Hi Michael,

Quoted 2 lines · Michael Heimpold

- Duckbill 485/Duckbill 2 485: as the name implies, these devices are intended to be used as Ethernet - RS485 converters

Just curious: do you use mxs-auart to interface to a rs485 transceiver? If so, would you have mxs-auart patches that add rs485?

Due to the lack of hardware support in mxs-auart for rs485, we decided to use a more expensive hardware transceiver with auto direction feature. So the rs485 is (mostly) transparent for upper layers.

Regards,
Michael