Skip to contentSkip to conversation

eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc

PATCH In review Wei Yongjun 2 participants 2 messages Jan 25, 2017 – Jan 26, 2017 Char and misc drivers

lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc

From: Wei Yongjun <[email protected]>

It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.

Fixes cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/misc/eeprom/idt_89hpesx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/misc/eeprom/idt_89hpesx.c +0 -4
index 25d47d0..f5f2c5a 100644
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
 	pdev->ee_file->size = pdev->eesize;
 	ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
 	if (ret != 0) {
-		kfree(pdev->ee_file);
 		dev_err(dev, "Failed to create EEPROM sysfs-node");
 		return ret;
 	}

@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
 
 	/* Remove EEPROM sysfs file */
 	sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
-	/* Free memory allocated for bin_attribute structure */
-	kfree(pdev->ee_file);
 }
 
 /*
Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free.

Fixes cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/misc/eeprom/idt_89hpesx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/misc/eeprom/idt_89hpesx.c +0 -1
index 25d47d0..f5f2c5a 100644
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
 	pdev->ee_file->size = pdev->eesize;
 	ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
 	if (ret != 0) {
-		kfree(pdev->ee_file);
 		dev_err(dev, "Failed to create EEPROM sysfs-node");
 		return ret;
 	}

drivers/misc/eeprom/idt_89hpesx.c static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) · line 1385

Quoted 9 lines
drivers/misc/eeprom/idt_89hpesx.c +0 -3
@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
 
 	/* Remove EEPROM sysfs file */
 	sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
-	/* Free memory allocated for bin_attribute structure */
-	kfree(pdev->ee_file);
 }
 
 /*

True point! Thanks for the patch.

Acked-by Serge Semin <[email protected]>