Skip to contentSkip to conversation

NFC: remove TI nfcwilink driver

PATCH Applied Rob Herring 3 participants 7 messages Jan 25, 2017 – Feb 27, 2017 NFC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NFC: remove TI nfcwilink driver

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

Cc Ilan Elias <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Samuel Ortiz <[email protected]>
Cc Lauro Ramos Venancio <[email protected]>
Cc Aloisio Almeida Jr <[email protected]>
---
 drivers/nfc/Kconfig     |  11 -
 drivers/nfc/Makefile    |   1 -
 drivers/nfc/nfcwilink.c | 578 ------------------------------------------------
 3 files changed, 590 deletions(-)
 delete mode 100644 drivers/nfc/nfcwilink.c
drivers/nfc/Kconfig +0 -11
index 9d2369269abf..c4208487fadc 100644
@@ -5,17 +5,6 @@
 menu "Near Field Communication (NFC) devices"
 	depends on NFC
 
-config NFC_WILINK
-	tristate "Texas Instruments NFC WiLink driver"
-	depends on TI_ST && NFC_NCI
-	help
-	  This enables the NFC driver for Texas Instrument's BT/FM/GPS/NFC
-	  combo devices. This makes use of shared transport line discipline
-	  core driver to communicate with the NFC core of the combo chip.
-
-	  Say Y here to compile support for Texas Instrument's NFC WiLink driver
-	  into the kernel or say M to compile it as module.
-
 config NFC_TRF7970A
 	tristate "Texas Instruments TRF7970a NFC driver"
 	depends on SPI && NFC_DIGITAL
drivers/nfc/Makefile +0 -1
index bab8ef06ae35..640b7274371c 100644
@@ -6,7 +6,6 @@ obj-$(CONFIG_NFC_FDP)		+= fdp/
 obj-$(CONFIG_NFC_PN544)		+= pn544/
 obj-$(CONFIG_NFC_MICROREAD)	+= microread/
 obj-$(CONFIG_NFC_PN533)		+= pn533/
-obj-$(CONFIG_NFC_WILINK)	+= nfcwilink.o
 obj-$(CONFIG_NFC_MEI_PHY)	+= mei_phy.o
 obj-$(CONFIG_NFC_SIM)		+= nfcsim.o
 obj-$(CONFIG_NFC_PORT100)	+= port100.o
drivers/nfc/nfcwilink.c deleted +0 -578

578 lines not on this page · raw message

Signature · 1 line
2.10.1
#1 lore raw

Hi Rob,

Quoted 8 lines

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

since the firmware files TINfcInit_* also never made it into the linux-firmware tree, I have no idea who is using this driver. I am actually fine with removing it since it would be easy enough to bring back based on hci_ll driver once there is hardware to test this on.

Regards

Marcel

#2 lore raw
Quoted 8 lines · Marcel Holtmann

Hi Rob,

Quoted 6 lines

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

Quoted 4 lines
Quoted 2 lines

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

since the firmware files TINfcInit_* also never made it into the linux-firmware tree, I have no idea who is using this driver. I am actually fine with removing it since it would be easy enough to bring back based on hci_ll driver once there is hardware to test this on.

Ping. Someone going to pick up this patch?

Rob

#3 lore raw

Hi Rob,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

since the firmware files TINfcInit_* also never made it into the linux-firmware tree, I have no idea who is using this driver. I am actually fine with removing it since it would be easy enough to bring back based on hci_ll driver once there is hardware to test this on.

Ping. Someone going to pick up this patch?

if Samuel does not have anything pending for his tree, I can take it through bluetooth-next tree.

Regards

Marcel

#4 lore raw
Quoted 11 lines · Marcel Holtmann

Hi Rob,

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

since the firmware files TINfcInit_* also never made it into the linux-firmware tree, I have no idea who is using this driver. I am actually fine with removing it since it would be easy enough to bring back based on hci_ll driver once there is hardware to test this on.

Ping. Someone going to pick up this patch?

if Samuel does not have anything pending for his tree, I can take it through bluetooth-next tree.

From the looks of -next, it doesn't appear so.

Rob

#5 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 9 lines · Rob Herring
Quoted 8 lines · Marcel Holtmann

Hi Rob,

Quoted 6 lines

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

since the firmware files TINfcInit_* also never made it into the linux-firmware tree, I have no idea who is using this driver. I am actually fine with removing it since it would be easy enough to bring back based on hci_ll driver once there is hardware to test this on.

Ping. Someone going to pick up this patch?

I'll take it, I need to catch up with pending NFC patches this week.

Cheers,
Samuel.

Applied
#6 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 16 lines · Rob Herring

It appears that TI WiLink devices including NFC (WL185x/WL189x) never shipped. The only information I found were announcements in Feb 2012 about the parts. There's been no activity on this driver besided common changes since initially added in Jan 2012. There's also no in users that instantiate the platform device (nor DT bindings).

This is a first step in removing TI ST (shared transport) driver in favor of extending the BT hci_ll driver to support WL183x chips.

Cc Ilan Elias <[email protected]>
Cc Marcel Holtmann <[email protected]>
Cc Samuel Ortiz <[email protected]>
Cc Lauro Ramos Venancio <[email protected]>
Cc Aloisio Almeida Jr <[email protected]>
Quoted 6 lines
---
 drivers/nfc/Kconfig     |  11 -
 drivers/nfc/Makefile    |   1 -
 drivers/nfc/nfcwilink.c | 578 ------------------------------------------------
 3 files changed, 590 deletions(-)
 delete mode 100644 drivers/nfc/nfcwilink.c

Applied to nfc-next, thanks.

Cheers,
Samuel.