Skip to contentSkip to conversation

Enable tiling by default with glamor on PALM

PATCH In review Michel Dänzer 2 participants 2 messages Jan 26, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Enable tiling by default with glamor on PALM

From: Michel Dänzer <[email protected]>

The DFS check is only relevant for EXA.

The lack of tiling prevented DRI3 clients from using page flipping, resulting in tearing.

Bugzilla: https://bugs.freedesktop.org/99491

---
 src/radeon_kms.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
src/radeon_kms.c +6 -4
index 48dec967a..446852564 100644
@@ -1741,10 +1741,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags)
 		if (r600_get_tile_config(pScrn)) {
 		    info->allowColorTiling = xf86ReturnOptValBool(info->Options,
 								  OPTION_COLOR_TILING, colorTilingDefault);
-		    /* need working DFS for tiling */
-		    if ((info->ChipFamily == CHIP_FAMILY_PALM) &&
-			(!info->accel_state->allowHWDFS))
-			info->allowColorTiling = FALSE;
+		    if (!info->use_glamor) {
+			/* need working DFS for tiling */
+			if (info->ChipFamily == CHIP_FAMILY_PALM &&
+			    !info->accel_state->allowHWDFS)
+			    info->allowColorTiling = FALSE;
+		    }
 		} else
 		    info->allowColorTiling = FALSE;
 	    } else
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170126094037.24311-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 9 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

The DFS check is only relevant for EXA.

The lack of tiling prevented DRI3 clients from using page flipping, resulting in tearing.

Bugzilla: https://bugs.freedesktop.org/99491

Quoted 28 lines
---
 src/radeon_kms.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
src/radeon_kms.c +6 -5
index 48dec967a..446852564 100644
@@ -1741,10 +1741,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags)
                if (r600_get_tile_config(pScrn)) {
                    info->allowColorTiling = xf86ReturnOptValBool(info->Options,
                                                                  OPTION_COLOR_TILING, colorTilingDefault);
-                   /* need working DFS for tiling */
-                   if ((info->ChipFamily == CHIP_FAMILY_PALM) &&
-                       (!info->accel_state->allowHWDFS))
-                       info->allowColorTiling = FALSE;
+                   if (!info->use_glamor) {
+                       /* need working DFS for tiling */
+                       if (info->ChipFamily == CHIP_FAMILY_PALM &&
+                           !info->accel_state->allowHWDFS)
+                           info->allowColorTiling = FALSE;
+                   }
                } else
                    info->allowColorTiling = FALSE;
            } else
--

2.11.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx