Skip to contentSkip to conversation

ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

PATCH New Teresa Remmet 3 participants 6 messages Jan 24, 2017 – Feb 9, 2017

Subsystems (4)
Device tree bindings Arm (32-bit) OMAP2+ support Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Teresa Remmet

author
#0 lore raw

PATCH v2 1/3 ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

The phyCORE-AM335x development kit is a combination of the phyCORE-AM335x SoM and a PCM-953 carrier board. The features of the PCM-953 are:
* ETH phy on carrier board: 1x RGMII
* 1x CAN
* Up to 4x UART
* USB0 (otg)
* USB1 (host)
* SD slot
* User gpio-keys
* User LEDs

Signed-off-by Teresa Remmet <[email protected]>
Reviewed-by Wadim Egorov <[email protected]>
Acked-by Rob Herring <[email protected]>

---
Changes in v2:
- moved gpio-keys, gpio-leds and regulators nodes to root node
- moved muxing of gpio-keys and gpio-leds
- removed not needed compatible "simple-bus"
- fixed unit address of ethernet phy node
- removed redundant status properties
- added Acked-by: Rob Herring <[email protected]>

 .../devicetree/bindings/arm/omap/omap.txt          |   3 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/am335x-pcm-953.dtsi              | 288 +++++++++++++++++++++
 arch/arm/boot/dts/am335x-phycore-rdk.dts           |  27 ++
 4 files changed, 319 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-pcm-953.dtsi
 create mode 100644 arch/arm/boot/dts/am335x-phycore-rdk.dts
Documentation/devicetree/bindings/arm/omap/omap.txt +3 -0
index 05f95c3..8219b2c 100644
@@ -151,6 +151,9 @@ Boards:
 - AM335X SBC-T335 : single board computer, built around the Sitara AM3352/4
   compatible = "compulab,sbc-t335", "compulab,cm-t335", "ti,am33xx"
 
+- AM335X phyCORE-AM335x: Development kit
+  compatible = "phytec,am335x-pcm-953", "phytec,am335x-phycore-som", "ti,am33xx"
+
 - OMAP5 EVM : Evaluation Module
   compatible = "ti,omap5-evm", "ti,omap5"
arch/arm/boot/dts/Makefile +1 -0
index f10fe85..797c520 100644
@@ -573,6 +573,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
 	am335x-lxm.dtb \
 	am335x-nano.dtb \
 	am335x-pepper.dtb \
+	am335x-phycore-rdk.dtb \
 	am335x-shc.dtb \
 	am335x-sbc-t335.dtb \
 	am335x-sl50.dtb \
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +288 -0

288 lines not on this page · raw message

arch/arm/boot/dts/am335x-phycore-rdk.dts new file +27 -0
new file mode 100644
index 0000000..305f0b3
@@ -0,0 +1,27 @@
+/*
+ * Copyright (C) 2014 PHYTEC Messtechnik GmbH
+ * Author: Wadim Egorov <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+
+#include "am335x-phycore-som.dtsi"
+#include "am335x-pcm-953.dtsi"
+
+/* SoM */
+&i2c_eeprom {
+	status = "okay";
+};
+
+&i2c_rtc {
+	status = "okay";
+};
+
+&serial_flash {
+	status = "okay";
+
+};
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 2/3 ARM: configs: omap2plus_defconfig: Enable support for micrell phys

The phyCORE-AM335x SoM with PCM-953 carrierboard has a KSZ9021 phy mounted. To add support for this we need to enable the micrell phy driver in the config.

Signed-off-by Teresa Remmet <[email protected]>
---
 arch/arm/configs/omap2plus_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/omap2plus_defconfig +1 -0
index 195c98b..0c2bf2d 100644
@@ -168,6 +168,7 @@ CONFIG_TI_CPTS=y
 # CONFIG_NET_VENDOR_VIA is not set
 # CONFIG_NET_VENDOR_WIZNET is not set
 CONFIG_AT803X_PHY=y
+CONFIG_MICREL_PHY=y
 CONFIG_SMSC_PHY=y
 CONFIG_USB_USBNET=m
 CONFIG_USB_NET_SMSC75XX=m
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH v2 3/3 ARM: configs: omap2plus_defconfig: Enable support for RTC M41T80

In reply to Teresa Remmet

The phyCORE-AM335x SoM has a RV4162 RTC populated which is supported by the M41T80 driver. Enabled it so make the RTC support on the SoM available.

Signed-off-by Teresa Remmet <[email protected]>
---
 arch/arm/configs/omap2plus_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/omap2plus_defconfig +1 -0
index 0c2bf2d..75b5b73 100644
@@ -414,6 +414,7 @@ CONFIG_LEDS_TRIGGER_GPIO=m
 CONFIG_LEDS_TRIGGER_DEFAULT_ON=m
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_DS1307=m
+CONFIG_RTC_DRV_M41T80=m
 CONFIG_RTC_DRV_TWL92330=y
 CONFIG_RTC_DRV_TWL4030=m
 CONFIG_RTC_DRV_PALMAS=m
Signature · 1 line
1.9.1
maintainer
#3 lore raw

PATCH v2 1/3 ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

In reply to Teresa Remmet
Quoted 15 lines · Teresa Remmet

The phyCORE-AM335x development kit is a combination of the phyCORE-AM335x SoM and a PCM-953 carrier board. The features of the PCM-953 are:
* ETH phy on carrier board: 1x RGMII
* 1x CAN
* Up to 4x UART
* USB0 (otg)
* USB1 (host)
* SD slot
* User gpio-keys
* User LEDs

Signed-off-by Teresa Remmet <[email protected]>
Reviewed-by Wadim Egorov <[email protected]>
Acked-by Rob Herring <[email protected]>
Quoted 8 lines

---
Changes in v2:
- moved gpio-keys, gpio-leds and regulators nodes to root node
- moved muxing of gpio-keys and gpio-leds
- removed not needed compatible "simple-bus"
- fixed unit address of ethernet phy node
- removed redundant status properties
- added Acked-by: Rob Herring <[email protected]>

Applying this into omap-for-v4.11/dt thanks. The defconfig changes I already applied into omap-for-v4.11/defconfig.

Regards,

Tony

#4 lore raw

PATCH v2 1/3 ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

In reply to Teresa Remmet
Quoted 32 lines · Teresa Remmet

The phyCORE-AM335x development kit is a combination of the phyCORE-AM335x SoM and a PCM-953 carrier board. The features of the PCM-953 are:
* ETH phy on carrier board: 1x RGMII
* 1x CAN
* Up to 4x UART
* USB0 (otg)
* USB1 (host)
* SD slot
* User gpio-keys
* User LEDs

Signed-off-by Teresa Remmet <[email protected]>
Reviewed-by Wadim Egorov <[email protected]>
Acked-by Rob Herring <[email protected]>

---
Changes in v2:
- moved gpio-keys, gpio-leds and regulators nodes to root node
- moved muxing of gpio-keys and gpio-leds
- removed not needed compatible "simple-bus"
- fixed unit address of ethernet phy node
- removed redundant status properties
- added Acked-by: Rob Herring <[email protected]>

 .../devicetree/bindings/arm/omap/omap.txt          |   3 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/am335x-pcm-953.dtsi              | 288 +++++++++++++++++++++
 arch/arm/boot/dts/am335x-phycore-rdk.dts           |  27 ++
 4 files changed, 319 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-pcm-953.dtsi
 create mode 100644 arch/arm/boot/dts/am335x-phycore-rdk.dts

[...]

arch/arm/boot/dts/am335x-pcm-953.dtsi

Quoted 5 lines
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +0 -0
new file mode 100644
index 0000000..02981ea

[...]

};

Quoted 9 lines
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +9 -0
+	};
+
+	user_buttons: user_buttons {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&user_buttons_pins>;
+
+		button at 0 {
+			label = "home";

arch/arm/boot/dts/am335x-pcm-953.dtsi line 73

Quoted 10 lines
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +10 -0
+			linux,code = <KEY_HOME>;
+			gpios = <&gpio3 7 GPIO_ACTIVE_HIGH>;
+			gpio-key,wakeup;
+		};
+
+		button at 1 {
+			label = "menu";
+			linux,code = <KEY_MENU>;
+			gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+			gpio-key,wakeup;

Could you please replace this with wakeup-source as specified in Documentation/devicetree/bindings/power/wakeup-source.txt

I know this patch is merged, just fix it on top of linux-next ? I think TI/OMAP downstream tree has some remnants of the legacy boolean and it keeps slipping through every merge window :)

Signature · 2 lines
Regards,
Sudeep
maintainer
#5 lore raw

PATCH v2 1/3 ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

Quoted 22 lines · Sudeep Holla
Quoted 7 lines · Teresa Remmet
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +7 -0
+	user_buttons: user_buttons {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&user_buttons_pins>;
+
+		button at 0 {
+			label = "home";

arch/arm/boot/dts/am335x-pcm-953.dtsi line 73

Quoted 10 lines
arch/arm/boot/dts/am335x-pcm-953.dtsi new file +10 -0
+			linux,code = <KEY_HOME>;
+			gpios = <&gpio3 7 GPIO_ACTIVE_HIGH>;
+			gpio-key,wakeup;
+		};
+
+		button at 1 {
+			label = "menu";
+			linux,code = <KEY_MENU>;
+			gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+			gpio-key,wakeup;

Could you please replace this with wakeup-source as specified in Documentation/devicetree/bindings/power/wakeup-source.txt

Quoted 3 lines

I know this patch is merged, just fix it on top of linux-next ? I think TI/OMAP downstream tree has some remnants of the legacy boolean and it keeps slipping through every merge window :)

Oops sorry these keep coming. Teresa, can you please send a follow-up fix against current Linux next?

Regards,

Tony