Skip to contentSkip to conversation

DEVELOPERS: Add entry for upower

PATCH New Romain Naour 5 participants 9 messages Jan 8, 2017 – Jan 26, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DEVELOPERS: Add entry for upower

---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)
DEVELOPERS +1 -0
index b4b460f..79dd097 100644
@@ -1275,6 +1275,7 @@ F:	package/mcelog/
 F:	package/openpowerlink/
 F:	package/stress-ng/
 F:	package/terminology/
+F:	package/upower/
 F:	package/xenomai/
 
 N:	Romain Perier <[email protected]>
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +7 -0
index 20445b8..8dfbbc8 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.
+
 config BR2_PACKAGE_PERL_DB_FILE
 	bool "perl-db-file removed"
 	select BR2_LEGACY
Signature · 1 line
2.9.3
#2 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

Hello,

Quoted 15 lines · Romain Naour

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +0 -0
index 20445b8..8dfbbc8 100644

Config.in.legacy endif · line 153

Quoted 9 lines
Config.in.legacy +6 -0
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

Cc'ing Arnout and Yann, to get their insights.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

Quoted 21 lines · Thomas Petazzoni

Hello,

Quoted 18 lines · Romain Naour

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +0 -0
index 20445b8..8dfbbc8 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
Quoted 10 lines

Config.in.legacy endif · line 153

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

No we don't. We certainly don't want that changing some option (the server
version) suddenly creates a legacy option.

Also, legacy is not needed here: it never was possible (in a released
buildroot) to select this option for v1.19.0+.

Regards,
Arnout

Quoted 7 lines

Cc'ing Arnout and Yann, to get their insights.

Thanks,

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

Hi Arnout, Thomas, All,

Le 25/01/2017 ? 11:56, Arnout Vandecappelle a ?crit :

Quoted 34 lines · Thomas Petazzoni
Quoted 21 lines

Hello,

Quoted 18 lines · Romain Naour

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +0 -0
index 20445b8..8dfbbc8 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
Quoted 10 lines

Config.in.legacy endif · line 153

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

Quoted 2 lines

No we don't. We certainly don't want that changing some option (the server
version) suddenly creates a legacy option.

Indeed it's annoying...

Quoted 3 lines

Also, legacy is not needed here: it never was possible (in a released
buildroot) to select this option for v1.19.0+.

...but the xserver package is special since we support several versions. If only one version was used, this option would be removed with the bump to 1.19.0 and a legacy entry added.

If we previously used the latest xserver version (1.18.4) in 2016.11 with BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently removed from the defconfig with 2017.02.

How we should handle new/old options when a package has several version available ?

Best regards,
Romain

Quoted 12 lines

Regards,
Arnout

Quoted 7 lines

Cc'ing Arnout and Yann, to get their insights.

Thanks,

Thomas

#5 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

Quoted 50 lines · Romain Naour

Hi Arnout, Thomas, All,

Le 25/01/2017 ? 11:56, Arnout Vandecappelle a ?crit :

Quoted 34 lines · Thomas Petazzoni
Quoted 21 lines

Hello,

Quoted 18 lines · Romain Naour

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +0 -0
index 20445b8..8dfbbc8 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
Quoted 10 lines

Config.in.legacy endif · line 153

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

Quoted 2 lines

No we don't. We certainly don't want that changing some option (the server
version) suddenly creates a legacy option.

Indeed it's annoying...

Quoted 3 lines

Also, legacy is not needed here: it never was possible (in a released
buildroot) to select this option for v1.19.0+.

...but the xserver package is special since we support several versions. If only one version was used, this option would be removed with the bump to 1.19.0 and a legacy entry added.

Quoted 5 lines

If we previously used the latest xserver version (1.18.4) in 2016.11 with BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX selected, this option will be silently removed from the defconfig with 2017.02.

How we should handle new/old options when a package has several version available ?

Well, normally the BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_18 legacy entry would
force the user to select a different version, and it would be obvious that aiglx disappears in v1.19. However, we didn't add a legacy entry for v1.18...

Regards,
Arnout

Quoted 17 lines

Best regards,
Romain

Quoted 12 lines

Regards,
Arnout

Quoted 7 lines

Cc'ing Arnout and Yann, to get their insights.

Thanks,

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#6 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

In reply to Arnout Vandecappelle

On 2017-01-25 11:56 +0100, Arnout Vandecappelle spake thusly:

Quoted 35 lines · Thomas Petazzoni
Quoted 21 lines

Hello,

Quoted 18 lines · Romain Naour

The legacy entry was missing in commit [1].

[1] ec502ea8e4fec1e113b5f7c532809a05644a9fd4

---
 Config.in.legacy | 7 +++++++
 1 file changed, 7 insertions(+)
Config.in.legacy +0 -0
index 20445b8..8dfbbc8 100644
@@ -145,6 +145,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.02"
 
Quoted 10 lines

Config.in.legacy endif · line 153

Quoted 6 lines
Config.in.legacy +6 -0
+config BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX
+	bool "xserver AIGLX Extension removed"
+	depends on !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_14 && !BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17
+	select BR2_LEGACY
+	help
+	  The xserver AIGLX Extension has been removed in 1.19.0 release.

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

Quoted 2 lines

No we don't. We certainly don't want that changing some option (the server
version) suddenly creates a legacy option.

My stake on this:

- we must add a legacy entry for 1.18

- we must not add a legacy entry for AIGLX, because it is not yet legacy. It will turn legacy when the last xserver version we have that support AIGLX is dropped. For now, it is just an package option that is only available with some versions (1.17 and 1.14).

Quoted 2 lines

Also, legacy is not needed here: it never was possible (in a released
buildroot) to select this option for v1.19.0+.

Agreed.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/1 legacy/xserver: add a legacy entry for xserver >= 1.19.0

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 10 lines
Quoted 6 lines
Quoted 3 lines

Hum, but then we have the BR2_PACKAGE_XSERVER_XORG_SERVER_AIGLX option defined in two different places, with two different prompts. Do we really want to do this?

No we don't. We certainly don't want that changing some option (the server version) suddenly creates a legacy option.

My stake on this:

- we must add a legacy entry for 1.18

Ok.

Quoted 4 lines

- we must not add a legacy entry for AIGLX, because it is not yet legacy. It will turn legacy when the last xserver version we have that support AIGLX is dropped. For now, it is just an package option that is only available with some versions (1.17 and 1.14).

As I understood it, AIGLX support is now unconditionally enabled:

https://cgit.freedesktop.org/xorg/xserver/commit/?id=501d8e2beb337e072c93c9310fcd927a099b9c3b

So the legacy option would just state that this option is now unconditionally enabled. I'm not sure how helpful that is. The user is presumably already notified that the server version has changed (E.G. from 1.14/1.17 to 1.19+).

Signature · 1 line
Bye, Peter Korsgaard