Skip to contentSkip to conversation

staging: octeon-usb: Fix coding style issues

PATCH In review William Blough 2 participants 2 messages Jan 27, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: octeon-usb: Fix coding style issues

Wrap lines that exceed 80 characters.

---
 drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/octeon-usb/octeon-hcd.c +12 -6
index 9a7858a..6b86bfb 100644
@@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 				/* Disable all interrupts except CHHLTD */
 				hcintmsk.u32 = 0;
 				hcintmsk.s.chhltdmsk = 1;
-				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCINTMSKX(channel, usb->index),
-						     hcintmsk.u32);
+				cvmx_usb_write_csr32(
+						usb,
+						CVMX_USBCX_HCINTMSKX(
+								channel,
+								usb->index),
+						hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
-				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(channel, usb->index),
-						     usbc_hcchar.u32);
+				cvmx_usb_write_csr32(
+						usb,
+						CVMX_USBCX_HCCHARX(
+								channel,
+								usb->index),
+						usbc_hcchar.u32);
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
 				/*
Signature · 1 line
2.1.4
#1 lore raw
Quoted 27 lines · William Blough

Wrap lines that exceed 80 characters.

---
 drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/octeon-usb/octeon-hcd.c +6 -5
index 9a7858a..6b86bfb 100644
@@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 				/* Disable all interrupts except CHHLTD */
 				hcintmsk.u32 = 0;
 				hcintmsk.s.chhltdmsk = 1;
-				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCINTMSKX(channel, usb->index),
-						     hcintmsk.u32);
+				cvmx_usb_write_csr32(
+						usb,
+						CVMX_USBCX_HCINTMSKX(
+								channel,
+								usb->index),
+						hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
-				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(channel, usb->index),

drivers/staging/octeon-usb/octeon-hcd.c static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel) · line 2653

Quoted 10 lines
drivers/staging/octeon-usb/octeon-hcd.c +6 -1
-						     usbc_hcchar.u32);
+				cvmx_usb_write_csr32(
+						usb,
+						CVMX_USBCX_HCCHARX(
+								channel,
+								usb->index),
+						usbc_hcchar.u32);
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
 				/*

That's horrid, the original code looks better, please leave it as-is.

thanks,

greg k-h