Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/2 Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver
This binding provides interface for adding values related to ASPEED AST2400/2500 PWM and Fan tach controller support.
The PWM controller can support upto 8 PWM output ports. The Fan tach controller can support upto 16 tachometer inputs. Types M, N and 0 are three types just to have three independent PWM/Fan Tach related settings.
---
v2:
- Removed '_' in node or property names
- Gave some explanation for the properties used.
.../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 178 +++++++++++++++++++++ 1 file changed, 178 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +178 -0
@@ -0,0 +1,178 @@ +ASPEED AST2400/AST2500 PWM and Fan Tacho controller device driver + +The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho +controller can support upto 16 tachometer inputs. + +There are three different types M, N, O. These three types are just to have +different PWM and Fan Tach settings. Each type can have the following settings: + PWM related: + 1) PWM period + 2) PWM clock division high + 3) PWM clock division low + Fan Tach related: + 1) Fan Tach type enable + 2) Fan Tach clock division + 3) Fan Tach mode selection + 4) Fan Tach period + +Each PWM port should be assigned a type which can be type M, N or O. + +Each Fan Tach channel should be assigned a PWM source, which can be PWM port A +through H. The Fan Tach channel implicitly gets the type (M, N or O), from the +type assigned to its PWM source. + +Required properties for pwm-tacho node: +- #address-cells : should be 1. + +- #size-cells : should be 1. + +- reg : address and length of the register set for the device. + +- pinctrl-names : a pinctrl state named "default" must be defined. + +- pinctrl-0 : phandle referencing pin configuration of the AST2400/AST2500 PWM + ports. + +- compatible : should be "aspeed,aspeed2400-pwm-tacho" for AST2400 or + "aspeed,aspeed2500-pwm-tacho" for AST2500. + +- clocks : a fixed clock providing input clock frequency(PWM + and Fan Tach clock) + +type-values subnode format: +=========================== +Under type-values subnode there can be upto 3 child nodes indicating type M/N/O +values. Atleast one child node is required. + +Required properties for the child node(type M/N/O): +- type : indicates type M/N/O. integer value in the range 0 to 2 with 0 + indicating type M, 1 indicating type N and 2 indicating type O. + +- pwm-period : indicates type M/N/O PWM period, as per the AST2400/AST2500 + datasheet. integer value in the range 0 to 255. + +- pwm-clock-division-l : indicates type M/N/O PWM clock division L value, + as per the AST2400/AST2500 datasheet. + integer value in the range 0 to 15. + 0 here indicates divide 1, 1 indicates divide 2, + 2 indicates divide 4, 3 indicates divide 6, and so on + till 15 indicates divide 30. + +- pwm-clock-division-h : indicates type M/N/O PWM clock division H value, + as per the AST2400/AST2500 datasheet. + integer value in the range 0 to 15. + 0 here indicates divide 1, 1 indicates divide 2, + 2 indicates divide 4, 3 indicates divide 8, and so on + till 15 indicates divide 32768. + +- fan-tach-type-enable : indicates fan tach enable of type M/N/O as per the + AST2400/AST2500 datasheet. boolean value. + +- fan-tach-clock-division : indicates fan tach clock division as per the + AST2400/AST2500 datasheet. + integer value in the range 0 to 7. + 0 indicates divide 4, 1 indicates divide 16, + 2 indicates divide 64, 3 indicates divide 256 + and so on till 7 indicates divide 65536. + +- fan-tach-mode-selection : indicates fan tach mode mode selection as per the + AST2400/AST2500 datasheet. integer value in the + range 0 to 2. 0 indicates falling edge, 1 indicates + rising edge and 2 indicates both edges. + +- fan-tach-period : indicates fan tach period as per the AST2400/AST2500 + datasheet. integer value (can be upto 16 bits long). + +pwm-port subnode format: +======================== +Under pwm-port subnode there can upto 8 child nodes each indicating values +for one of the 8 PWM output ports. + +Required properties for each child node(starting from PWM A through PWM H): +- pwm-port : should specify PWM #X port , X ranges from A through H. + integer value in the range 0 to 7 with 0 indicating PWM port + A and 7 indicating PWM port H. + +- type : indicates type selection value of PWM port. integer value in the + range 0 to 2; 0 indicates type M, 1 indicates type N, 2 indicates + type O. + +- fan-ctrl : set the PWM duty cycle initial value. integer value between + 0(off) and 255(full speed). + +fan-tach-channel subnode format: +================================ +Under fan-tach-channel subnode there can be upto 16 child nodes each indicating +values for one of the 16 fan tach channels. + +Required properties for each child node(starting from fan tach #0 through +fan tach #15): +- fan-ctrl-gpios : should specify the tachometer input GPIO pin on the hardware. + Fan Tachometer function can only work when GPIO is in + ”input mode” + +- fan-tach : should specify the fan tach channel #X, X ranges from 0 through + 15. integer value in the range 0 through 15. + +- pwm-source : indicates PWM source of the fan tach channel. integer value in + the range 0 to 7. 0 indicates PWM port A, 1 indicates PWM + port B and so on till 7 indicates PWM port H. + +Examples: + +pwm-tacho-fixed-clk: fixedclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <24000000>; +} + +pwm-tacho: pwm-tacho-controller@1e786000 { + #address-cells = <1>; + #size-cells = <1>; + reg = <0x1E786000 0x1000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>; + compatible = "aspeed,aspeed2500-pwm-tacho"; + clocks = <&pwm-tacho-fixed-clk>; + type-values { + typem { + type = /bits/ 8 <0x00>; + pwm-period = /bits/ 8 <0x5F>; + pwm-clock-division-h = /bits/ 8 <0x00>; + pwm-clock-division-l = /bits/ 8 <0x05>; + fan-tach-type-enable; + fan-tach-clock-division = /bits/ 8 <0x00>; + fan-tach-mode-selection = /bits/ 8 <0x00>; + fan-tach-period = /bits/ 16 <0x1000>; + }; + }; + + pwm-port { + pwm-port0 { + pwm-port = /bits/ 8 <0x00>; + type = /bits/ 8 <0x00>; + fan-ctrl = /bits/ 8 <0xFF>; + }; + + pwm-port1 { + pwm-port = /bits/ 8 <0x01>; + type = /bits/ 8 <0x00>; + fan-ctrl = /bits/ 8 <0xFF>; + }; + }; + + fan-tach-channel { + fan-tach0 { + fan-ctrl-gpios = <&gpio ASPEED_GPIO(O, 0) GPIO_ACTIVE_HIGH>; + fan-tach = /bits/ 8 <0x00>; + pwm-source = /bits/ 8 <0x00>; + }; + + fan-tach1 { + fan-ctrl-gpios = <&gpio ASPEED_GPIO(O, 1) GPIO_ACTIVE_HIGH>; + fan-tach = /bits/ 8 <0x01>; + pwm-source = /bits/ 8 <0x01>; + }; + + }; +};
--
2.11.0.483.g087da7b7c-goog
Rob Herring
maintainerQuoted 6 lines · Jaghathiswari Rankappagounder Natarajan
This binding provides interface for adding values related to ASPEED AST2400/2500 PWM and Fan tach controller support.
The PWM controller can support upto 8 PWM output ports. The Fan tach controller can support upto 16 tachometer inputs. Types M, N and 0 are three types just to have three independent PWM/Fan Tach related settings.
This still looks overly complicated to me and very specific to ASpeed. You need to define a common structure that works for fans. To start with, define a node for the fans themselves. This should use the PWM binding and a -gpios property for the tach (when connected to a GPIO).
Something like this:
ctrl: fan-controller@1234 {
...
#pwm-cells = <3>;
fan@0 {
reg = <0>; /* 'Channel' of the controller */
pwms = <&ctrl 0 ...>;
tach-gpios = <&gpio 1>;
vcc-supply = <®_12V>;
};
};We already have a pwm-fan binding. This should build on or possibly replace that.
Quoted 17 lines
---
v2:
- Removed '_' in node or property names
- Gave some explanation for the properties used..../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 178 +++++++++++++++++++++ 1 file changed, 178 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txtDocumentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +0
-0
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt line 4
Quoted 4 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +4
-0@@ -0,0 +1,178 @@ +ASPEED AST2400/AST2500 PWM and Fan Tacho controller device driver + +The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho +controller can support upto 16 tachometer inputs.
AIUI, each fan has a PWM and a tach input. How would you use more than 8 tach inputs?
Quoted 4 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +4
-0+ +There are three different types M, N, O. These three types are just to have +different PWM and Fan Tach settings. Each type can have the following settings: + PWM related:
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +10
-0+ 1) PWM period + 2) PWM clock division high + 3) PWM clock division low + Fan Tach related: + 1) Fan Tach type enable + 2) Fan Tach clock division + 3) Fan Tach mode selection + 4) Fan Tach period + +Each PWM port should be assigned a type which can be type M, N or O.
What is the definition of M, N, and O?
Rob
Quoted 27 lines · Rob Herring
Quoted 6 lines · Jaghathiswari Rankappagounder Natarajan
This binding provides interface for adding values related to ASPEED AST2400/2500 PWM and Fan tach controller support.
The PWM controller can support upto 8 PWM output ports. The Fan tach controller can support upto 16 tachometer inputs. Types M, N and 0 are three types just to have three independent PWM/Fan Tach related settings.This still looks overly complicated to me and very specific to ASpeed. You need to define a common structure that works for fans. To start with, define a node for the fans themselves. This should use the PWM binding and a -gpios property for the tach (when connected to a GPIO).
Something like this:
ctrl: fan-controller@1234 { ... #pwm-cells = <3>; fan@0 { reg = <0>; /* 'Channel' of the controller */ pwms = <&ctrl 0 ...>; tach-gpios = <&gpio 1>; vcc-supply = <®_12V>; }; };
Quoted 3 lines
We already have a pwm-fan binding. This should build on or possibly replace that.
I have rewritten the structure to be more common and sent the updated patch. There can be upto 8 fans. Each fan can have 1 PWM source and 1/2 Fan tach inputs.
I think the pwm-binding may not be very relevant. The pwm-binding indicates that there can be a unique period value for each pwm(ie 500000 in pwms = <&ctrl 0 500000>).
But here each pwm can't have a unique period value.
There can be only 3 settings (type m, type n, type o). Each setting includes values like pwm period,fan_tach_period, etc
Each fan can be configured with one of the three settings. So the pwm and the fan tach associated
with the fan will inherit some values from the setting which the fan used. In the updated patch, I have used a default setting(type m) for the fans.
Quoted 11 lines
Quoted 11 lines
---
v2:
- Removed '_' in node or property names
- Gave some explanation for the properties used..../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 178 +++++++++++++++++++++ 1 file changed, 178 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt
Quoted 14 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt line 4
Quoted 10 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +4
-0@@ -0,0 +1,178 @@ +ASPEED AST2400/AST2500 PWM and Fan Tacho controller device driver + +The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho +controller can support upto 16 tachometer inputs.AIUI, each fan has a PWM and a tach input. How would you use more than 8 tach inputs?
Each fan can have 1 PWM source and 1/2 Fan tach inputs.
Quoted 18 lines
Quoted 4 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +4
-0+ +There are three different types M, N, O. These three types are just to have +different PWM and Fan Tach settings. Each type can have the following settings: + PWM related:Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt new file +10
-0+ 1) PWM period + 2) PWM clock division high + 3) PWM clock division low + Fan Tach related: + 1) Fan Tach type enable + 2) Fan Tach clock division + 3) Fan Tach mode selection + 4) Fan Tach period + +Each PWM port should be assigned a type which can be type M, N or O.What is the definition of M, N, and O?
Rob
PATCH v2 2/2 drivers: hwmon: hwmon driver for ASPEED AST2400/2500 PWM and Fan tach controller
In reply to a message not in the archiveThe ASPEED AST2400/2500 PWM controller supports 8 PWM output ports. The ASPEED AST2400/2500 Fan tach controller supports 16 tachometer inputs. Types M, N and 0 are three types just to have three independent PWM/Fan Tach related settings.
The device driver matches on the device tree node. The configuration values are read from the device tree and written to the respective registers. The driver provides a sysfs entries through which the user can configure the duty-cycle value (ranging from 0 to 100 percent) and read the fan tach rpm value.
---
v2:
- Used BIT()
- Used regmap
- Avoided division when raw data is 0
- Removed empty lines between declaration
- Removed macros; Used two attribute groups and used is_visible callback
- Returned error when properties are undefined
- Removed .owner field
- Used PTR_ERR_OR_ZERO
- Removed explicit of_node_put for child nodes
Documentation/hwmon/aspeed-pwm-tacho | 22 + drivers/hwmon/Kconfig | 9 + drivers/hwmon/Makefile | 1 + drivers/hwmon/aspeed-pwm-tacho.c | 895 +++++++++++++++++++++++++++++++++++ 4 files changed, 927 insertions(+) create mode 100644 Documentation/hwmon/aspeed-pwm-tacho create mode 100644 drivers/hwmon/aspeed-pwm-tacho.c
Documentation/hwmon/aspeed-pwm-tacho new file +22 -0
@@ -0,0 +1,22 @@ +Kernel driver aspeed-pwm-tacho +============================== + +Supported chips: + ASPEED AST2400/2500 + +Authors: + <[email protected]> + +Description: +------------ +This driver implements support for ASPEED AST2400/2500 PWM and Fan Tacho +controller. The PWM controller supports upto 8 PWM outputs. The Fan tacho +controller supports upto 16 tachometer inputs. + +The driver provides the following sensor accesses in sysfs: + +fanX_input ro provide current fan rotation value in RPM as reported + by the fan to the device. + +pwmX rw get or set PWM fan control value. This is an integer + value between 0(off) and 255(full speed).
drivers/hwmon/Kconfig +9 -0
@@ -341,6 +341,15 @@ config SENSORS_ASB100 This driver can also be built as a module. If so, the module will be called asb100. +config SENSORS_ASPEED + tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver" + help + This driver provides support for ASPEED AST2400/AST2500 PWM + and Fan Tacho controllers. + + This driver can also be built as a module. If so, the module + will be called aspeed_pwm_tacho. + config SENSORS_ATXP1 tristate "Attansic ATXP1 VID controller" depends on I2C
drivers/hwmon/Makefile +1 -0
@@ -46,6 +46,7 @@ obj-$(CONFIG_SENSORS_ADT7475) += adt7475.o obj-$(CONFIG_SENSORS_APPLESMC) += applesmc.o obj-$(CONFIG_SENSORS_ARM_SCPI) += scpi-hwmon.o obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o +obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o obj-$(CONFIG_SENSORS_ATXP1) += atxp1.o obj-$(CONFIG_SENSORS_CORETEMP) += coretemp.o obj-$(CONFIG_SENSORS_DA9052_ADC)+= da9052-hwmon.o
drivers/hwmon/aspeed-pwm-tacho.c new file +895 -0
895 lines not on this page · raw message
--
2.11.0.483.g087da7b7c-goog
kbuild test robot
build botRe: [PATCH linux v2 2/2] drivers: hwmon: hwmon driver for ASPEED AST2400/2500 PWM and Fan tach controller
reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree…
Hi Jaghathiswari,
[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v4.10-rc5 next-20170125]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jaghathiswari-Rankappagounder-Natarajan/Documentation-dt-bindings-Document-bindings-for-ASPEED-AST2400-AST2500-PWM-and-Fan-tach-controller-device-driver/20170127-174933 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: openrisc-allyesconfig (attached as .config) compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All warnings (new ones prefixed by >>):
drivers/hwmon/aspeed-pwm-tacho.c: In function 'aspeed_get_fan_tach_ch_rpm':
>> drivers/hwmon/aspeed-pwm-tacho.c:492:16: warning: unused variable 'rpm'
vim +/rpm +492 drivers/hwmon/aspeed-pwm-tacho.c
476 div_l = priv->type_pwm_clock_division_l[type];
477 if (div_l == 0)
478 div_l = 1;
479 else
480 div_l = div_l * 2;
481
482 tacho_unit = priv->type_fan_tach_unit[type];
483 tacho_div = priv->type_fan_tach_clock_division[type];
484
485 tacho_div = 0x4 << (tacho_div * 2);
486 return clk / (clk_unit * div_h * div_l * tacho_div * tacho_unit);
487 }
488
489 static u32 aspeed_get_fan_tach_ch_rpm(struct aspeed_pwm_tacho_data *priv,
490 u8 fan_tach_ch)
491 {
> 492 u32 raw_data, rpm, tach_div, clk_source, timeout = 0, sec, val;
493 u8 fan_tach_ch_source, type;
494
495 regmap_write(priv->regmap, ASPEED_PTCR_TRIGGER, 0);
496 regmap_write(priv->regmap, ASPEED_PTCR_TRIGGER, 0x1 << fan_tach_ch);
497
498 fan_tach_ch_source = priv->fan_tach_ch_source[fan_tach_ch];
499 type = priv->pwm_port_type[fan_tach_ch_source];
500
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation