Request to merge in padovan's fence fd fix
Chad Versace
Acked-by Laurent PinchartChris just pushed execbuffer fence fds to dinq. Could someone please get the below fix from airlied/drm-fixes into dinq? (What's the usual method here? Merge drm-fixes -> dinq, cherry-pick drm-fixes -> dinq, rebase?)
Thanks
commit 7e9081c5aac73b8a0bc22e0b3e7a12c3e9cf5256
Author: Gustavo Padovan <[email protected]>
Date: Fri Jan 13 12:22:09 2017 -0200
drm/fence: fix memory overwrite when setting out_fence fd
Currently if the userspace declares a int variable to store the out_fence fd and pass it to OUT_FENCE_PTR the kernel will overwrite the 32 bits above the int variable on 64 bits systems.
Fix this by making the internal storage of out_fence in the kernel a s32 pointer.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Chad Versace
Chris just pushed execbuffer fence fds to dinq. Could someone please get the below fix from airlied/drm-fixes into dinq? (What's the usual method here? Merge drm-fixes -> dinq, cherry-pick drm-fixes -> dinq, rebase?)
For testing, just test using the drm-tip tree, which has everything. For merging patches that need both, ping the drm-misc/drm-intel maintainers and we'll orchestrate some backmerge festival. We need that anyway for other stuff, so should happen this week.
In general, for testing/consumption, running dinq is the wrong thing. -Daniel
Quoted 26 lines
Thanks
commit
7e9081c5aac73b8a0bc22e0b3e7a12c3e9cf5256
Author: Gustavo Padovan <[email protected]>
Date: Fri Jan 13 12:22:09 2017 -0200drm/fence: fix memory overwrite when setting
out_fencefdCurrently if the userspace declares a int variable to store the
out_fencefd and pass it toOUT_FENCE_PTRthe kernel will overwrite the 32 bits above the int variable on 64 bits systems.Fix this by making the internal storage of
out_fencein the kernel a s32 pointer.Reported-by Chad Versace <[email protected]>Signed-off-by Gustavo Padovan <[email protected]>Fixes beaf5af48034 ("drm/fence: add out-fences support")Cc Daniel Vetter <[email protected]>Cc Rafael Antognolli <[email protected]>Cc Laurent Pinchart <[email protected]>Acked-by Laurent Pinchart <[email protected]>Reviewed-and-Tested-by Chad Versace <[email protected]>
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx