Skip to contentSkip to conversation

gst-plugins-base: add missing dependency on libxml2 for subparse

PATCH New Danomi Manchego 2 participants 2 messages Dec 29, 2016 – Jan 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gst-plugins-base: add missing dependency on libxml2 for subparse

The gst-plugins-base configure script claims that the subparse plugin is dependency-less - but it also silently disables subparse if libxml2 is not available. So depend on libxml2 when subparse is selected.

Note: the analogous gst1 subparse plugin does not have this requirement.

---
 package/gstreamer/gst-plugins-base/Config.in           | 1 +
 package/gstreamer/gst-plugins-base/gst-plugins-base.mk | 1 +
 2 files changed, 2 insertions(+)
package/gstreamer/gst-plugins-base/Config.in +1 -0
index 8ad9a8e..e02675e 100644
@@ -48,6 +48,7 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_PLAYBACK
 
 config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_SUBPARSE
 	bool "subparse"
+	select BR2_PACKAGE_LIBXML2
 
 config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_TCP
 	bool "tcp"
package/gstreamer/gst-plugins-base/gst-plugins-base.mk +1 -0
index e1374ed..51c22a9 100644
@@ -111,6 +111,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_SUBPARSE),y)
 GST_PLUGINS_BASE_CONF_OPTS += --enable-subparse
+GST_PLUGINS_BASE_DEPENDENCIES += libxml2
 else
 GST_PLUGINS_BASE_CONF_OPTS += --disable-subparse
 endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 gst-plugins-base: add missing dependency on libxml2 for subparse

Hello,

Quoted 11 lines · Danomi Manchego

The gst-plugins-base configure script claims that the subparse plugin is dependency-less - but it also silently disables subparse if libxml2 is not available. So depend on libxml2 when subparse is selected.

Note: the analogous gst1 subparse plugin does not have this requirement.

---
 package/gstreamer/gst-plugins-base/Config.in           | 1 +
 package/gstreamer/gst-plugins-base/gst-plugins-base.mk | 1 +
 2 files changed, 2 insertions(+)

I've applied to master, but before that, I've moved the "subparse" option from the "dependency-less plugins" category to the "plugins with external dependencies" section.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com