dt-bindings: mfd: as3722: Drop reference to pm_power_off
PATCH 1/3 dt-bindings: mfd: as3722: Drop reference to pm_power_off
From: Guenter Roeck <[email protected]>
Devicetree bindings are supposed to be operating system independent and should thus not describe how a specific functionality is implemented in Linux.
--- Documentation/devicetree/bindings/mfd/as3722.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/as3722.txt +1 -2
@@ -122,8 +122,7 @@ Following are properties of regulator subnode. Power-off: ========= -AS3722 supports the system power off by turning off all its rail. This -is provided through pm_power_off. +AS3722 supports the system power off by turning off all its rails. The device node should have the following properties to enable this functionality ams,system-power-controller: Boolean, to enable the power off functionality
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): 20170130105122.6475-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
PATCH 2/3 dt-bindings: power: reset: gpio-poweroff: Drop reference to pm_power_off
From: Guenter Roeck <[email protected]>
pm_power_off is an implementation detail. Replace it with a more generic description of the driver's functionality.
--- .../devicetree/bindings/power/reset/gpio-poweroff.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt +5 -5
@@ -2,12 +2,12 @@ Driver a GPIO line that can be used to turn the power off. The driver supports both level triggered and edge triggered power off. At driver load time, the driver will request the given gpio line and -install a pm_power_off handler. If the optional properties 'input' is -not found, the GPIO line will be driven in the inactive +install a handler to power off the system. If the optional properties +'input' is not found, the GPIO line will be driven in the inactive state. Otherwise its configured as an input. -When the pm_power_off is called, the gpio is configured as an output, -and drive active, so triggering a level triggered power off +When the power-off handler is called, the gpio is configured as an +output, and drive active, so triggering a level triggered power off condition. This will also cause an inactive->active edge condition, so triggering positive edge triggered power off. After a delay of 100ms, the GPIO is set to inactive, thus causing an active->inactive edge,
@@ -24,7 +24,7 @@ Required properties: Optional properties: - input : Initially configure the GPIO line as an input. Only reconfigure - it to an output when the pm_power_off function is called. If this optional + it to an output when the power-off handler is called. If this optional property is not specified, the GPIO is initialized as an output in its inactive state.
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Rob Herring
AppliedQuoted 13 lines · Thierry Reding
From: Guenter Roeck <[email protected]>
Devicetree bindings are supposed to be operating system independent and should thus not describe how a specific functionality is implemented in Linux.
Cc Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Acked-by Mark Rutland <[email protected]>Signed-off-by Guenter Roeck <[email protected]>Acked-by Lee Jones <[email protected]>Signed-off-by Thierry Reding <[email protected]>
Quoted 3 lines
--- Documentation/devicetree/bindings/mfd/as3722.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 3/3 dt-bindings: power: reset: qnap-poweroff: Drop reference to pm_power_off
In reply to Thierry RedingFrom: Guenter Roeck <[email protected]>
Replace reference to pm_power_off (which is an implementation detail) and replace it with a more generic description of the driver's functionality.
--- Documentation/devicetree/bindings/power/reset/qnap-poweroff.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/power/reset/qnap-poweroff.txt +1 -2
@@ -3,8 +3,7 @@ QNAP NAS devices have a microcontroller controlling the main power supply. This microcontroller is connected to UART1 of the Kirkwood and Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the -microcontroller to turn the power off. This driver adds a handler to -pm_power_off which is called to turn the power off. +microcontroller to turn the power off. Synology NAS devices use a similar scheme, but a different baud rate, 9600, and a different character, '1'.
Signature · 1 line
2.11.0