Skip to contentSkip to conversation

Staging: media: lirc: style fix, using octal file permissions

PATCH In review Derek Robson 2 participants 2 messages Jan 7, 2017 – Jan 30, 2017

Subsystems (2)
Media (V4L/DVB) Staging
lore
Share & tools
lore

Derek Robson

author
#0 lore raw

PATCH 1/1 Staging: media: lirc: style fix, using octal file permissions

Change file permissions to octal style.
Found using checkpatch

Signed-off-by Derek Robson <[email protected]>
---
 drivers/staging/media/lirc/lirc_imon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/lirc/lirc_imon.c +1 -1
index 1e650fba4a92..6c8a4a15278e 100644
@@ -182,7 +182,7 @@ MODULE_DESCRIPTION(MOD_DESC);
 MODULE_VERSION(MOD_VERSION);
 MODULE_LICENSE("GPL");
 MODULE_DEVICE_TABLE(usb, imon_usb_id_table);
-module_param(debug, int, S_IRUGO | S_IWUSR);
+module_param(debug, int, 0644);
 MODULE_PARM_DESC(debug, "Debug messages: 0=no, 1=yes(default: no)");
 
 static void free_imon_context(struct imon_context *context)
Signature · 1 line
2.11.0
#1 lore raw
Quoted 13 lines · Derek Robson

Change file permissions to octal style.
Found using checkpatch

Signed-off-by Derek Robson <[email protected]>
---
 drivers/staging/media/lirc/lirc_imon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/lirc/lirc_imon.c +0 -0
index 1e650fba4a92..6c8a4a15278e 100644

drivers/staging/media/lirc/lirc_imon.c MODULE_DESCRIPTION(MOD_DESC); · line 188

Quoted 8 lines
drivers/staging/media/lirc/lirc_imon.c +1 -1
@@ -182,7 +182,7 @@ MODULE_DESCRIPTION(MOD_DESC);
 MODULE_VERSION(MOD_VERSION);
 MODULE_LICENSE("GPL");
 MODULE_DEVICE_TABLE(usb, imon_usb_id_table);
-module_param(debug, int, S_IRUGO | S_IWUSR);
+module_param(debug, int, 0644);
 MODULE_PARM_DESC(debug, "Debug messages: 0=no, 1=yes(default: no)");
 
 static void free_imon_context(struct imon_context *context)

In the current media tree, drivers/staging/media/lirc/lirc_imon.c has been merged with drivers/media/rc/imon.c already, I'm afraid. This patch no longer applies.

Sean