Skip to contentSkip to conversation

ARM: exynos_defconfig: Enable DYNAMIC_DEBUG and get rid of old ext3

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Jan 30, 2017

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: exynos_defconfig: Enable DYNAMIC_DEBUG and get rid of old ext3

DYNAMIC_DEBUG is quite useful for debugging kernels and should not cause noticeable performance regressions. It makes the kernel noticeably bigger (around 4%) but this difference should not impact typical developer and reference usage of this defconfig.

Sizes:

zImage-old:       4641496 bytes
zImage-new:       4811384 bytes

text data bss dec hex filename
7031229 2570916 327016 9929161 9781c9 vmlinux-old
7205921 2800052 327016 10332989 9dab3d vmlinux-new

Additionally, remove the EXT3_FS symbol because it is entirely replaced by EXT4_FS.

---
 arch/arm/configs/exynos_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/configs/exynos_defconfig +2 -1
index 12b8f69cbb52..746739027da6 100644
@@ -240,7 +240,7 @@ CONFIG_PWM=y
 CONFIG_PWM_SAMSUNG=y
 CONFIG_PHY_EXYNOS5250_SATA=y
 CONFIG_EXT2_FS=y
-CONFIG_EXT3_FS=y
+CONFIG_EXT4_FS=y
 CONFIG_AUTOFS4_FS=y
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y
@@ -255,6 +255,7 @@ CONFIG_NLS_CODEPAGE_437=y
 CONFIG_NLS_ASCII=y
 CONFIG_NLS_ISO8859_1=y
 CONFIG_PRINTK_TIME=y
+CONFIG_DYNAMIC_DEBUG=y
 CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
Signature · 1 line
2.9.3
Reviewed-by on v1 1/1
#1 lore raw

Hello Krzysztof,

Quoted 5 lines · Krzysztof Kozlowski

DYNAMIC_DEBUG is quite useful for debugging kernels and should not cause noticeable performance regressions. It makes the kernel noticeably bigger (around 4%) but this difference should not impact typical developer and reference usage of this defconfig.

Quoted 8 lines

Sizes:

zImage-old:       4641496 bytes
zImage-new:       4811384 bytes

text data bss dec hex filename
7031229 2570916 327016 9929161 9781c9 vmlinux-old
7205921 2800052 327016 10332989 9dab3d vmlinux-new

Agreed, most people usually will end enabling this option when debugging issues anyways so having enabled by default is quite convenient indeed.

Quoted 5 lines

Additionally, remove the EXT3_FS symbol because it is entirely replaced by EXT4_FS.

---

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America