Completion: Add support for --submodule=diff
PATCH 1/1 Completion: Add support for --submodule=diff
From: Peter Law <[email protected]>
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
--- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
contrib/completion/git-completion.bash +1 -1
@@ -1206,7 +1206,7 @@ _git_describe () __git_diff_algorithms="myers minimal patience histogram" -__git_diff_submodule_formats="log short" +__git_diff_submodule_formats="diff log short" __git_diff_common_options="--stat --numstat --shortstat --summary --patch-with-stat --name-only --name-status --color
Signature · 1 line
2.11.0
Hi,
Quoted 2 lines
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
I posted this patch back in December, but I've not heard anything. I'm sure as maintainers you're all quite busy, but I was wondering how long it usually takes to get a response to patches? (also whether I'd gotten some part of the submission process wrong?)
Thanks,
Peter
Quoted 5 lines · Peter Law
Hi,
Quoted 2 lines
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
Quoted 7 lines
I posted this patch back in December, but I've not heard anything. I'm sure as maintainers you're all quite busy, but I was wondering how long it usually takes to get a response to patches? (also whether I'd gotten some part of the submission process wrong?)
Thanks,
Peter
It looks like this must have just fallen through the cracks. Your patch looks good to me and works when I test it locally.
Signature · 1 line
Brandon Williams
Quoted 7 lines · Peter Law
Quoted 2 lines
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
I posted this patch back in December, but I've not heard anything. I'm sure as maintainers you're all quite busy, but I was wondering how long it usually takes to get a response to patches? (also whether I'd gotten some part of the submission process wrong?)
When there is clear "subsystem maintainer(s)" in the area, I try to refrain from commenting until they speak up, and completion scripts are one of these areas. I usually ping them after a few days but in December with holidays and things people are usually slow, and so was I X-<.
Will pick it up. Thanks for a reminder; you absolutely did the right thing (i.e. sending it out with people who are likely to know about the area CC'ed, waiting for a while and then sending a reminder).
Hi,
Quoted 16 lines · Junio C Hamano
Quoted 7 lines · Peter Law
Quoted 2 lines
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
I posted this patch back in December, but I've not heard anything. I'm sure as maintainers you're all quite busy, but I was wondering how long it usually takes to get a response to patches? (also whether I'd gotten some part of the submission process wrong?)
When there is clear "subsystem maintainer(s)" in the area, I try to refrain from commenting until they speak up, and completion scripts are one of these areas. I usually ping them after a few days but in December with holidays and things people are usually slow, and so was I X-<.
Quoted 4 lines
Will pick it up. Thanks for a reminder; you absolutely did the right thing (i.e. sending it out with people who are likely to know about the area CC'ed, waiting for a while and then sending a reminder).
Awesome, many thanks!
Peter
Quoted 24 lines · On Sun, Dec 4, 2016 at 6:41 AM, <[email protected]> wrote:
From: Peter Law <[email protected]>
Teach git-completion.bash about the 'diff' option to 'git diff --submodule=', which was added in Git 2.11.
Signed-off-by Peter Law <[email protected]>--- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)contrib/completion/git-completion.bash +1
-2@@ -1206,7 +1206,7 @@ _git_describe () __git_diff_algorithms="myers minimal patience histogram" -__git_diff_submodule_formats="log short" +__git_diff_submodule_formats="diff log short" __git_diff_common_options="--stat --numstat --shortstat --summary --patch-with-stat --name-only --name-status --color --
Quoted 2 lines
2.11.0
Yep, this looks good to me.
Thanks,
Jake