Skip to contentSkip to conversation

Don't handle Option "SwapbuffersWait" at all with glamor

PATCH In review Michel Dänzer 2 participants 2 messages Jan 31, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't handle Option "SwapbuffersWait" at all with glamor

From: Michel Dänzer <[email protected]>

It never had any effect with glamor.

---
 src/radeon_kms.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
src/radeon_kms.c +6 -4
index 446852564..58efd6ee5 100644
@@ -1801,10 +1801,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int flags)
 	}
     }
 
-    info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
-						 OPTION_SWAPBUFFERS_WAIT, TRUE);
-    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
-	       "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait ? "en" : "dis");
+    if (!info->use_glamor) {
+	info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
+						     OPTION_SWAPBUFFERS_WAIT, TRUE);
+	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+		   "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait ? "en" : "dis");
+    }
 
     if (xf86ReturnOptValBool(info->Options, OPTION_DELETE_DP12, FALSE)) {
         info->drmmode.delete_dp_12_displays = TRUE;
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170131072734.3290-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Tuesday, January 31, 2017 2:28 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Don't handle Option "SwapbuffersWait" at all with glamor

Quoted 5 lines

From: Michel Dänzer <[email protected]>

It never had any effect with glamor.

Good catch!

Quoted 30 lines
---
 src/radeon_kms.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
src/radeon_kms.c +3 -4
index 446852564..58efd6ee5 100644
@@ -1801,10 +1801,12 @@ Bool RADEONPreInit_KMS(ScrnInfoPtr pScrn, int
 flags)
 	}
     }
 
-    info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
-
 OPTION_SWAPBUFFERS_WAIT, TRUE);
-    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
-	       "SwapBuffers wait for vsync: %sabled\n", info->swapBuffersWait
 ? "en" : "dis");
+    if (!info->use_glamor) {
+	info->swapBuffersWait = xf86ReturnOptValBool(info->Options,
+

OPTION_SWAPBUFFERS_WAIT, TRUE);

src/radeon_kms.c +2 -0
+	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+		   "SwapBuffers wait for vsync: %sabled\n", info-
Quoted 1 line

swapBuffersWait ? "en" : "dis");

+ }

     if (xf86ReturnOptValBool(info->Options, OPTION_DELETE_DP12, FALSE)) {
         info->drmmode.delete_dp_12_displays = TRUE;
Quoted 7 lines

--
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx