Skip to contentSkip to conversation

video: fbdev: offb: switch to using for_each_node_by_type

PATCH In review Dmitry Torokhov 2 participants 2 messages Jan 31, 2017 – Feb 8, 2017 Framebuffer layer

lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 video: fbdev: offb: switch to using for_each_node_by_type

Instead of open-coding loops let's switch to a nice macro.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/video/fbdev/offb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/offb.c +2 -2
index 906c6e75c260..9be884b0c778 100644
@@ -668,14 +668,14 @@ static int __init offb_init(void)
 		offb_init_nodriver(of_chosen, 1);
 	}
 
-	for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) {
+	for_each_node_by_type(dp, "display") {
 		if (of_get_property(dp, "linux,opened", NULL) &&
 		    of_get_property(dp, "linux,boot-display", NULL)) {
 			boot_disp = dp;
 			offb_init_nodriver(dp, 0);
 		}
 	}
-	for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) {
+	for_each_node_by_type(dp, "display") {
 		if (of_get_property(dp, "linux,opened", NULL) &&
 		    dp != boot_disp)
 			offb_init_nodriver(dp, 0);
Signature · 5 lines
2.11.0.483.g087da7b7c-goog


-- 
Dmitry
#1 lore raw

Hi,

Quoted 3 lines · Dmitry Torokhov

Instead of open-coding loops let's switch to a nice macro.

Signed-off-by Dmitry Torokhov <[email protected]>

Patch queued for 4.11, thanks.

Quoted 15 lines
---
 drivers/video/fbdev/offb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/offb.c +1 -1
index 906c6e75c260..9be884b0c778 100644
@@ -668,14 +668,14 @@ static int __init offb_init(void)
 		offb_init_nodriver(of_chosen, 1);
 	}
 
-	for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) {
+	for_each_node_by_type(dp, "display") {
 		if (of_get_property(dp, "linux,opened", NULL) &&

drivers/video/fbdev/offb.c static int __init offb_init(void) · line 681

Quoted 10 lines
drivers/video/fbdev/offb.c +1 -1
 		    of_get_property(dp, "linux,boot-display", NULL)) {
 			boot_disp = dp;
 			offb_init_nodriver(dp, 0);
 		}
 	}
-	for (dp = NULL; (dp = of_find_node_by_type(dp, "display"));) {
+	for_each_node_by_type(dp, "display") {
 		if (of_get_property(dp, "linux,opened", NULL) &&
 		    dp != boot_disp)
 			offb_init_nodriver(dp, 0);

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics