Skip to contentSkip to conversation

ethernet: aquantia: fix dma_mapping_error test

PATCH Applied Dan Carpenter 2 participants 2 messages Feb 1, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethernet: aquantia: fix dma_mapping_error test

dma_mapping_error() returns 1 if there is an error and 0 if not.

Fixes 018423e90bee ("net: ethernet: aquantia: Add ring support code")
drivers/net/ethernet/aquantia/atlantic/aq_ring.c +3 -2
index 817c145520c8..dea9e9bbb8e7 100644
@@ -298,9 +298,10 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 					buff->page, 0,
 					AQ_CFG_RX_FRAME_MAX, DMA_FROM_DEVICE);
 
-		err = dma_mapping_error(aq_nic_get_dev(self->aq_nic), buff->pa);
-		if (err < 0)
+		if (dma_mapping_error(aq_nic_get_dev(self->aq_nic), buff->pa)) {
+			err = -ENOMEM;
 			goto err_exit;
+		}
 
 		buff = NULL;
 	}