Skip to contentSkip to conversation

libcurl: optional verbose strings config

PATCH New Matt Weber 2 participants 3 messages Jan 31, 2017 – Feb 1, 2017 1 message not in the archive

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 libcurl: optional verbose strings config

From: Judd Meinders <[email protected]>

This patch enables a config to set --enable-verbose during the configuration of libcurl. The option is triggered by setting BR2_PACKAGE_LIBCURL_VERBOSE.

---
 package/libcurl/Config.in  | 5 +++++
 package/libcurl/libcurl.mk | 9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
package/libcurl/Config.in +5 -0
index 026ae01..fc1527f 100644
@@ -13,4 +13,9 @@ config BR2_PACKAGE_CURL
 	help
 	  Install curl binary as well
 
+config BR2_PACKAGE_LIBCURL_VERBOSE
+	bool "enable verbose strings"
+	help
+	  Enable verbose text strings
+
 endif
package/libcurl/libcurl.mk +8 -1
index ea37309..e901a85 100644
@@ -19,8 +19,15 @@ LIBCURL_INSTALL_STAGING = YES
 # on non-MMU platforms. Moreover, this authentication method is
 # probably almost never used. See
 # http://curl.haxx.se/docs/manpage.html#--ntlm.
-LIBCURL_CONF_OPTS = --disable-verbose --disable-manual --disable-ntlm-wb \
+LIBCURL_CONF_OPTS = --disable-manual --disable-ntlm-wb \
 	--enable-hidden-symbols --with-random=/dev/urandom --disable-curldebug
+
+# Make verbose strings optional via config
+ifeq ($(BR2_PACKAGE_LIBCURL_VERBOSE),y)
+LIBCURL_CONF_OPTS += --enable-verbose
+else
+LIBCURL_CONF_OPTS += --disable-verbose
+endif
 LIBCURL_CONFIG_SCRIPTS = curl-config
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 libcurl: optional verbose strings config

Hello,

Quoted 6 lines · Matt Weber

From: Judd Meinders <[email protected]>

This patch enables a config to set --enable-verbose during the configuration of libcurl. The option is triggered by setting BR2_PACKAGE_LIBCURL_VERBOSE.

Quoted 6 lines
---
 package/libcurl/Config.in  | 5 +++++
 package/libcurl/libcurl.mk | 9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

There's only a 22 KB difference between verbose and non-verbose, so I wasn't entirely sure a new sub-option was needed. But well, it's still 22 KB, so I've applied your patch. We'll see if others complain about the additional sub-option for such a small size difference.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

A message that is not in the archive (sent off-list or not yet received): CAGReGbRcsp25tZ=YV8+sFp2ZH17XZYhK7AVu2St7C1iKT3nfkA@mail.gmail.com

#3 lore raw

PATCH 1/1 libcurl: optional verbose strings config

Hello,

Quoted 4 lines · Judd Meinders

The original (and still) default selection of libcurl uses --disable-verbose so the new sub option is meant to merely provide the availability to include the verbose output as a library feature. I wasn't thinking target size I guess.

My point was that if the size increase caused by --enable-verbose was really small, then having a Buildroot sub-option just for this would really be pointless.

More config options in Buildroot means more complexity, more combinations of configurations, and therefore more chances for things to break. Hence we always think twice about adding new configuration options.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com