mt76: add new wireless driver for MediaTek MT76x2 PCIe chips
Subsystems (4)
Felix Fietkau
maintainerv4 cover mt76: add new wireless driver for MediaTek MT76x2 PCIe chips
Changes since v3:
- DFS fixes
- stability fixes
- use wiphy_read_of_freq_limits
Changes since v2:
- lots of checkpatch cleanups
- various tx path (and other) fixes
- use the new bitfield API
- documented device tree bindings
Felix Fietkau (3):
Documentation: dt: net: add mt76 wireless device binding
mt76: add common code shared between multiple chipsets
mt76: add driver code for MT76x2e
.../bindings/net/wireless/mediatek,mt76.txt | 25 + drivers/net/wireless/mediatek/Kconfig | 1 + drivers/net/wireless/mediatek/Makefile | 1 + drivers/net/wireless/mediatek/mt76/Kconfig | 10 + drivers/net/wireless/mediatek/mt76/Makefile | 15 + drivers/net/wireless/mediatek/mt76/debugfs.c | 76 ++ drivers/net/wireless/mediatek/mt76/dma.c | 451 ++++++++++++ drivers/net/wireless/mediatek/mt76/dma.h | 38 + drivers/net/wireless/mediatek/mt76/eeprom.c | 111 +++ drivers/net/wireless/mediatek/mt76/mac80211.c | 346 +++++++++ drivers/net/wireless/mediatek/mt76/mmio.c | 61 ++ drivers/net/wireless/mediatek/mt76/mt76.h | 355 ++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2.h | 223 ++++++ drivers/net/wireless/mediatek/mt76/mt76x2_core.c | 88 +++ .../net/wireless/mediatek/mt76/mt76x2_debugfs.c | 133 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c | 493 +++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h | 80 +++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.c | 184 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.h | 68 ++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 643 +++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h | 181 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 784 +++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 738 +++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.h | 189 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 534 ++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c | 452 ++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h | 136 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_pci.c | 109 +++ drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 691 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 566 +++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_trace.c | 23 + drivers/net/wireless/mediatek/mt76/mt76x2_trace.h | 144 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_tx.c | 262 +++++++ drivers/net/wireless/mediatek/mt76/trace.c | 23 + drivers/net/wireless/mediatek/mt76/trace.h | 71 ++ drivers/net/wireless/mediatek/mt76/tx.c | 511 ++++++++++++++ drivers/net/wireless/mediatek/mt76/util.c | 78 ++ drivers/net/wireless/mediatek/mt76/util.h | 44 ++ 38 files changed, 8938 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt create mode 100644 drivers/net/wireless/mediatek/mt76/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mac80211.c create mode 100644 drivers/net/wireless/mediatek/mt76/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_core.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_regs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.h
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v4 1/3 Documentation: dt: net: add mt76 wireless device binding
--- .../bindings/net/wireless/mediatek,mt76.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +25 -0
@@ -0,0 +1,25 @@ +* MediaTek mt76xx devices + +This node provides properties for configuring the MediaTek mt76xx wireless +device. The node is expected to be specified as a child node of the PCI +controller to which the wireless chip is connected. + +Optional properties: + +- mac-address: See ethernet.txt in the parent directory +- local-mac-address: See ethernet.txt in the parent directory +- ieee80211-freq-limit: See ieee80211.txt +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data + +&pcie { + status = "okay"; + + pcie0 { + mt76@0,0 { + reg = <0x0000 0 0 0 0>; + device_type = "pci"; + ieee80211-freq-limit = <5000000 6000000>; + mediatek,mtd-eeprom = <&factory 0x8000>; + }; + }; +};
Signature · 1 line
2.11.0
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v4 1/3] Documentation: dt: net: add mt76 wireless device binding
Quoted 20 lines · Felix Fietkau
Signed-off-by Felix Fietkau <[email protected]>--- .../bindings/net/wireless/mediatek,mt76.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txtDocumentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +8
-0@@ -0,0 +1,25 @@ +* MediaTek mt76xx devices + +This node provides properties for configuring the MediaTek mt76xx wireless +device. The node is expected to be specified as a child node of the PCI +controller to which the wireless chip is connected. + +Optional properties: +
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +10
-0+- mac-address: See ethernet.txt in the parent directory +- local-mac-address: See ethernet.txt in the parent directory +- ieee80211-freq-limit: See ieee80211.txt +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data + +&pcie { + status = "okay"; + + pcie0 { + mt76@0,0 {
wifi@0,0
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt line 20
Quoted 2 lines
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +2
-0+ reg = <0x0000 0 0 0 0>; + device_type = "pci";
This only applies to PCI bridge nodes, so drop.
Quoted 12 lines
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt new file +5
-0+ ieee80211-freq-limit = <5000000 6000000>; + mediatek,mtd-eeprom = <&factory 0x8000>; + }; + }; +};Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Felix Fietkau
maintainerPATCH v4 2/3 mt76: add common code shared between multiple chipsets
In reply to Felix FietkauThis will be used by drivers for MT76x2e, MT7603e and MT7628
--- drivers/net/wireless/mediatek/mt76/debugfs.c | 76 ++++ drivers/net/wireless/mediatek/mt76/dma.c | 451 +++++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/dma.h | 38 ++ drivers/net/wireless/mediatek/mt76/eeprom.c | 111 ++++++ drivers/net/wireless/mediatek/mt76/mac80211.c | 346 +++++++++++++++++ drivers/net/wireless/mediatek/mt76/mmio.c | 61 +++ drivers/net/wireless/mediatek/mt76/mt76.h | 355 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/trace.c | 23 ++ drivers/net/wireless/mediatek/mt76/trace.h | 71 ++++ drivers/net/wireless/mediatek/mt76/tx.c | 511 ++++++++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/util.c | 78 ++++ drivers/net/wireless/mediatek/mt76/util.h | 44 +++ 12 files changed, 2165 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mac80211.c create mode 100644 drivers/net/wireless/mediatek/mt76/mmio.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76.h create mode 100644 drivers/net/wireless/mediatek/mt76/trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/tx.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.c create mode 100644 drivers/net/wireless/mediatek/mt76/util.h
drivers/net/wireless/mediatek/mt76/debugfs.c new file +76 -0
@@ -0,0 +1,76 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ +#include "mt76.h" + +static int +mt76_reg_set (void *data,u64 val) +{ +struct mt76_dev *dev = data; + + dev->bus->wr (dev, dev->debugfs_reg, val); +return 0 ; +} + +static int +mt76_reg_get (void *data,u64 *val) +{ +struct mt76_dev *dev = data; + + *val = dev->bus->rr (dev, dev->debugfs_reg); +return 0 ; +} + +DEFINE_SIMPLE_ATTRIBUTE (fops_regval, mt76_reg_get, mt76_reg_set,"0x%08llx\n" ); + +static int +mt76_queues_read (struct seq_file *s,void *data) +{ +struct mt76_dev *dev =dev_get_drvdata (s->private); +int i; + +for (i =0 ; i <ARRAY_SIZE (dev->q_tx); i++) { +struct mt76_queue *q = &dev->q_tx[i]; + +if (!q->ndesc) +continue ; + +seq_printf (s, +"%d: queued=%d head=%d tail=%d swq_queued=%d\n" , + i, q->queued, q->head, q->tail, q->swq_queued); + } + +return 0 ; +} + +struct dentry *mt76_register_debugfs (struct mt76_dev *dev) +{ +struct dentry *dir; + + dir =debugfs_create_dir ("mt76" , dev->hw->wiphy->debugfsdir); +if (!dir) +return NULL ; + +debugfs_create_u32 ("regidx" ,S_IRUSR |S_IWUSR , dir, &dev->debugfs_reg); +debugfs_create_file ("regval" ,S_IRUSR |S_IWUSR , dir, dev, + &fops_regval); +debugfs_create_blob ("eeprom" ,S_IRUSR , dir, &dev->eeprom); +if (dev->otp.data) +debugfs_create_blob ("otp" ,S_IRUSR , dir, &dev->otp); +debugfs_create_devm_seqfile (dev->dev,"queues" , dir, mt76_queues_read); + +return dir; +} +EXPORT_SYMBOL_GPL (mt76_register_debugfs);
drivers/net/wireless/mediatek/mt76/dma.c new file +451 -0
451 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/dma.h new file +38 -0
@@ -0,0 +1,38 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ +#ifndef __MT76_DMA_H +#define __MT76_DMA_H + +#define MT_RING_SIZE 0x10 + +#define MT_DMA_CTL_SD_LEN1 GENMASK(13, 0) +#define MT_DMA_CTL_LAST_SEC1 BIT(14) +#define MT_DMA_CTL_BURST BIT(15) +#define MT_DMA_CTL_SD_LEN0 GENMASK(29, 16) +#define MT_DMA_CTL_LAST_SEC0 BIT(30) +#define MT_DMA_CTL_DMA_DONE BIT(31) + +struct mt76_desc { +__le32 buf0; +__le32 ctrl; +__le32 buf1; +__le32 info; +} __packed__aligned(4) ; + +int mt76_dma_attach (struct mt76_dev *dev); +void mt76_dma_cleanup (struct mt76_dev *dev); + +#endif
drivers/net/wireless/mediatek/mt76/eeprom.c new file +111 -0
111 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mac80211.c new file +346 -0
346 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mmio.c new file +61 -0
61 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76.h new file +355 -0
355 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/trace.c new file +23 -0
@@ -0,0 +1,23 @@ +/* +* Copyright (C) 2016 Felix Fietkau <[email protected]> +* +* Permission to use, copy, modify, and/or distribute this software for any +* purpose with or without fee is hereby granted, provided that the above +* copyright notice and this permission notice appear in all copies. +* +* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. +*/ + +#include <linux/module.h> + +#ifndef __CHECKER__ +#define CREATE_TRACE_POINTS +#include "trace.h" + +#endif
drivers/net/wireless/mediatek/mt76/trace.h new file +71 -0
71 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/tx.c new file +511 -0
511 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/util.c new file +78 -0
78 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/util.h new file +44 -0
44 lines not on this page · raw message
Signature · 1 line
2.11.0
Felix Fietkau
maintainerPATCH v4 3/3 mt76: add driver code for MT76x2e
In reply to Felix FietkauThis is a 2x2 PCIe 802.11ac chipset by MediaTek
--- drivers/net/wireless/mediatek/Kconfig | 1 + drivers/net/wireless/mediatek/Makefile | 1 + drivers/net/wireless/mediatek/mt76/Kconfig | 10 + drivers/net/wireless/mediatek/mt76/Makefile | 15 + drivers/net/wireless/mediatek/mt76/mt76x2.h | 223 ++++++ drivers/net/wireless/mediatek/mt76/mt76x2_core.c | 88 +++ .../net/wireless/mediatek/mt76/mt76x2_debugfs.c | 133 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c | 493 +++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h | 80 +++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.c | 184 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_dma.h | 68 ++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 643 +++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h | 181 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 784 +++++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 738 +++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mac.h | 189 +++++ drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 534 ++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c | 452 ++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h | 136 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_pci.c | 109 +++ drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 691 ++++++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 566 +++++++++++++++ drivers/net/wireless/mediatek/mt76/mt76x2_trace.c | 23 + drivers/net/wireless/mediatek/mt76/mt76x2_trace.h | 144 ++++ drivers/net/wireless/mediatek/mt76/mt76x2_tx.c | 262 +++++++ 25 files changed, 6748 insertions(+) create mode 100644 drivers/net/wireless/mediatek/mt76/Kconfig create mode 100644 drivers/net/wireless/mediatek/mt76/Makefile create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_core.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_dma.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_init.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mac.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_main.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_pci.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_regs.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.c create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_trace.h create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x2_tx.c
drivers/net/wireless/mediatek/Kconfig +1 -0
@@ -11,4 +11,5 @@ config WLAN_VENDOR_MEDIATEK if WLAN_VENDOR_MEDIATEK source "drivers/net/wireless/mediatek/mt7601u/Kconfig" +source "drivers/net/wireless/mediatek/mt76/Kconfig" endif # WLAN_VENDOR_MEDIATEK
drivers/net/wireless/mediatek/Makefile +1 -0
@@ -1 +1,2 @@ obj-$(CONFIG_MT7601U) += mt7601u/ +obj-$(CONFIG_MT76_CORE) += mt76/
drivers/net/wireless/mediatek/mt76/Kconfig new file +10 -0
@@ -0,0 +1,10 @@ +config MT76_CORE + tristate + +config MT76x2E + tristate "MediaTek MT76x2E (PCIe) support" + select MT76_CORE + depends on MAC80211 + depends on PCI + ---help--- + This adds support for MT7612/MT7602/MT7662-based wireless PCIe devices.
drivers/net/wireless/mediatek/mt76/Makefile new file +15 -0
@@ -0,0 +1,15 @@ +obj-$(CONFIG_MT76_CORE) += mt76.o +obj-$(CONFIG_MT76x2E) += mt76x2e.o + +mt76-y := \ + mmio.o util.o trace.o dma.o mac80211.o debugfs.o eeprom.o tx.o + +CFLAGS_trace.o := -I$(src) + +mt76x2e-y := \ + mt76x2_pci.o mt76x2_dma.o \ + mt76x2_main.o mt76x2_init.o mt76x2_debugfs.o mt76x2_tx.o \ + mt76x2_core.o mt76x2_mac.o mt76x2_eeprom.o mt76x2_mcu.o mt76x2_phy.o \ + mt76x2_dfs.o mt76x2_trace.o + +CFLAGS_mt76x2_trace.o := -I$(src)
drivers/net/wireless/mediatek/mt76/mt76x2.h new file +223 -0
223 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_core.c new file +88 -0
88 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c new file +133 -0
133 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c new file +493 -0
493 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dfs.h new file +80 -0
80 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dma.c new file +184 -0
184 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h new file +68 -0
68 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c new file +643 -0
643 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h new file +181 -0
181 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +784 -0
784 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c new file +738 -0
91 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mac.h new file +189 -0
189 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_main.c new file +534 -0
534 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c new file +452 -0
452 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_mcu.h new file +136 -0
136 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_pci.c new file +109 -0
109 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +691 -0
691 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_regs.h new file +566 -0
566 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_trace.c new file +23 -0
Lines of this file are not shown. View the raw message.
drivers/net/wireless/mediatek/mt76/mt76x2_trace.h new file +144 -0
144 lines not on this page · raw message
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +262 -0
262 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.11.0
Part of the diff is not shown here. View the raw message.
Felix Fietkau
maintainerRe: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 3 lines · Felix Fietkau
This is a 2x2 PCIe 802.11ac chipset by MediaTek
Signed-off-by Felix Fietkau <[email protected]>
Kalle, Please also add:
Or should I resend?
- Felix
Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 8 lines · Felix Fietkau
Quoted 3 lines · Felix Fietkau
This is a 2x2 PCIe 802.11ac chipset by MediaTek
Signed-off-by Felix Fietkau <[email protected]>Kalle, Please also add:
Signed-off-by Lorenzo Bianconi <[email protected]>Or should I resend?
No need, I can add that during commit. But I would like that Lorenzo himself replies to this email with the Signed-off-by line.
Signature · 1 line
Kalle Valo
Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 9 lines
Quoted 7 lines · Felix Fietkau
Quoted 3 lines · Felix Fietkau
This is a 2x2 PCIe 802.11ac chipset by MediaTek
Signed-off-by Felix Fietkau <[email protected]>Kalle, Please also add:
Signed-off-by Lorenzo Bianconi <[email protected]>
Quoted 7 lines
Quoted 1 line
Or should I resend?
No need, I can add that during commit. But I would like that Lorenzo himself replies to this email with the Signed-off-by line.
--
Kalle Valo
Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e
In reply to Felix FietkauQuoted 3 lines · Felix Fietkau
This is a 2x2 PCIe 802.11ac chipset by MediaTek
Signed-off-by Felix Fietkau <[email protected]>
Driver looks great to me, though I think it could be better commented. I have some minor issues, but if they need to be fixed, it could be done by incremental patches after apply this one to the tree.
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h line 66
Quoted 9 lines
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h new file +9
-0+enum dma_msg_port { +WLAN_PORT , +CPU_RX_PORT , +CPU_TX_PORT , +HOST_PORT , +VIRTUAL_CPU_RX_PORT , +VIRTUAL_CPU_TX_PORT , +DISCARD , +};
Not used ?
drivers/net/wireless/mediatek/mt76/mt76x2_init.c line 492
Quoted 13 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +13
-0+void mt76x2_set_tx_ackto (struct mt76x2_dev *dev) +{ +u8 ackto, sifs, slottime = dev->slottime; + + slottime +=3 * dev->coverage_class; + + sifs =mt76_get_field (dev,MT_XIFS_TIME_CFG , +MT_XIFS_TIME_CFG_OFDM_SIFS ); + + ackto = slottime + sifs; +mt76_rmw_field (dev,MT_TX_TIMEOUT_CFG , +MT_TX_TIMEOUT_CFG_ACKTO , ackto); +}
Interesting, if this correct way to configure the TX_TIMEOUT_CFG_ACKTO we will also need this in rt2x00. Vendor drivers use 32 for this setting and do not change it.
Note we have also EXP_ACT_TIME and EXP_CTS_TIME registers, which stay with default settings, but perhaps should be changed depending on channel properties as well.
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 64
Quoted 11 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +11
-0+static u32 +mt76x2_tx_power_mask (u8 v1,u8 v2,u8 v3,u8 v4) +{ +u32 val =0 ; + + val |= (v1 & (BIT (6 ) -1 )) <<0 ; + val |= (v2 & (BIT (6 ) -1 )) <<8 ; + val |= (v3 & (BIT (6 ) -1 )) <<16 ; + val |= (v4 & (BIT (6 ) -1 )) <<24 ; +return val; +}
TX_PWR_CFG registers consist of eight 4bit entries, masking two entries with 0x3f does not seems to be correct.
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 170
Quoted 10 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +10
-0+mt76_wr (dev,MT_TX_PWR_CFG_3 , +mt76x2_tx_power_mask (t.ht[12 ], t.ht[14 ], t.ht[0 ], t.ht[2 ])); +mt76_wr (dev,MT_TX_PWR_CFG_4 , +mt76x2_tx_power_mask (t.ht[4 ], t.ht[6 ],0 ,0 )); +mt76_wr (dev,MT_TX_PWR_CFG_7 , +mt76x2_tx_power_mask (t.ofdm[6 ], t.vht[8 ], t.ht[6 ], t.vht[8 ])); +mt76_wr (dev,MT_TX_PWR_CFG_8 , +mt76x2_tx_power_mask (t.ht[14 ], t.vht[8 ], t.vht[8 ],0 )); +mt76_wr (dev,MT_TX_PWR_CFG_9 , +mt76x2_tx_power_mask (t.ht[6 ], t.vht[8 ], t.vht[8 ],0 ));
Looks like some of arguments instead of t.vht[x] accidentally become t.ht[x], for example t.vht[6] is never used.
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +8
-0+static void +mt76x2_configure_tx_delay (struct mt76x2_dev *dev,enum nl80211_band band,u8 bw) +{ +u32 cfg0, cfg1; + +if (mt76x2_ext_pa_enabled (dev, band)) { + cfg0 = bw ?0x000b0c01 :0x00101101 ; + cfg1 =0x00011414 ;
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 320
Quoted 10 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +10
-0+ }else { + cfg0 = bw ?0x000b0b01 :0x00101001 ; + cfg1 =0x00021414 ; + } +mt76_wr (dev,MT_TX_SW_CFG0 , cfg0); +mt76_wr (dev,MT_TX_SW_CFG1 , cfg1); + +mt76_rmw_field (dev,MT_XIFS_TIME_CFG ,MT_XIFS_TIME_CFG_CCK_SIFS , +13 + (bw ?1 :0 )); +}
SIFS for 2GHz should be 10us and for 5GHz 16us. Setting SIFS to 13 or 14 looks wrong for 2GHz band. Can be correct for 5GHz assuming we have some internal delays configured on TX_SW_CFG registers.
But again this is interesting for rt2x00, where we stay with defaults, but looks we should configure XIFS_TIME_CFG based on channel.
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 552
Quoted 4 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +4
-0+if (chandef->width >=NL80211_CHAN_WIDTH_40 ) + sifs++; + +mt76_rmw_field (dev,MT_XIFS_TIME_CFG ,MT_XIFS_TIME_CFG_OFDM_SIFS , sifs);
This probably should be set together with MT_XIFS_TIME_CFG_CCK_SIFS in mt76x2_configure_tx_delay().
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 140
Quoted 12 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +12
-0+static int mt76x2_insert_hdr_pad (struct sk_buff *skb) +{ +int len =ieee80211_get_hdrlen_from_skb (skb); +int ret; + +if (len %4 ==0 ) +return 0 ; + +if (skb_headroom (skb) <2 ) { + ret =pskb_expand_head (skb,2 ,0 ,GFP_ATOMIC ); +if (ret !=0 ) +return ret;
This should not be needed if hw->extra_tx_headroom is set properly.
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 168
Quoted 2 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +2
-0+if (info->flags &IEEE80211_TX_CTL_RATE_CTRL_PROBE ) + qsel =0 ;
For better understating: qsel = MT_QSEL_MGMT;
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 231
Quoted 12 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +12
-0+void mt76x2_pre_tbtt_tasklet (unsigned long arg) +{ +struct mt76x2_dev *dev = (struct mt76x2_dev *) arg; +struct mt76_queue *q = &dev->mt76.q_tx[MT_TXQ_PSD ]; +struct beacon_bc_data data = {}; +struct sk_buff *skb; +int i, nframes; + + data.dev = dev; +__skb_queue_head_init (&data.q); + + ieee80211_iterate_active_interfaces_atomic(mt76_hw(dev),
This symbol, not like most of other mac80211 symbols, is exported via EXPORT_SYMBOL_GPL(), so I'm not sure if it can be used on dual licensed file, perhaps licence of this file should be changed to GPL only.
Stanislaw
Felix Fietkau
maintainerRe: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 9 lines · Stanislaw Gruszka
Quoted 3 lines · Felix Fietkau
This is a 2x2 PCIe 802.11ac chipset by MediaTek
Signed-off-by Felix Fietkau <[email protected]>Driver looks great to me, though I think it could be better commented. I have some minor issues, but if they need to be fixed, it could be done by incremental patches after apply this one to the tree.
Reviewed-by Stanislaw Gruszka <[email protected]>
Thanks for the review.
Quoted 10 lines
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h line 66
Quoted 9 lines
drivers/net/wireless/mediatek/mt76/mt76x2_dma.h new file +9
-0+enum dma_msg_port { +WLAN_PORT , +CPU_RX_PORT , +CPU_TX_PORT , +HOST_PORT , +VIRTUAL_CPU_RX_PORT , +VIRTUAL_CPU_TX_PORT , +DISCARD , +};Not used ?
Yeah, I guess it can be removed.
Quoted 8 lines
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +8
-0+void mt76x2_set_tx_ackto (struct mt76x2_dev *dev) +{ +u8 ackto, sifs, slottime = dev->slottime; + + slottime +=3 * dev->coverage_class; + + sifs =mt76_get_field (dev,MT_XIFS_TIME_CFG , +MT_XIFS_TIME_CFG_OFDM_SIFS );
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c line 492
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +5
-0+ + ackto = slottime + sifs; +mt76_rmw_field (dev,MT_TX_TIMEOUT_CFG , +MT_TX_TIMEOUT_CFG_ACKTO , ackto); +}Interesting, if this correct way to configure the
TX_TIMEOUT_CFG_ACKTOwe will also need this in rt2x00. Vendor drivers use 32 for this setting and do not change it.
I don't think vendor drivers even have support for coverage class.
Quoted 4 lines
Note we have also
EXP_ACT_TIMEandEXP_CTS_TIMEregisters, which stay with default settings, but perhaps should be changed depending on channel properties as well.
Quoted 13 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 64
Quoted 11 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +11
-0+static u32 +mt76x2_tx_power_mask (u8 v1,u8 v2,u8 v3,u8 v4) +{ +u32 val =0 ; + + val |= (v1 & (BIT (6 ) -1 )) <<0 ; + val |= (v2 & (BIT (6 ) -1 )) <<8 ; + val |= (v3 & (BIT (6 ) -1 )) <<16 ; + val |= (v4 & (BIT (6 ) -1 )) <<24 ; +return val; +}
TX_PWR_CFGregisters consist of eight 4bit entries, masking two entries with0x3fdoes not seems to be correct.
No, these registers consist of four 6bit entries. Both the vendor driver and the datasheet describe them this way.
Quoted 4 lines
Quoted 4 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +4
-0+mt76_wr (dev,MT_TX_PWR_CFG_3 , +mt76x2_tx_power_mask (t.ht[12 ], t.ht[14 ], t.ht[0 ], t.ht[2 ])); +mt76_wr (dev,MT_TX_PWR_CFG_4 , +mt76x2_tx_power_mask (t.ht[4 ], t.ht[6 ],0 ,0 ));
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 170
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +6
-0+mt76_wr (dev,MT_TX_PWR_CFG_7 , +mt76x2_tx_power_mask (t.ofdm[6 ], t.vht[8 ], t.ht[6 ], t.vht[8 ])); +mt76_wr (dev,MT_TX_PWR_CFG_8 , +mt76x2_tx_power_mask (t.ht[14 ], t.vht[8 ], t.vht[8 ],0 )); +mt76_wr (dev,MT_TX_PWR_CFG_9 , +mt76x2_tx_power_mask (t.ht[6 ], t.vht[8 ], t.vht[8 ],0 ));Looks like some of arguments instead of t.vht[x] accidentally become t.ht[x], for example t.vht[6] is never used.
There are not enough register fields for all rates individually, so they overlap. This looks a bit confusing and random, but I did check it carefully against the vendor driver and the datasheet.
Quoted 13 lines
Quoted 13 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +13
-0+static void +mt76x2_configure_tx_delay (struct mt76x2_dev *dev,enum nl80211_band band,u8 bw) +{ +u32 cfg0, cfg1; + +if (mt76x2_ext_pa_enabled (dev, band)) { + cfg0 = bw ?0x000b0c01 :0x00101101 ; + cfg1 =0x00011414 ; + }else { + cfg0 = bw ?0x000b0b01 :0x00101001 ; + cfg1 =0x00021414 ; + } +mt76_wr (dev,MT_TX_SW_CFG0 , cfg0);
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 320
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +5
-0+mt76_wr (dev,MT_TX_SW_CFG1 , cfg1); + +mt76_rmw_field (dev,MT_XIFS_TIME_CFG ,MT_XIFS_TIME_CFG_CCK_SIFS , +13 + (bw ?1 :0 )); +}SIFS for 2GHz should be 10us and for 5GHz 16us. Setting SIFS to 13 or 14 looks wrong for 2GHz band. Can be correct for 5GHz assuming we have some internal delays configured on
TX_SW_CFGregisters.
This is a CCK-only SIFS value (there's a separate one for OFDM).
Quoted 3 lines
But again this is interesting for rt2x00, where we stay with defaults, but looks we should configure
XIFS_TIME_CFGbased on channel.
I think many of these might be mt76x2 specific tweaks, so be careful with applying any of that to rt2x00.
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 552
Quoted 4 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +4
-0+if (chandef->width >=NL80211_CHAN_WIDTH_40 ) + sifs++; + +mt76_rmw_field (dev,MT_XIFS_TIME_CFG ,MT_XIFS_TIME_CFG_OFDM_SIFS , sifs);This probably should be set together with
MT_XIFS_TIME_CFG_CCK_SIFSinmt76x2_configure_tx_delay().
Will look into that.
Quoted 5 lines
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +5
-0+static int mt76x2_insert_hdr_pad (struct sk_buff *skb) +{ +int len =ieee80211_get_hdrlen_from_skb (skb); +int ret; +
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 140
Quoted 7 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +7
-0+if (len %4 ==0 ) +return 0 ; + +if (skb_headroom (skb) <2 ) { + ret =pskb_expand_head (skb,2 ,0 ,GFP_ATOMIC ); +if (ret !=0 ) +return ret;This should not be needed if
hw->extra_tx_headroomis set properly.
Thanks, will send a follow-up cleanup patch if this one is accepted.
Quoted 3 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 168
Quoted 2 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +2
-0+if (info->flags &IEEE80211_TX_CTL_RATE_CTRL_PROBE ) + qsel =0 ;For better understating: qsel =
MT_QSEL_MGMT;
Right.
Quoted 7 lines
Quoted 7 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +7
-0+void mt76x2_pre_tbtt_tasklet (unsigned long arg) +{ +struct mt76x2_dev *dev = (struct mt76x2_dev *) arg; +struct mt76_queue *q = &dev->mt76.q_tx[MT_TXQ_PSD ]; +struct beacon_bc_data data = {}; +struct sk_buff *skb; +int i, nframes;
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c line 231
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_tx.c new file +5
-0+ + data.dev = dev; +__skb_queue_head_init (&data.q); + + ieee80211_iterate_active_interfaces_atomic(mt76_hw(dev),This symbol, not like most of other mac80211 symbols, is exported via
EXPORT_SYMBOL_GPL(), so I'm not sure if it can be used on dual licensed file, perhaps licence of this file should be changed to GPL only.
Technically only the resulting binary will become GPL. I still want to keep the source code of the entire driver ISC licensed to make it easier for the BSDs to copy code from it.
- Felix
Re: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 16 lines · Felix Fietkau
Quoted 8 lines
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +8
-0+void mt76x2_set_tx_ackto (struct mt76x2_dev *dev) +{ +u8 ackto, sifs, slottime = dev->slottime; + + slottime +=3 * dev->coverage_class; + + sifs =mt76_get_field (dev,MT_XIFS_TIME_CFG , +MT_XIFS_TIME_CFG_OFDM_SIFS );Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c line 492
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_init.c new file +5
-0+ + ackto = slottime + sifs; +mt76_rmw_field (dev,MT_TX_TIMEOUT_CFG , +MT_TX_TIMEOUT_CFG_ACKTO , ackto); +}Interesting, if this correct way to configure the
TX_TIMEOUT_CFG_ACKTOwe will also need this in rt2x00. Vendor drivers use 32 for this setting and do not change it.
Quoted 1 line
I don't think vendor drivers even have support for coverage class.
Even not supporting coverage class (default is 0 anyway) this results on different setting depending on slot time and sifs. My understanding is that this is correct approach, compared to constant value used by vendor.
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +5
-0+static u32 +mt76x2_tx_power_mask (u8 v1,u8 v2,u8 v3,u8 v4) +{ +u32 val =0 ; +Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 64
Quoted 6 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +6
-0+ val |= (v1 & (BIT (6 ) -1 )) <<0 ; + val |= (v2 & (BIT (6 ) -1 )) <<8 ; + val |= (v3 & (BIT (6 ) -1 )) <<16 ; + val |= (v4 & (BIT (6 ) -1 )) <<24 ; +return val; +}
TX_PWR_CFGregisters consist of eight 4bit entries, masking two entries with0x3fdoes not seems to be correct.
Quoted 2 lines
No, these registers consist of four 6bit entries. Both the vendor driver and the datasheet describe them this way.
That different compared to old devices. I assumed those registers would not change meaning in MT76, but I guess I was wrong.
Quoted 20 lines
Quoted 12 lines
Quoted 12 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +12
-0+mt76x2_configure_tx_delay(struct mt76x2_dev *dev, enum nl80211_band band, u8 bw) +{ + u32 cfg0, cfg1; + +if (mt76x2_ext_pa_enabled (dev, band)) { + cfg0 = bw ?0x000b0c01 :0x00101101 ; + cfg1 =0x00011414 ; + }else { + cfg0 = bw ?0x000b0b01 :0x00101001 ; + cfg1 =0x00021414 ; + } +mt76_wr (dev,MT_TX_SW_CFG0 , cfg0);Quoted 8 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c line 320
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/mt76x2_phy.c new file +5
-0+mt76_wr (dev,MT_TX_SW_CFG1 , cfg1); + +mt76_rmw_field (dev,MT_XIFS_TIME_CFG ,MT_XIFS_TIME_CFG_CCK_SIFS , +13 + (bw ?1 :0 )); +}SIFS for 2GHz should be 10us and for 5GHz 16us. Setting SIFS to 13 or 14 looks wrong for 2GHz band. Can be correct for 5GHz assuming we have some internal delays configured on
TX_SW_CFGregisters.
Quoted 1 line
This is a CCK-only SIFS value (there's a separate one for OFDM).
CCK can be used only on 5GHz? OFDM only on 2GHz? I thought any rates can be used on both bands. Or maybe this settings is just named wrongly i.e. CCK_SIFS mean sifs for 5GHz and OFDM_SIFS - sifs for 2GHz ?
Stanislaw
Felix Fietkau
maintainerRe: [PATCH v4 3/3] mt76: add driver code for MT76x2e
Quoted 3 lines · Stanislaw Gruszka
CCK can be used only on 5GHz? OFDM only on 2GHz? I thought any rates can be used on both bands. Or maybe this settings is just named wrongly i.e.
CCK_SIFSmean sifs for 5GHz andOFDM_SIFS- sifs for 2GHz ?
OFDM is used on 2.4 and 5 GHz, CCK only on 2.4 GHz. According to the datasheet, CCK_SIFS means SIFS after CCK transmission.
- Felix