Skip to contentSkip to conversation

selftest: do not perform a full build in test_continue

PATCH In review Alexander Kanavin 2 participants 3 messages Feb 2, 2017

lore
Share & tools
lore

Alexander Kanavin

author
#0 lore raw

PATCH 1/1 selftest: do not perform a full build in test_continue

This was fetching and building the toolchain and everything else against empty download dir and sstate cache, and so was enormously slow. The test does not need that, it only checks that one fetch task fails and another succeeds when using bitbake's -k option.

Signed-off-by Alexander Kanavin <[email protected]>
---
 meta/lib/oeqa/selftest/bbtests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oeqa/selftest/bbtests.py +1 -1
index c4e50cbfa0f..a3b03eaac34 100644
@@ -221,7 +221,7 @@ INHERIT_remove = \"report-error\"
         self.track_for_cleanup(os.path.join(self.builddir, "download-selftest"))
         self.write_recipeinc('man',"\ndo_fail_task () {\nexit 1 \n}\n\naddtask do_fail_task before do_fetch\n" )
         runCmd('bitbake -c cleanall man xcursor-transparent-theme')
-        result = runCmd('bitbake man xcursor-transparent-theme -k', ignore_status=True)
+        result = runCmd('bitbake -c unpack -k man xcursor-transparent-theme', ignore_status=True)
         errorpos = result.output.find('ERROR: Function failed: do_fail_task')
         manver = re.search("NOTE: recipe xcursor-transparent-theme-(.*?): task do_unpack: Started", result.output)
         continuepos = result.output.find('NOTE: recipe xcursor-transparent-theme-%s: task do_unpack: Started' % manver.group(1))
Signature · 1 line
2.11.0
#1 lore raw
Quoted 6 lines · Alexander Kanavin

runCmd('bitbake -c cleanall man xcursor-transparent-theme')
- result = runCmd('bitbake man xcursor-transparent-theme -k',
ignore_status=True)
+ result = runCmd('bitbake -c unpack -k man
xcursor-transparent-theme', ignore_status=True)

I also have to ask why it does cleanall. Why isn't clean sufficient?

Ross

author
#2 lore raw
Quoted 8 lines · Ross

runCmd('bitbake -c cleanall man xcursor-transparent-theme')
- result = runCmd('bitbake man xcursor-transparent-theme -k',
ignore_status=True)
+ result = runCmd('bitbake -c unpack -k man
xcursor-transparent-theme', ignore_status=True)

I also have to ask why it does cleanall. Why isn't clean sufficient?

I guess because it's testing that fetching for one recipe fails but unpacking for another recipe succeeds, and getting those tasks to run requires cleanall?

Alex