generic/407: check that destination timestamps are updated on clone
PATCH 1/1 generic/407: check that destination timestamps are updated on clone
--- tests/generic/407 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/407.out | 2 ++ tests/generic/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/generic/407 create mode 100644 tests/generic/407.out
tests/generic/407 new file +85 -0
@@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test No. 407 +# +# Verify that mtime is updated when cloning files +# +#----------------------------------------------------------------------- +# +# Copyright (c) 2014 Christoph Hellwig. All Rights Reserved. +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + rm -f $destfile +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. common/reflink + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_cp_reflink +_require_test + +echo "Silence is golden." +rm -f $seqres.full + +# pattern the file. +sourcefile=$TEST_DIR/clone_mtime_sourcefile +$XFS_IO_PROG -f -c "pwrite 0 4k" -c fsync $sourcefile >> $seqres.full + +destfile=$TEST_DIR/clone_mtime_destfile +touch $destfile >> $seqres.full + +# sample timestamps. +mtime1=`stat -c %Y $destfile` +ctime1=`stat -c %Z $destfile` +echo "before clone: $mtime1 $ctime1" >> $seqres.full + +# clone to trigger timestamp change +sleep 2 +$XFS_IO_PROG -c "reflink $sourcefile " $destfile >> $seqres.full + +# sample and verify that timestamps have changed. +mtime2=`stat -c %Y $destfile` +ctime2=`stat -c %Z $destfile` +echo "after clone : $mtime2 $ctime2" >> $seqres.full + +if [ "$mtime1" == "$mtime2" ]; then + echo "mtime not updated" + let status=$status+1 +fi +if [ "$ctime1" == "$ctime2" ]; then + echo "ctime not updated" + let status=$status+1 +fi + +exit
tests/generic/407.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 407 +Silence is golden.
tests/generic/group +1 -0
@@ -409,3 +409,4 @@ 404 auto quick insert 405 auto mkfs 406 auto quick dangerous +407 auto quick clone metadata
Signature · 1 line
2.11.0
Quoted 73 lines · Christoph Hellwig
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/407 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/407.out | 2 ++ tests/generic/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/generic/407 create mode 100644 tests/generic/407.outtests/generic/407 new file +58
-0@@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test No. 407 +# +# Verify that mtime is updated when cloning files +# +#----------------------------------------------------------------------- +# +# Copyright (c) 2014 Christoph Hellwig. All Rights Reserved. +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + rm -f $destfile +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. common/reflink + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_cp_reflink +_require_test + +echo "Silence is golden." +rm -f $seqres.full + +# pattern the file. +sourcefile=$TEST_DIR/clone_mtime_sourcefile +$XFS_IO_PROG -f -c "pwrite 0 4k" -c fsync $sourcefile >> $seqres.full +
tests/generic/407 line 68
Quoted 10 lines
tests/generic/407 new file +10
-0+destfile=$TEST_DIR/clone_mtime_destfile +touch $destfile >> $seqres.full + +# sample timestamps. +mtime1=`stat -c %Y $destfile` +ctime1=`stat -c %Z $destfile` +echo "before clone: $mtime1 $ctime1" >> $seqres.full + +# clone to trigger timestamp change +sleep 2
I am thinking about starting a myth about an angel dying on every sleep 1 ;-)
Although this may be nit picking, why 2 seconds?
I see there are several tests that use sleep 1 for the same sort of test and then there is generic/368, which uses a much more elegant touch -d '1 hour ago'
Please consider.
Quoted 41 lines
tests/generic/407 new file +17
-0+$XFS_IO_PROG -c "reflink $sourcefile " $destfile >> $seqres.full + +# sample and verify that timestamps have changed. +mtime2=`stat -c %Y $destfile` +ctime2=`stat -c %Z $destfile` +echo "after clone : $mtime2 $ctime2" >> $seqres.full + +if [ "$mtime1" == "$mtime2" ]; then + echo "mtime not updated" + let status=$status+1 +fi +if [ "$ctime1" == "$ctime2" ]; then + echo "ctime not updated" + let status=$status+1 +fi + +exittests/generic/407.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 407 +Silence is golden.tests/generic/group +1
-1@@ -409,3 +409,4 @@ 404 auto quick insert 405 auto mkfs 406 auto quick dangerous +407 auto quick clone metadata --2.11.0
--
To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 87 lines · Amir Goldstein
Quoted 73 lines · Christoph Hellwig
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/407 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/407.out | 2 ++ tests/generic/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/generic/407 create mode 100644 tests/generic/407.outtests/generic/407 new file +58
-0@@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test No. 407 +# +# Verify that mtime is updated when cloning files +# +#----------------------------------------------------------------------- +# +# Copyright (c) 2014 Christoph Hellwig. All Rights Reserved. +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + rm -f $destfile +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. common/reflink + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_cp_reflink +_require_test + +echo "Silence is golden." +rm -f $seqres.full + +# pattern the file. +sourcefile=$TEST_DIR/clone_mtime_sourcefile +$XFS_IO_PROG -f -c "pwrite 0 4k" -c fsync $sourcefile >> $seqres.full +tests/generic/407 line 68
Quoted 10 lines
tests/generic/407 new file +10
-0+destfile=$TEST_DIR/clone_mtime_destfile +touch $destfile >> $seqres.full + +# sample timestamps. +mtime1=`stat -c %Y $destfile` +ctime1=`stat -c %Z $destfile` +echo "before clone: $mtime1 $ctime1" >> $seqres.full + +# clone to trigger timestamp change +sleep 2I am thinking about starting a myth about an angel dying on every sleep 1 ;-)
Quoted 5 lines
Although this may be nit picking, why 2 seconds?
I see there are several tests that use sleep 1 for the same sort of test and then there is generic/368, which uses a much more elegant touch -d '1 hour ago'
Sorry, that's no good for ctime.
Question about sleep 2 still stands.
Quoted 43 lines
Please consider.
Quoted 41 lines
tests/generic/407 new file +17
-0+$XFS_IO_PROG -c "reflink $sourcefile " $destfile >> $seqres.full + +# sample and verify that timestamps have changed. +mtime2=`stat -c %Y $destfile` +ctime2=`stat -c %Z $destfile` +echo "after clone : $mtime2 $ctime2" >> $seqres.full + +if [ "$mtime1" == "$mtime2" ]; then + echo "mtime not updated" + let status=$status+1 +fi +if [ "$ctime1" == "$ctime2" ]; then + echo "ctime not updated" + let status=$status+1 +fi + +exittests/generic/407.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 407 +Silence is golden.tests/generic/group +1
-1@@ -409,3 +409,4 @@ 404 auto quick insert 405 auto mkfs 406 auto quick dangerous +407 auto quick clone metadata --2.11.0
--
To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line
Although this may be nit picking, why 2 seconds?
Copied from a test that did it, 1 is enough though.
Quoted 3 lines · Christoph Hellwig
Quoted 1 line
Although this may be nit picking, why 2 seconds?
Copied from a test that did it, 1 is enough though.
Yes, I saw that, generic/215 which was copied from generic/080 I guess someone should clean up those 2 some time.
And while we are busy saving more angels lives, do 407 and 408 really need to be separate tests?
How about consolidating them into a single test that works with 2 sets of files? Sorry again for nit picking on those lost seconds.
Quoted 7 lines · Amir Goldstein
Yes, I saw that, generic/215 which was copied from generic/080 I guess someone should clean up those 2 some time.
And while we are busy saving more angels lives, do 407 and 408 really need to be separate tests?
How about consolidating them into a single test that works with 2 sets of files? Sorry again for nit picking on those lost seconds.
We can't do that as there are file systems that support clone but not dedup (e.g. NFS).
Quoted 74 lines · Christoph Hellwig
Signed-off-by Christoph Hellwig <[email protected]>--- tests/generic/407 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/407.out | 2 ++ tests/generic/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/generic/407 create mode 100644 tests/generic/407.outtests/generic/407 new file +59
-0@@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test No. 407 +# +# Verify that mtime is updated when cloning files +# +#----------------------------------------------------------------------- +# +# Copyright (c) 2014 Christoph Hellwig. All Rights Reserved. +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=0 +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + rm -f $destfile +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. common/reflink + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +_require_cp_reflink +_require_test + +echo "Silence is golden." +rm -f $seqres.full + +# pattern the file. +sourcefile=$TEST_DIR/clone_mtime_sourcefile +$XFS_IO_PROG -f -c "pwrite 0 4k" -c fsync $sourcefile >> $seqres.full + +destfile=$TEST_DIR/clone_mtime_destfile
tests/generic/407 line 69
Quoted 10 lines
tests/generic/407 new file +10
-0+touch $destfile >> $seqres.full + +# sample timestamps. +mtime1=`stat -c %Y $destfile` +ctime1=`stat -c %Z $destfile` +echo "before clone: $mtime1 $ctime1" >> $seqres.full + +# clone to trigger timestamp change +sleep 2 +$XFS_IO_PROG -c "reflink $sourcefile " $destfile >> $seqres.full
This follow from the discussion of "xfs: update ctime and mtime on clone destinatation inodes" -- there ought to be a second test that dedupe doesn't modify mtime.
--D
Quoted 40 lines
tests/generic/407 new file +16
-0+ +# sample and verify that timestamps have changed. +mtime2=`stat -c %Y $destfile` +ctime2=`stat -c %Z $destfile` +echo "after clone : $mtime2 $ctime2" >> $seqres.full + +if [ "$mtime1" == "$mtime2" ]; then + echo "mtime not updated" + let status=$status+1 +fi +if [ "$ctime1" == "$ctime2" ]; then + echo "ctime not updated" + let status=$status+1 +fi + +exittests/generic/407.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 407 +Silence is golden.tests/generic/group +1
-0@@ -409,3 +409,4 @@ 404 auto quick insert 405 auto mkfs 406 auto quick dangerous +407 auto quick clone metadataSignature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html