Skip to contentSkip to conversation

package/unixodbc: add optional dependency to libtool

PATCH New Bernd Kuhls 2 participants 2 messages Feb 4, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/unixodbc: add optional dependency to libtool

To get reproducable builds of unixodbc add libtool as optional dependency.

Without libtool:

$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]

With libtool:

$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libltdl.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]
---
 package/unixodbc/unixodbc.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/unixodbc/unixodbc.mk +7 -0
index f66daab4a..280fe5791 100644
@@ -20,6 +20,13 @@ else
 UNIXODBC_CONF_OPTS += --disable-iconv
 endif
 
+ifeq ($(BR2_PACKAGE_LIBTOOL),y)
+UNIXODBC_CONF_OPTS += --without-included-ltdl
+UNIXODBC_DEPENDENCIES += libtool
+else
+UNIXODBC_CONF_OPTS += --with-included-ltdl
+endif
+
 ifeq ($(BR2_PACKAGE_READLINE),y)
 UNIXODBC_CONF_OPTS += --enable-readline
 UNIXODBC_DEPENDENCIES += readline
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/unixodbc: add optional dependency to libtool

Hello,

Quoted 10 lines · Bernd Kuhls

To get reproducable builds of unixodbc add libtool as optional dependency.

Without libtool:

$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]

With libtool:

Quoted 8 lines
$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libltdl.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]
---
 package/unixodbc/unixodbc.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com