docs/website: Feed API and gmane fix
PATCH 1/1 docs/website: Feed API and gmane fix
* Google retired feed API, this patch changes in favour of yahoo yql for rss to json conversion
* Gmane is gone, replacing it with nabble.
* Removed the import for feed api libraries
* Updates to the latest jquery version
* Reorganized javascript code in buildroot.js to accomodate the mentioned fixings
--- docs/website/footer.html | 5 ++-- docs/website/header.html | 2 +- docs/website/js/buildroot.js | 71 ++++++++++++++++---------------------------- docs/website/support.html | 6 ++-- 4 files changed, 33 insertions(+), 51 deletions(-)
docs/website/footer.html +2 -3
@@ -1,6 +1,5 @@ - <script src="https://code.jquery.com/jquery-1.11.3.min.js"></script> - <script src="https://oss.maxcdn.com/bootstrap/3.3.5/js/bootstrap.min.js"></script> - <script type="text/javascript" src="https://www.google.com/jsapi"></script> + <script src="https://code.jquery.com/jquery-3.1.1.min.js"></script> + <script src="https://oss.maxcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script> <script src="https://cdn.rawgit.com/zenorocha/clipboard.js/master/dist/clipboard.min.js"></script> <script type="text/javascript" src="js/buildroot.js"></script> </body>
docs/website/header.html +1 -1
@@ -10,7 +10,7 @@ <title>Buildroot - Making Embedded Linux Easy</title> - <link href="https://oss.maxcdn.com/bootswatch/3.3.5/paper/bootstrap.min.css" rel="stylesheet"> + <link href="https://oss.maxcdn.com/bootswatch/3.3.7/paper/bootstrap.min.css" rel="stylesheet"> <link href="css/main.css" rel="stylesheet"> <!--[if lt IE 9]>
docs/website/js/buildroot.js +26 -45
103 lines not on this page · raw message
docs/website/support.html +4 -2
@@ -50,9 +50,11 @@ list, since there is a good chance someone else has asked the same question before.</p> - <form method="get" action="http://search.gmane.org/"> + <form method="get" action="http://buildroot-busybox.2317881.n4.nabble.com/template/NamlServlet.jtp"> <input type="text" name="query"> - <input type="hidden" name="group" value="gmane.comp.lib.uclibc.buildroot"> + <input type="hidden" name="macro" value="search_page"> + <input type="hidden" name="node" value="2"> + <input type="hidden" name="sort" value="date"> <button type="submit" class="btn btn-default">Submit</button> </form> </div>
Signature · 1 line
2.7.4
PATCH 1/1 docs/website: Feed API and gmane fix
Hello,
Quoted 7 lines · Angelo Compagnucci
* Google retired feed API, this patch changes in favour of yahoo yql for rss to json conversion
* Gmane is gone, replacing it with nabble.
* Removed the import for feed api libraries
* Updates to the latest jquery version
* Reorganized javascript code in buildroot.js to accomodate the mentioned fixings
This bullet list is a very good indication that this patch should be split into several smaller patches. It's doing lots of things that are fairly independent, or if not independent, that can be split into several steps.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 docs/website: Feed API and gmane fix
Dear Thomas Petazzoni,
2017-02-04 23:51 GMT+01:00 Thomas Petazzoni
<[email protected]>:
Quoted 11 lines
Hello,
Quoted 7 lines · Angelo Compagnucci
* Google retired feed API, this patch changes in favour of yahoo yql for rss to json conversion
* Gmane is gone, replacing it with nabble.
* Removed the import for feed api libraries
* Updates to the latest jquery version
* Reorganized javascript code in buildroot.js to accomodate the mentioned fixings
Quoted 4 lines
This bullet list is a very good indication that this patch should be split into several smaller patches. It's doing lots of things that are fairly independent, or if not independent, that can be split into several steps.
Honestly, I cannot see your point here. I really cannot understand why I should submit a patch that fixes the gogole feed API but leaves the site broken because gmane is out of service. The rest of things are functional to these fixings, so again cannot be splitted. This patch makes the minimal set of changes to fix the currently broken website. If not interested, please discard it.
Sincerely, Angelo.
Quoted 8 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
PATCH 1/1 docs/website: Feed API and gmane fix
Hello,
Quoted 6 lines · Angelo Compagnucci
Honestly, I cannot see your point here. I really cannot understand why I should submit a patch that fixes the gogole feed API but leaves the site broken because gmane is out of service. The rest of things are functional to these fixings, so again cannot be splitted. This patch makes the minimal set of changes to fix the currently broken website. If not interested, please discard it.
You're doing a few completely independent things in here:
- Bumping the jquery/bootstrap versions
- Switching to the Yahoo feed API and fixing to using a non GMane RSS feed
- Fixing the search engine to not use GMane
I don't understand why you suddenly get mad, while all I'm asking is exactly what we ask for all other Buildroot patches: one patch does just one logical change. We ask this to all contributors. Why should your contributions be handled with different rules?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 docs/website: Feed API and gmane fix
Dear Thomas Petazzoni,
2017-02-05 14:55 GMT+01:00 Thomas Petazzoni
<[email protected]>:
Quoted 17 lines
Hello,
Quoted 6 lines · Angelo Compagnucci
Honestly, I cannot see your point here. I really cannot understand why I should submit a patch that fixes the gogole feed API but leaves the site broken because gmane is out of service. The rest of things are functional to these fixings, so again cannot be splitted. This patch makes the minimal set of changes to fix the currently broken website. If not interested, please discard it.
You're doing a few completely independent things in here:
- Bumping the jquery/bootstrap versions
- Switching to the Yahoo feed API and fixing to using a non GMane RSS feed
- Fixing the search engine to not use GMane
Quoted 4 lines
I don't understand why you suddenly get mad, while all I'm asking is exactly what we ask for all other Buildroot patches: one patch does just one logical change. We ask this to all contributors. Why should your contributions be handled with different rules?
Just sent the patch as a series. Hope this will make someone happy :) !
BTW, I think that having a bit of flexibility will help in the long term. Having the website broken and having a patch that fixes it should not bring up all that formality also considering I'm the author of the current website and I know the matter (at least confined to the website itself).
Sincerely, Angelo
Quoted 8 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo