drm: mxsfb: fix error return code in mxsfb_load()
Subsystems (4)
PATCH 1/1 drm: mxsfb: fix error return code in mxsfb_load()
From: Wei Yongjun <[email protected]>
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/mxsfb/mxsfb_drv.c +1 -0
@@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) mxsfb->fbdev =drm_fbdev_cma_init (drm,32 , drm->mode_config.num_connector);if (IS_ERR (mxsfb->fbdev)) { + ret =PTR_ERR (mxsfb->fbdev); mxsfb->fbdev =NULL ;dev_err (drm->dev,"Failed to init FB CMA area\n" ); goto err_cma;
Hi Wei,
2017-02-05 Wei Yongjun <[email protected]>:
Quoted 15 lines
From: Wei Yongjun <[email protected]>
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Signed-off-by Wei Yongjun <[email protected]>--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/mxsfb/mxsfb_drv.c +0
-0
drivers/gpu/drm/mxsfb/mxsfb_drv.c static int mxsfb_load(struct drm_device *drm, unsigned long flags) · line 227
Quoted 7 lines
drivers/gpu/drm/mxsfb/mxsfb_drv.c +1
-0@@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) mxsfb->fbdev =drm_fbdev_cma_init (drm,32 , drm->mode_config.num_connector);if (IS_ERR (mxsfb->fbdev)) { + ret =PTR_ERR (mxsfb->fbdev); mxsfb->fbdev =NULL ;dev_err (drm->dev,"Failed to init FB CMA area\n" ); goto err_cma;
Gustavo
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Signed-off-by Wei Yongjun <[email protected]>
Quoted 19 lines
--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/mxsfb/mxsfb_drv.c +1
-0@@ -221,6 +221,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags) mxsfb->fbdev =drm_fbdev_cma_init (drm,32 , drm->mode_config.num_connector);if (IS_ERR (mxsfb->fbdev)) { + ret =PTR_ERR (mxsfb->fbdev); mxsfb->fbdev =NULL ;dev_err (drm->dev,"Failed to init FB CMA area\n" ); goto err_cma;
Signature · 2 lines
Best regards, Marek Vasut