Skip to contentSkip to conversation

ARM: 8641/1: treewide: fix error return code in hip04_smp_init()

PATCH Superseded Wei Yongjun 3 participants 4 messages Jan 22, 2017 – Apr 10, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: 8641/1: treewide: fix error return code in hip04_smp_init()

From: Wei Yongjun <[email protected]>

Fix to return error code -ENODEV from the of_find_compatible_node() error handling case instead of 0, as done elsewhere in this function.

---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-hisi/platmcpm.c +2 -0
index a6c1176..f0fff21 100644
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;
#1 lore raw

What does this have to do with patch 8641/1
("ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol") ?

Your patch also isn't "treewide" either. Confused.

Quoted 24 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return error code -ENODEV from the of_find_compatible_node() error handling case instead of 0, as done elsewhere in this function.

---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-hisi/platmcpm.c +2 -0
index a6c1176..f0fff21 100644
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#2 lore raw

PATCH v2 1/1 ARM: hisi: fix error return code in hip04_smp_init()

In reply to Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return error code -ENODEV from the of_find_compatible_node() error handling case instead of 0, as done elsewhere in this function.

---
v1 -> v2: fix file module

---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-hisi/platmcpm.c +2 -0
index a6c1176..f0fff21 100644
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;
maintainer
#3 lore raw

Re: [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()

Hi Yongjun,

Quoted 6 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix to return error code -ENODEV from the of_find_compatible_node() error handling case instead of 0, as done elsewhere in this function.

Thanks!
Applied to the hisilicon soc tree.

Best Regards,
Wei

Quoted 22 lines

---
v1 -> v2: fix file module

---
 arch/arm/mach-hisi/platmcpm.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-hisi/platmcpm.c +2 -0
index a6c1176..f0fff21 100644
@@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
 					 &hip04_boot_method[0], 4);
 	if (ret)
 		goto err;
+
+	ret = -ENODEV;
 	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
 	if (!np_sctl)
 		goto err;