Skip to contentSkip to conversation

powerpc/powernv: Add XHCI and USB storage to defconfig

PATCH Applied Michael Neuling 4 participants 8 messages Feb 6, 2017 – Feb 9, 2017 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 powerpc/powernv: Add XHCI and USB storage to defconfig

These are common on bare metal machines, so put them in the defconfig.

This adds 216KB to the vmlinux size

---
 arch/powerpc/configs/powernv_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/powerpc/configs/powernv_defconfig +2 -1
index b793550fac..7028dbc753 100644
@@ -214,10 +214,11 @@ CONFIG_HID_SUNPLUS=y
 CONFIG_USB_HIDDEV=y
 CONFIG_USB=y
 CONFIG_USB_MON=m
+CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_EHCI_HCD=y
 # CONFIG_USB_EHCI_HCD_PPC_OF is not set
 CONFIG_USB_OHCI_HCD=y
-CONFIG_USB_STORAGE=m
+CONFIG_USB_STORAGE=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=m
 CONFIG_LEDS_POWERNV=m
Signature · 1 line
2.9.3
#1 lore raw

PATCH 2/2 powerpc/powernv: Add more BPF in defconfig

This enables BCC (https://github.com/iovisor/bcc) on powernv.

This adds 225KB to the vmlinux size.

---
 arch/powerpc/configs/powernv_defconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/powerpc/configs/powernv_defconfig +5 -0
index 7028dbc753..911b43e2c7 100644
@@ -29,6 +29,7 @@ CONFIG_CGROUP_CPUACCT=y
 CONFIG_CGROUP_PERF=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
@@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=y
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=y
 CONFIG_BPF_JIT=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
Signature · 1 line
2.9.3
#2 lore raw

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

Quoted 22 lines · Michael Neuling

This enables BCC (https://github.com/iovisor/bcc) on powernv.

This adds 225KB to the vmlinux size.

---
 arch/powerpc/configs/powernv_defconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/powerpc/configs/powernv_defconfig +1 -0
index 7028dbc753..911b43e2c7 100644
@@ -29,6 +29,7 @@ CONFIG_CGROUP_CPUACCT=y
 CONFIG_CGROUP_PERF=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y

arch/powerpc/configs/powernv_defconfig CONFIG_NETFILTER=y · line 86

Quoted 7 lines
arch/powerpc/configs/powernv_defconfig +4 -0
@@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=y
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=y

I'm inclined to make these =m.

I assume that would still work for bcc?

cheers

#3 lore raw

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

Quoted 34 lines · Michael Ellerman
Quoted 22 lines · Michael Neuling

This enables BCC (https://github.com/iovisor/bcc) on powernv.

This adds 225KB to the vmlinux size.

---
 arch/powerpc/configs/powernv_defconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/powerpc/configs/powernv_defconfig +1 -0
index 7028dbc753..911b43e2c7 100644
@@ -29,6 +29,7 @@ CONFIG_CGROUP_CPUACCT=y
 CONFIG_CGROUP_PERF=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y

arch/powerpc/configs/powernv_defconfig CONFIG_NETFILTER=y · line 86

Quoted 7 lines
arch/powerpc/configs/powernv_defconfig +4 -0
@@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=y
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=y

I'm inclined to make these =m.

Quoted 1 line

I assume that would still work for bcc?

Yes, that should work too.
As an aside, I had sent a patch to enable BPF_SYSCALL across powernv, pseries and ppc64 defconfigs:
https://patchwork.ozlabs.org/patch/721997/

It would be good to have the network related BPF configs enabled across all three.

- Naveen

#4 lore raw

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

Quoted 17 lines · Naveen N. Rao
Quoted 16 lines · Michael Ellerman

arch/powerpc/configs/powernv_defconfig CONFIG_NETFILTER=y · line 86

Quoted 12 lines · Michael Neuling
arch/powerpc/configs/powernv_defconfig +4 -0
index 7028dbc753..911b43e2c7 100644
@@ -79,6 +80,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=y
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=y

I'm inclined to make these =m.

Quoted 7 lines
Quoted 1 line

I assume that would still work for bcc?

Yes, that should work too.

As an aside, I had sent a patch to enable BPF_SYSCALL across powernv, pseries and ppc64 defconfigs:
https://patchwork.ozlabs.org/patch/721997/

Thanks. That's better.

Quoted 2 lines

It would be good to have the network related BPF configs enabled across all three.

I'll mush the patches all together and turn them all on across pseries/ppc64/powernv.

cheers

#5 lore raw

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

Quoted 3 lines · Michael Ellerman

I'll mush the patches all together and turn them all on across pseries/ppc64/powernv.

Here's a version that does that. I have merged all the patches (including UPROBE_EVENT since that is very useful with bcc anyway). I have also added CGROUP_BPF to get namespace coverage.

Thanks,
Naveen

--
powerpc: include bpf/bcc related config options in defconfigs

Specifically:
- CONFIG_BPF_SYSCALL
- CONFIG_NET_SCHED
- CONFIG_NET_CLS_BPF
- CONFIG_NET_CLS_ACT
- CONFIG_NET_ACT_BPF
- CONFIG_CGROUP_BPF
- CONFIG_UPROBE_EVENT

... in pseries, ppc64 and powernv defconfigs.

---
 arch/powerpc/configs/powernv_defconfig | 7 +++++++
 arch/powerpc/configs/ppc64_defconfig   | 7 +++++++
 arch/powerpc/configs/pseries_defconfig | 7 +++++++
 3 files changed, 21 insertions(+)
arch/powerpc/configs/powernv_defconfig +7 -0
index b793550fac91..7a60b026247a 100644
@@ -26,9 +26,11 @@ CONFIG_CGROUP_FREEZER=y
 CONFIG_CPUSETS=y
 CONFIG_CGROUP_DEVICE=y
 CONFIG_CGROUP_CPUACCT=y
+CONFIG_CGROUP_BPF=y
 CONFIG_CGROUP_PERF=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
@@ -79,6 +81,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=m
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=m
 CONFIG_BPF_JIT=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
@@ -290,6 +296,7 @@ CONFIG_LOCKUP_DETECTOR=y
 CONFIG_LATENCYTOP=y
 CONFIG_SCHED_TRACER=y
 CONFIG_BLK_DEV_IO_TRACE=y
+CONFIG_UPROBE_EVENT=y
 CONFIG_CODE_PATCHING_SELFTEST=y
 CONFIG_FTR_FIXUP_SELFTEST=y
 CONFIG_MSI_BITMAP_SELFTEST=y
arch/powerpc/configs/ppc64_defconfig +7 -0
index 0396126ba6a8..4f1288b04303 100644
@@ -14,7 +14,9 @@ CONFIG_LOG_BUF_SHIFT=18
 CONFIG_LOG_CPU_MAX_BUF_SHIFT=13
 CONFIG_CGROUPS=y
 CONFIG_CPUSETS=y
+CONFIG_CGROUP_BPF=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
@@ -76,6 +78,10 @@ CONFIG_INET_IPCOMP=m
 CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=m
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=m
 CONFIG_BPF_JIT=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
@@ -324,6 +330,7 @@ CONFIG_DEBUG_MUTEXES=y
 CONFIG_LATENCYTOP=y
 CONFIG_SCHED_TRACER=y
 CONFIG_BLK_DEV_IO_TRACE=y
+CONFIG_UPROBE_EVENT=y
 CONFIG_CODE_PATCHING_SELFTEST=y
 CONFIG_FTR_FIXUP_SELFTEST=y
 CONFIG_MSI_BITMAP_SELFTEST=y
arch/powerpc/configs/pseries_defconfig +7 -0
index d99734f3b868..6d0eb02fefa4 100644
@@ -24,12 +24,14 @@ CONFIG_CGROUP_FREEZER=y
 CONFIG_CGROUP_DEVICE=y
 CONFIG_CPUSETS=y
 CONFIG_CGROUP_CPUACCT=y
+CONFIG_CGROUP_BPF=y
 CONFIG_MEMCG=y
 CONFIG_MEMCG_SWAP=y
 CONFIG_CGROUP_PERF=y
 CONFIG_CGROUP_SCHED=y
 CONFIG_USER_NS=y
 CONFIG_BLK_DEV_INITRD=y
+CONFIG_BPF_SYSCALL=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
@@ -82,6 +84,10 @@ CONFIG_NETFILTER=y
 # CONFIG_NETFILTER_ADVANCED is not set
 CONFIG_BRIDGE=m
 CONFIG_VLAN_8021Q=m
+CONFIG_NET_SCHED=y
+CONFIG_NET_CLS_BPF=m
+CONFIG_NET_CLS_ACT=y
+CONFIG_NET_ACT_BPF=m
 CONFIG_BPF_JIT=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
@@ -290,6 +296,7 @@ CONFIG_LOCKUP_DETECTOR=y
 CONFIG_LATENCYTOP=y
 CONFIG_SCHED_TRACER=y
 CONFIG_BLK_DEV_IO_TRACE=y
+CONFIG_UPROBE_EVENT=y
 CONFIG_CODE_PATCHING_SELFTEST=y
 CONFIG_FTR_FIXUP_SELFTEST=y
 CONFIG_MSI_BITMAP_SELFTEST=y
Signature · 1 line
2.11.0
#6 lore raw

Re: [2/2] powerpc/powernv: Add more BPF in defconfig

Quoted 23 lines · Naveen N. Rao
Quoted 3 lines · Michael Ellerman

I'll mush the patches all together and turn them all on across pseries/ppc64/powernv.

Here's a version that does that. I have merged all the patches (including UPROBE_EVENT since that is very useful with bcc anyway). I have also added CGROUP_BPF to get namespace coverage.

Thanks,
Naveen
---
powerpc: include bpf/bcc related config options in defconfigs

Specifically:
- CONFIG_BPF_SYSCALL
- CONFIG_NET_SCHED
- CONFIG_NET_CLS_BPF
- CONFIG_NET_CLS_ACT
- CONFIG_NET_ACT_BPF
- CONFIG_CGROUP_BPF
- CONFIG_UPROBE_EVENT

Quoted 3 lines

... in pseries, ppc64 and powernv defconfigs.

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/63b2547b155de2c41d40ea75015574

cheers