Skip to contentSkip to conversation

arm: dts: dra7: add qspi register map for control module

PATCH New Jean-Jacques Hiblot 2 participants 7 messages Feb 1, 2017 – Feb 7, 2017 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

---
 arch/arm/dts/dra7.dtsi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
arch/arm/dts/dra7.dtsi +4 -3
index 5570e30..46febc5 100644
@@ -1302,9 +1302,10 @@
 		qspi: qspi at 4b300000 {
 			compatible = "ti,dra7xxx-qspi";
 			reg = <0x4b300000 0x100>,
-			      <0x5c000000 0x4000000>;
-			reg-names = "qspi_base", "qspi_mmap";
-			syscon-chipselects = <&scm_conf 0x558>;
+			      <0x5c000000 0x4000000>,
+			      <0x4a002558 0x4>;
+			reg-names = "qspi_base", "qspi_mmap",
+				    "qspi_ctrlmod";
 			#address-cells = <1>;
 			#size-cells = <0>;
 			ti,hwmods = "qspi";
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 7 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Why is this not in the upstream DTS file?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170203/64420c96/attachment.sig>
#2 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 10 lines · Tom Rini
Quoted 7 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Why is this not in the upstream DTS file?

In Linux, a syscon/regmap is used to map this register while the QSPI driver in u-boot uses a direct memory access.

#3 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 11 lines · Jean-Jacques Hiblot
Quoted 8 lines · Tom Rini
Quoted 6 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Why is this not in the upstream DTS file?

In Linux, a syscon/regmap is used to map this register while the QSPI driver in u-boot uses a direct memory access.

OK, but it's a valid part of the upstream kernel binding, yes?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170206/ba294d7a/attachment.sig>
#4 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 11 lines · Tom Rini
Quoted 10 lines · Jean-Jacques Hiblot
Quoted 8 lines · Tom Rini
Quoted 6 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Why is this not in the upstream DTS file?

In Linux, a syscon/regmap is used to map this register while the QSPI driver in u-boot uses a direct memory access.

OK, but it's a valid part of the upstream kernel binding, yes?

syscon-chipselects is part of the mainlined binding. Using a 3rd memory range used to be the way to do it, but it is not supported anymore (I think it has been removed removed in 4.6).
Using a third memory range has been supported in u-boot for some time now. So you think we should move to using the syscon ?

#5 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 16 lines · Jean-Jacques Hiblot
Quoted 13 lines · Tom Rini
Quoted 12 lines · Jean-Jacques Hiblot
Quoted 10 lines · Tom Rini
Quoted 7 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Why is this not in the upstream DTS file?

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines

In Linux, a syscon/regmap is used to map this register while the QSPI driver in u-boot uses a direct memory access.

OK, but it's a valid part of the upstream kernel binding, yes?

syscon-chipselects is part of the mainlined binding. Using a 3rd memory range used to be the way to do it, but it is not supported anymore (I think it has been removed removed in 4.6).
Using a third memory range has been supported in u-boot for some time now. So you think we should move to using the syscon ?

Based on what I see in v4.10-rc7, yes, we should adapt the driver to know about the new property and things are working as expected wrt DT compatibility.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170206/52230607/attachment.sig>
#6 lore raw

PATCH 1/1 arm: dts: dra7: add qspi register map for control module

Quoted 18 lines · Tom Rini
Quoted 17 lines · Jean-Jacques Hiblot
Quoted 15 lines · Tom Rini
Quoted 9 lines · Jean-Jacques Hiblot
Quoted 8 lines · Tom Rini
Quoted 6 lines · Jean-Jacques Hiblot

Add qspi control module register maps to device tree. This register map had been removed by error when syncing the DTS with the latest linux at the time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux"). Without this entry the driver do not support memory-mapped access and the data read from the SF is invalid.

Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Why is this not in the upstream DTS file?

In Linux, a syscon/regmap is used to map this register while the QSPI driver in u-boot uses a direct memory access.

OK, but it's a valid part of the upstream kernel binding, yes?

Quoted 8 lines
Quoted 5 lines

syscon-chipselects is part of the mainlined binding. Using a 3rd memory range used to be the way to do it, but it is not supported anymore (I think it has been removed removed in 4.6).
Using a third memory range has been supported in u-boot for some time now. So you think we should move to using the syscon ?

Based on what I see in v4.10-rc7, yes, we should adapt the driver to know about the new property and things are working as expected wrt DT compatibility.

Ok. I have prepared a new series to do this

Quoted 1 line