Skip to contentSkip to conversation

Print text for disassociation reason.

PATCH In review Arkadiusz Miskiewicz 2 participants 2 messages Feb 6, 2017 – Feb 8, 2017 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Print text for disassociation reason.

Hi.

Don't know why it wasn't printed there with ieee80211_get_reason_code_strin= g in first
place. Works for me:

kernel: wlan0: disassociated from 04:b0:20:33:ff:1f (Reason: 34=3DDISASSOC_= LOW_ACK)

ps. can't send patch in normal way due to postmaster@vger weirdness, so ins= erted
below

=46rom c9b55bb44fe0b902f376a41fa930c9a67a438511 Mon Sep 17 00:00:00 2001 =46rom: =3D?UTF-8?q?Arkadiusz=3D20Mi=3DC5=3D9Bkiewicz?=3D <[email protected]>
Date: Mon, 6 Feb 2017 14:45:15 +0100
Subject: [PATCH] Print text for disassociation reason.
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

When disassociation happens only numeric reason is printed in ieee80211_rx_mgmt_disassoc(). Add text variant, too.

=2D--

 net/mac80211/mlme.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
net/mac80211/mlme.c +0 -0
index 098ce9b179ee..fcf8d0aa66ec 100644

=2D-- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -2801,8 +2801,9 @@ static void ieee80211_rx_mgmt_disassoc(struct ieee802= 11_sub_if_data *sdata,
=20
reason_code =3D le16_to_cpu(mgmt->u.disassoc.reason_code);
=20
=2D sdata_info(sdata, "disassociated from %pM (Reason: %u)\n",
=2D mgmt->sa, reason_code);
+ sdata_info(sdata, "disassociated from %pM (Reason: %u=3D%s)\n",
+ mgmt->sa, reason_code,
+ ieee80211_get_reason_code_string(reason_code));
=20
ieee80211_set_disassoc(sdata, 0, 0, false, NULL);
=20
=2D-=20
2.11.0

=2D-=20
Arkadiusz Mi=C5=9Bkiewicz, arekm / ( maven.pl | pld-linux.org )

maintainer
#1 lore raw
Quoted 6 lines

Don't know why it wasn't printed there with
ieee80211_get_reason_code_string in first
place. Works for me:

kernel: wlan0: disassociated from 04:b0:20:33:ff:1f (Reason:
34=DISASSOC_LOW_ACK)

This patch needs a "mac80211: " prefix, and I'd prefer no . at the end (but that's not a hard rule)

Quoted 13 lines

ps. can't send patch in normal way due to postmaster@vger weirdness, so inserted
below

From c9b55bb44fe0b902f376a41fa930c9a67a438511 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arkadiusz=20Mi=C5=9Bkiewicz?= <[email protected]>
Date: Mon, 6 Feb 2017 14:45:15 +0100
Subject: [PATCH] Print text for disassociation reason.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 4 lines

When disassociation happens only numeric reason is printed in ieee80211_rx_mgmt_disassoc(). Add text variant, too.

This is useless to me, please resubmit without all the fluff. You can insert a "From: " line into the first line of the email *body* to get the author correct, if you can't actually send it from the correct email address. git send-email will even do that for you.

johannes