ntp: security bump to verserion 4.2.8p9
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
This version of ntp fixes several vulnerabilities.
CVE-2016-9311
CVE-2016-9310
CVE-2016-7427
CVE-2016-7428
CVE-2016-9312
CVE-2016-7431
CVE-2016-7434
CVE-2016-7429
CVE-2016-7426
CVE-2016-7433
http://www.kb.cert.org/vuls/id/633847
In addition, libssl_compat.h is now included in many files, which references openssl/evp.h, openssl/dsa.h, and openssl/rsa.h. Even if a you pass --disable-ssl as a configuration option, these files are now required.
As such, I have also added openssl as a dependency, and it is now automatically selected when you select ntp.
---
v1 -> v2:
- Changed subject to indicate a security bump. (suggested by Baruch)
- Removed check to see if openssl is enabled (suggested by Baruch)
- Added the option --with-crypto to the configuration options by default.
package/ntp/Config.in | 1 + package/ntp/ntp.hash | 6 +++--- package/ntp/ntp.mk | 15 +++++---------- 3 files changed, 9 insertions(+), 13 deletions(-)
package/ntp/Config.in +1 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_NTP bool "ntp" select BR2_PACKAGE_LIBEVENT + select BR2_PACKAGE_OPENSSL help Network Time Protocol suite/programs. Provides things like ntpd, ntpdate, ntpq, etc...
package/ntp/ntp.hash +3 -3
@@ -1,4 +1,4 @@ -# From http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-4.2.8p8.tar.gz.md5 -md5 4a8636260435b230636f053ffd070e34 ntp-4.2.8p8.tar.gz +# From http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-4.2.8p9.tar.gz.md5 +md5 857452b05f5f2e033786f77ade1974ed ntp-4.2.8p9.tar.gz # Calculated based on the hash above -sha256 2ab3d0b5f0456e6311dda1cc27ab75da108762773a19e46abd938bd9407b97ee ntp-4.2.8p8.tar.gz +sha256 b724287778e1bac625b447327c9851eedef020517a3545625e9f652a90f30b72 ntp-4.2.8p9.tar.gz
package/ntp/ntp.mk +5 -10
@@ -5,9 +5,9 @@ ################################################################################ NTP_VERSION_MAJOR = 4.2 -NTP_VERSION = $(NTP_VERSION_MAJOR).8p8 +NTP_VERSION = $(NTP_VERSION_MAJOR).8p9 NTP_SITE = http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-$(NTP_VERSION_MAJOR) -NTP_DEPENDENCIES = host-pkgconf libevent $(if $(BR2_PACKAGE_BUSYBOX),busybox) +NTP_DEPENDENCIES = host-pkgconf libevent openssl $(if $(BR2_PACKAGE_BUSYBOX),busybox) NTP_LICENSE = ntp license NTP_LICENSE_FILES = COPYRIGHT NTP_CONF_ENV = ac_cv_lib_md5_MD5Init=no
@@ -17,17 +17,12 @@ NTP_CONF_OPTS = \ --disable-tickadj \ --disable-debugging \ --with-yielding-select=yes \ - --disable-local-libevent + --disable-local-libevent \ + --with-crypto + # 0002-ntp-syscalls-fallback.patch NTP_AUTORECONF = YES -ifeq ($(BR2_PACKAGE_OPENSSL),y) -NTP_CONF_OPTS += --with-crypto -NTP_DEPENDENCIES += openssl -else -NTP_CONF_OPTS += --without-crypto --disable-openssl-random -endif - ifeq ($(BR2_PACKAGE_LIBCAP),y) NTP_CONF_OPTS += --enable-linuxcaps NTP_DEPENDENCIES += libcap
Signature · 1 line
2.9.3
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
Hello,
Quoted 4 lines · Adam Duskett
In addition,
libssl_compat.his now included in many files, which referencesopenssl/evp.h,openssl/dsa.h, andopenssl/rsa.h. Even if a you pass --disable-ssl as a configuration option, these files are now required.
Is this a bug in 4.2.8p9, or a real decision from upstream that OpenSSL is now mandatory in ntp?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
Hello,
Quoted 4 lines · Adam Duskett
That's the million dollar question! As far as I can tell, it's a real decision from upstream, as many of the files now include
libssl_compat.h, however if you want, I can try to play around with them and see if they are 100% mandatory or not.
That would be useful, yes.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
Quoted 10 lines · Thomas Petazzoni
Hello,
Quoted 4 lines · Adam Duskett
That's the million dollar question! As far as I can tell, it's a real decision from upstream, as many of the files now include
libssl_compat.h, however if you want, I can try to play around with them and see if they are 100% mandatory or not.That would be useful, yes.
It's really weird that they introduce such a dependency in a p8 -> p9 bump...
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
After doing some digging into the source code, it looks like there are two new files: include/libssl_compat.h and libssl_compat.c
These files are now referenced in quite a few places, all of which would take quite a bit of time to unwind.
I would suggest leaving openssl as a dependency unless somebody else wants to take a crack at cleaning it up.
Quoted 12 lines · Arnout Vandecappelle
Quoted 9 lines · Thomas Petazzoni
Hello,
Quoted 4 lines · Adam Duskett
That's the million dollar question! As far as I can tell, it's a real decision from upstream, as many of the files now include
libssl_compat.h, however if you want, I can try to play around with them and see if they are 100% mandatory or not.
Quoted 7 lines
Quoted 1 line
That would be useful, yes.
It's really weird that they introduce such a dependency in a p8 -> p9 bump...
Regards,
Arnout
Oh I agree! But it looks like that's exactly what has happened, even if by accident!
Quoted 7 lines
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Adam
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Adam" == Adam Duskett <[email protected]> writes:
After doing some digging into the source code, it looks like there are two new files:
include/libssl_compat.handlibssl_compat.cThese files are now referenced in quite a few places, all of which would take quite a bit of time to unwind.
I would suggest leaving openssl as a dependency unless somebody else wants to take a crack at cleaning it up.
Yes, I had a look as well. Most can be handled by a #ifdef OPENSSL around the openssl specific stuff, but a number of places now use more EVP_MD_CTX_* functions that aren't covered by the emulation functions in ntp_md5.h.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
In reply to Adam DuskettQuoted 24 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Adam" == Adam Duskett <[email protected]> writes:
This version of ntp fixes several vulnerabilities. CVE-2016-9311
CVE-2016-9310
CVE-2016-7427
CVE-2016-7428
CVE-2016-9312
CVE-2016-7431
CVE-2016-7434
CVE-2016-7429
CVE-2016-7426
CVE-2016-7433http://www.kb.cert.org/vuls/id/633847
In addition,
libssl_compat.his now included in many files, which referencesopenssl/evp.h,openssl/dsa.h, andopenssl/rsa.h. Even if a you pass --disable-ssl as a configuration option, these files are now required.As such, I have also added openssl as a dependency, and it is now automatically selected when you select ntp.
Quoted 6 lines
Signed-off-by Adam Duskett <[email protected]>---
v1 -> v2:
- Changed subject to indicate a security bump. (suggested by Baruch)
- Removed check to see if openssl is enabled (suggested by Baruch)
- Added the option --with-crypto to the configuration options by default.
It's a bit of a pain that openssl no longer is optional, but fixing that seems to be nontrivial. Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
In reply to Adam DuskettHello,
Quoted 20 lines · Adam Duskett
This version of ntp fixes several vulnerabilities.
CVE-2016-9311
CVE-2016-9310
CVE-2016-7427
CVE-2016-7428
CVE-2016-9312
CVE-2016-7431
CVE-2016-7434
CVE-2016-7429
CVE-2016-7426
CVE-2016-7433http://www.kb.cert.org/vuls/id/633847
In addition,
libssl_compat.his now included in many files, which referencesopenssl/evp.h,openssl/dsa.h, andopenssl/rsa.h. Even if a you pass --disable-ssl as a configuration option, these files are now required.
Quoted 4 lines
As such, I have also added openssl as a dependency, and it is now automatically selected when you select ntp.
Signed-off-by Adam Duskett <[email protected]>
This patch raised a comment on Github:
https://github.com/buildroot/buildroot/commit/ebf6f64b76059e31a85f982cb04f80ad5982dac3#commitcomment-25458671.
Apparently, building without OpenSSL is still possible (perhaps has been fixed in 4.2.8p10 ?), and some users would like ntp without OpenSSL support.
Adam, could you have a look into this ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/1 ntp: security bump to verserion 4.2.8p9
Thomas;
Quoted 28 lines · Thomas Petazzoni
Hello,
Quoted 20 lines · Adam Duskett
This version of ntp fixes several vulnerabilities.
CVE-2016-9311
CVE-2016-9310
CVE-2016-7427
CVE-2016-7428
CVE-2016-9312
CVE-2016-7431
CVE-2016-7434
CVE-2016-7429
CVE-2016-7426
CVE-2016-7433http://www.kb.cert.org/vuls/id/633847
In addition,
libssl_compat.his now included in many files, which referencesopenssl/evp.h,openssl/dsa.h, andopenssl/rsa.h. Even if a you pass --disable-ssl as a configuration option, these files are now required.Quoted 4 lines
As such, I have also added openssl as a dependency, and it is now automatically selected when you select ntp.
Signed-off-by Adam Duskett <[email protected]>
Quoted 8 lines
This patch raised a comment on Github:
https://github.com/buildroot/buildroot/commit/ebf6f64b76059e31a85f982cb04f80ad5982dac3#commitcomment-25458671.
Apparently, building without OpenSSL is still possible (perhaps has been fixed in 4.2.8p10 ?), and some users would like ntp without OpenSSL support.Adam, could you have a look into this ?
Looks like p10 fixed the issue! I will submit a patch to revert the new dependency.
Quoted 7 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com