Skip to contentSkip to conversation

clk: sunxi-ng: sun9i-a80: Fix wrong pointer passed to PTR_ERR()

PATCH New Wei Yongjun 2 participants 2 messages Feb 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: sunxi-ng: sun9i-a80: Fix wrong pointer passed to PTR_ERR()

From: Wei Yongjun <[email protected]>

PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned.

Fixes 783ab76ae553 ("clk: sunxi-ng: Add A80 Display Engine CCU")
---
 drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/sunxi-ng/ccu-sun9i-a80-de.c +1 -1
index 3fc27db..6d11658 100644
@@ -232,7 +232,7 @@ static int sun9i_a80_de_clk_probe(struct platform_device *pdev)
 
 	rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
 	if (IS_ERR(rstc)) {
-		ret = PTR_ERR(bus_clk);
+		ret = PTR_ERR(rstc);
 		if (ret != -EPROBE_DEFER)
 			dev_err(&pdev->dev,
 				"Couldn't get reset control: %d\n", ret);
Applied
#1 lore raw

PATCH 1/1 clk: sunxi-ng: sun9i-a80: Fix wrong pointer passed to PTR_ERR()

Quoted 8 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned.

Fixes 783ab76ae553 ("clk: sunxi-ng: Add A80 Display Engine CCU")

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project