Input: xpad - restore LED state after device resume
Subsystems (2)
PATCH v2 1/1 Input: xpad - restore LED state after device resume
Set the LED_CORE_SUSPENDRESUME flag on our LED device so the LED state will be automatically restored by LED core on resume.
Since Xbox One pads stop flashing only when reinitialized, we'll send them the initialization packet so they calm down too.
---
Sending this one alone, since the rest of the series was applied or needs non-trivial reworking.
Thanks,
Cameron
--- drivers/input/joystick/xpad.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/input/joystick/xpad.c +10 -1
@@ -1240,6 +1240,7 @@ static int xpad_led_probe(struct usb_xpad *xpad) led_cdev = &led->led_cdev; led_cdev->name = led->name; led_cdev->brightness_set = xpad_led_set; + led_cdev->flags =LED_CORE_SUSPENDRESUME ; error =led_classdev_register (&xpad->udev->dev, led_cdev);if (error)
@@ -1716,8 +1717,16 @@ static int xpad_resume(struct usb_interface *intf) retval =xpad360w_start_input (xpad); }else {mutex_lock (&input->mutex); -if (input->users) +if (input->users) { retval =xpad_start_input (xpad); + }else if (xpad->xtype ==XTYPE_XBOXONE ) { +/* +* Even if there are no users, we'll send Xbox One pads +* the startup sequence so they don't sit there and +* blink until somebody opens the input device again. +*/ + retval =xpad_start_xbox_one (xpad); + }mutex_unlock (&input->mutex); }
Signature · 1 line
2.9.3
Quoted 7 lines · Cameron Gutman
Set the
LED_CORE_SUSPENDRESUMEflag on our LED device so the LED state will be automatically restored by LED core on resume.Since Xbox One pads stop flashing only when reinitialized, we'll send them the initialization packet so they calm down too.
Signed-off-by Cameron Gutman <[email protected]>
Applied, thank you.
Quoted 44 lines
---
Sending this one alone, since the rest of the series was applied or needs non-trivial reworking.Thanks,
Cameron--- drivers/input/joystick/xpad.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)drivers/input/joystick/xpad.c +10
-1@@ -1240,6 +1240,7 @@ static int xpad_led_probe(struct usb_xpad *xpad) led_cdev = &led->led_cdev; led_cdev->name = led->name; led_cdev->brightness_set = xpad_led_set; + led_cdev->flags =LED_CORE_SUSPENDRESUME ; error =led_classdev_register (&xpad->udev->dev, led_cdev);if (error)@@ -1716,8 +1717,16 @@ static int xpad_resume(struct usb_interface *intf) retval =xpad360w_start_input (xpad); }else {mutex_lock (&input->mutex); -if (input->users) +if (input->users) { retval =xpad_start_input (xpad); + }else if (xpad->xtype ==XTYPE_XBOXONE ) { +/* +* Even if there are no users, we'll send Xbox One pads +* the startup sequence so they don't sit there and +* blink until somebody opens the input device again. +*/ + retval =xpad_start_xbox_one (xpad); + }mutex_unlock (&input->mutex); }Signature · 1 line
2.9.3
Signature · 1 line
Dmitry