kconfig/mconf: propagate jumping function in search result view
Subsystems (3)
cover kconfig/mconf: propagate jumping function in search result view
From: Changbin Du <[email protected]>
While I am searching something in menuconfig, I hope if I can jump to interested items directly. I even try to add this feature. When I check the code just found it has already been there but not documented. So why let more developers know it?
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textbox Documentation/kconfig: add search jump feature description
Documentation/kbuild/kconfig.txt | 4 ++++ scripts/kconfig/mconf.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 kconfig/mconf: add jumping tip in title of search result textbox
From: Changbin Du <[email protected]>
Prompt user how to quickly jump to the item he/she is interested in.
--- scripts/kconfig/mconf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
scripts/kconfig/mconf.c +4 -4
@@ -443,10 +443,10 @@ static void search_conf(void) res =get_relations_str (sym_arr, &head);set_subtitle (); - dres =show_textbox_ext (_ ("Search Results" ), (char *) -str_get (&res),0 ,0 , keys, &vscroll, - &hscroll, &update_text, (void *) - &data); + dres =show_textbox_ext ( +_ ("Search Results (type the number to jump)" ), + (char *)str_get (&res),0 ,0 , keys, &vscroll, + &hscroll, &update_text, (void *)&data); again = false;for (i =0 ; i <JUMP_NB && keys[i]; i++)if (dres == keys[i]) {
Signature · 1 line
2.7.4
Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Quoted 3 lines · On Mon, 06 Feb 2017, [email protected] wrote:
From: Changbin Du <[email protected]>
Prompt user how to quickly jump to the item he/she is interested in.
:o
All these years. I... I didn't know. Thanks!
Quoted 11 lines
Signed-off-by Changbin Du <[email protected]>--- scripts/kconfig/mconf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/kconfig/mconf.c +0
-0@@ -443,10 +443,10 @@ static void search_conf(void)
scripts/kconfig/mconf.c static void search_conf(void) · line 449
Quoted 10 lines
scripts/kconfig/mconf.c +4
-4res =get_relations_str (sym_arr, &head);set_subtitle (); - dres =show_textbox_ext (_ ("Search Results" ), (char *) -str_get (&res),0 ,0 , keys, &vscroll, - &hscroll, &update_text, (void *) - &data); + dres =show_textbox_ext ( +_ ("Search Results (type the number to jump)" ), + (char *)str_get (&res),0 ,0 , keys, &vscroll, + &hscroll, &update_text, (void *)&data);
It would be even better and discoverable if this could be turned into a dialog menu, so that you could navigate the search results using arrow keys and hit enter to choose. But this is already an improvement.
Quoted 3 lines
scripts/kconfig/mconf.c +0
-0again = false;for (i =0 ; i <JUMP_NB && keys[i]; i++)if (dres == keys[i]) {
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Quoted 9 lines · Jani Nikula
Quoted 3 lines · On Mon, 06 Feb 2017, [email protected] wrote:
From: Changbin Du <[email protected]>
Prompt user how to quickly jump to the item he/she is interested in.
:o
All these years. I... I didn't know. Thanks!
aha, me too! You know, back to the top menu then look into step by step...
Quoted 11 lines
Quoted 11 lines
Signed-off-by Changbin Du <[email protected]>--- scripts/kconfig/mconf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/kconfig/mconf.c +0
-0@@ -443,10 +443,10 @@ static void search_conf(void)
Quoted 15 lines
scripts/kconfig/mconf.c static void search_conf(void) · line 449
Quoted 10 lines
scripts/kconfig/mconf.c +4
-4res =get_relations_str (sym_arr, &head);set_subtitle (); - dres =show_textbox_ext (_ ("Search Results" ), (char *) -str_get (&res),0 ,0 , keys, &vscroll, - &hscroll, &update_text, (void *) - &data); + dres =show_textbox_ext ( +_ ("Search Results (type the number to jump)" ), + (char *)str_get (&res),0 ,0 , keys, &vscroll, + &hscroll, &update_text, (void *)&data);It would be even better and discoverable if this could be turned into a dialog menu, so that you could navigate the search results using arrow keys and hit enter to choose. But this is already an improvement.
Yes, that will have a better experience. :)
Quoted 6 lines
Quoted 3 lines
scripts/kconfig/mconf.c +0
-0again = false;for (i =0 ; i <JUMP_NB && keys[i]; i++)if (dres == keys[i]) {Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Signature · 2 lines
Thanks, Changbin
PATCH 2/2 Documentation/kconfig: add search jump feature description
In reply to [email protected]From: Changbin Du <[email protected]>
Kernel menuconfig support direct jumping function from the search result. This is a very convenient feature but not documented. So add a short description to the kconfig documentation to let more developer know it.
--- Documentation/kbuild/kconfig.txt | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/kbuild/kconfig.txt +4 -0
@@ -178,6 +178,10 @@ Searching in menuconfig: first (and in alphabetical order), then come all other symbols, sorted in alphabetical order. + In the search result textbox, each symbol has a jump number on + left side if the symbol is jumpable. You can type the nubmer + to jump to target menu to configurate that symbol. + ______________________________________________________________________ User interface options for 'menuconfig'
Signature · 1 line
2.7.4
Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description
Quoted 17 lines · On Mon, Feb 6, 2017 at 12:46 AM, <[email protected]> wrote:
From: Changbin Du <[email protected]>
Kernel menuconfig support direct jumping function from the search result. This is a very convenient feature but not documented. So add a short description to the kconfig documentation to let more developer know it.
Signed-off-by Changbin Du <[email protected]>--- Documentation/kbuild/kconfig.txt | 4 ++++ 1 file changed, 4 insertions(+)Documentation/kbuild/kconfig.txt +0
-0
Documentation/kbuild/kconfig.txt Searching in menuconfig: · line 182
Quoted 5 lines
Documentation/kbuild/kconfig.txt +2
-0@@ -178,6 +178,10 @@ Searching in menuconfig: first (and in alphabetical order), then come all other symbols, sorted in alphabetical order. + In the search result textbox, each symbol has a jump number on + left side if the symbol is jumpable. You can type the nubmer
number ("jumpable" reads a bit oddly, but it is understandable.)
Documentation/kbuild/kconfig.txt Searching in menuconfig: · line 183
Quoted 1 line
Documentation/kbuild/kconfig.txt +1
-0+ to jump to target menu to configurate that symbol.
configure?
Signature · 1 line
Jim
Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description
Quoted 21 lines · Jim Davis
Quoted 20 lines · On Mon, Feb 6, 2017 at 12:46 AM, <[email protected]> wrote:
From: Changbin Du <[email protected]>
Kernel menuconfig support direct jumping function from the search result. This is a very convenient feature but not documented. So add a short description to the kconfig documentation to let more developer know it.
Signed-off-by Changbin Du <[email protected]>--- Documentation/kbuild/kconfig.txt | 4 ++++ 1 file changed, 4 insertions(+)Documentation/kbuild/kconfig.txt +0
-0@@ -178,6 +178,10 @@ Searching in menuconfig: first (and in alphabetical order), then come all other symbols, sorted in alphabetical order.
Quoted 5 lines
Documentation/kbuild/kconfig.txt Searching in menuconfig: · line 182
Quoted 2 lines
Documentation/kbuild/kconfig.txt +2
-0+ In the search result textbox, each symbol has a jump number on + left side if the symbol is jumpable. You can type the nubmernumber ("jumpable" reads a bit oddly, but it is understandable.)
How about 'if the symbol is visible'?
Quoted 4 lines
Documentation/kbuild/kconfig.txt Searching in menuconfig: · line 183
Quoted 1 line
Documentation/kbuild/kconfig.txt +1
-0+ to jump to target menu to configurate that symbol.configure?
Thanks, I will correct them.
Quoted 2 lines
Signature · 1 line
Jim
Signature · 2 lines
Thanks, Changbin
v2 cover kconfig/mconf: propagate jumping function in search result view
In reply to [email protected]From: Changbin Du <[email protected]>
While I am searching something in menuconfig, I hope if I can jump to interested items directly. I even try to add this feature. When I check the code just found it has already been there but not documented. So why let more developers know it?
v2: correct spell (Jim)
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textbox Documentation/kconfig: add search jump feature description
Documentation/kbuild/kconfig.txt | 4 ++++ scripts/kconfig/mconf.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4
PATCH v2 1/2 kconfig/mconf: add jumping tip in title of search result textbox
From: Changbin Du <[email protected]>
Prompt user how to quickly jump to the item he/she is interested in.
--- scripts/kconfig/mconf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
scripts/kconfig/mconf.c +4 -4
@@ -443,10 +443,10 @@ static void search_conf(void) res =get_relations_str (sym_arr, &head);set_subtitle (); - dres =show_textbox_ext (_ ("Search Results" ), (char *) -str_get (&res),0 ,0 , keys, &vscroll, - &hscroll, &update_text, (void *) - &data); + dres =show_textbox_ext ( +_ ("Search Results (type the number to jump)" ), + (char *)str_get (&res),0 ,0 , keys, &vscroll, + &hscroll, &update_text, (void *)&data); again = false;for (i =0 ; i <JUMP_NB && keys[i]; i++)if (dres == keys[i]) {
Signature · 1 line
2.7.4
Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Quoted 6 lines · On Wed, 08 Feb 2017, [email protected] wrote:
From: Changbin Du <[email protected]>
Prompt user how to quickly jump to the item he/she is interested in.
Signed-off-by Changbin Du <[email protected]>Reviewed-by Jani Nikula <[email protected]>
This is assuming too much... but I looked at it now, and it looks good to me.
Thanks,
Jani.
Quoted 23 lines
--- scripts/kconfig/mconf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/kconfig/mconf.c +4
-4@@ -443,10 +443,10 @@ static void search_conf(void) res =get_relations_str (sym_arr, &head);set_subtitle (); - dres =show_textbox_ext (_ ("Search Results" ), (char *) -str_get (&res),0 ,0 , keys, &vscroll, - &hscroll, &update_text, (void *) - &data); + dres =show_textbox_ext ( +_ ("Search Results (type the number to jump)" ), + (char *)str_get (&res),0 ,0 , keys, &vscroll, + &hscroll, &update_text, (void *)&data); again = false;for (i =0 ; i <JUMP_NB && keys[i]; i++)if (dres == keys[i]) {
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
PATCH v2 2/2 Documentation/kconfig: add search jump feature description
In reply to [email protected]From: Changbin Du <[email protected]>
Kernel menuconfig support direct jumping function from the search result. This is a very convenient feature but not documented. So add a short description to the kconfig documentation to let more developers know it.
v2: correct spell (Jim)
--- Documentation/kbuild/kconfig.txt | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/kbuild/kconfig.txt +4 -0
@@ -178,6 +178,10 @@ Searching in menuconfig: first (and in alphabetical order), then come all other symbols, sorted in alphabetical order. + In the search result textbox, each symbol has a jump number on + left side if the symbol is visible. You can type the number + to jump to target menu to configure that symbol. + ______________________________________________________________________ User interface options for 'menuconfig'
Signature · 1 line
2.7.4
Hello, any new update need for this or new comments? :)
Quoted 19 lines · On Wed, Feb 08, 2017 at 11:09:37AM +0800, [email protected] wrote:
From: Changbin Du <[email protected]>
While I am searching something in menuconfig, I hope if I can jump to interested items directly. I even try to add this feature. When I check the code just found it has already been there but not documented. So why let more developers know it?
v2: correct spell (Jim)
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textboxDocumentation/kconfig: add search jump feature descriptionDocumentation/kbuild/kconfig.txt | 4 ++++ scripts/kconfig/mconf.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-)Signature · 1 line
2.7.4
Signature · 2 lines
Thanks, Changbin Du
Sencond ping... if this is realy not necessary I give up.
Quoted 26 lines · Changbin
Hello, any new update need for this or new comments? :)
Quoted 19 lines · On Wed, Feb 08, 2017 at 11:09:37AM +0800, [email protected] wrote:
From: Changbin Du <[email protected]>
While I am searching something in menuconfig, I hope if I can jump to interested items directly. I even try to add this feature. When I check the code just found it has already been there but not documented. So why let more developers know it?
v2: correct spell (Jim)
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textboxDocumentation/kconfig: add search jump feature descriptionDocumentation/kbuild/kconfig.txt | 4 ++++ scripts/kconfig/mconf.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-)Signature · 1 line
2.7.4Signature · 2 lines
Thanks, Changbin Du
Signature · 2 lines
Thanks, Changbin Du
Yann?
I'd like to have both of these merged, I think they are worthwhile and simple additions, and they look good to me.
BR,
Jani.
Quoted 29 lines · Changbin
Sencond ping... if this is realy not necessary I give up.
Quoted 26 lines · Changbin
Hello, any new update need for this or new comments? :)
Quoted 19 lines · On Wed, Feb 08, 2017 at 11:09:37AM +0800, [email protected] wrote:
From: Changbin Du <[email protected]>
While I am searching something in menuconfig, I hope if I can jump to interested items directly. I even try to add this feature. When I check the code just found it has already been there but not documented. So why let more developers know it?
v2: correct spell (Jim)
Changbin Du (2):
kconfig/mconf: add jumping tip in title of search result textboxDocumentation/kconfig: add search jump feature descriptionDocumentation/kbuild/kconfig.txt | 4 ++++ scripts/kconfig/mconf.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-)Signature · 1 line
2.7.4Signature · 2 lines
Thanks, Changbin Du
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center