Skip to contentSkip to conversation

arm64: dts: r8a779[56]: EtherAVB Gigabit timing enhancements

PATCH New Simon Horman 2 participants 7 messages Feb 1, 2017 – Feb 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: r8a779[56]: EtherAVB Gigabit timing enhancements

Hi,

this series tweaks PHY settings to address communications failures reported for 1Gbit communication using EtherAVB. Gigabit is supported for R-Car H3 ES1.1+ and M3-W as of commit 0e98f9d5f0b4 ("ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W") which is present in net-next and should be included in v4.11.

This series is based on renesas-devel-20170130-v4.10-rc6

Kazuya Mizuguchi (4):
arm64: dts: r8a7795: Use rgmii-txid phy-mode for EthernetAVB
arm64: dts: r8a7795: salvator-x: Fix EthernetAVB PHY timing
arm64: dts: r8a7796: Use rgmii-txid phy-mode for EthernetAVB
arm64: dts: r8a7796: salvator-x: Fix EthernetAVB PHY timing

Vladimir Barinov (1):
arm64: dts: h3ulcb: Fix EthernetAVB PHY timing

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts     | 13 +------------
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 13 +------------
 arch/arm64/boot/dts/renesas/r8a7795.dtsi           |  2 +-
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 13 +------------
 arch/arm64/boot/dts/renesas/r8a7796.dtsi           |  2 +-
 5 files changed, 5 insertions(+), 38 deletions(-)
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#1 lore raw

PATCH 1/5 arm64: dts: r8a7795: Use rgmii-txid phy-mode for EthernetAVB

From: Kazuya Mizuguchi <[email protected]>

Since commit 61fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR") the EthernetAVB driver enables tx and rx clock internal delay modes (TDM and RDM) depending on the phy mode as follows:

phy mode | ASPR delay mode
-----------+----------------
rgmii-id | TDM and RDM
rgmii-rxid | RDM
rgmii-txid | TDM

And prior to the above commit no internal delay mode settings were implemented for any phy mode.

With this and the above change present tx internal delay mode is enabled which has been observed to address failures in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the r8a7795 (H3) and r8a7796 (M3-W) SoCs.

With the above patch present but this patch present tx and rx internal delay modes are enabled; and with the above patch and this present absent no internal delay modes are enabled. In both cases failures have been observed when using 1Gbps communication in the environments described above.

---

[v1] Simon Horman
- Rewrote changelog

N.B. The communications failures have been reported by the BSP team,
however I did not observe them during testing with a salvator-x/M3-W-ES1.0

I have also exercised this on salvator-x/H3-ES1.0, which supports a maximum communication speed of 100Mbit/s. I did not observe communications failures during that testing.

My test-case was to bring up the system using NFS root and
run: netperf -H <HOST>

[v0] Kazuya Mizuguchi

---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/renesas/r8a7795.dtsi +1 -1
index fe266bb3d913..382a8987bca9 100644
@@ -564,7 +564,7 @@
 					  "ch24";
 			clocks = <&cpg CPG_MOD 812>;
 			power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-			phy-mode = "rgmii-id";
+			phy-mode = "rgmii-txid";
 			#address-cells = <1>;
 			#size-cells = <0>;
 			status = "disabled";
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#2 lore raw

PATCH 2/5 arm64: dts: r8a7795: salvator-x: Fix EthernetAVB PHY timing

In reply to Simon Horman

From: Kazuya Mizuguchi <[email protected]>

Set PHY rxc-skew-ps to 1500 and all other values to their default values.

This is intended to to address failures in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the r8a7795 (H3) and r8a7796 (M3-W) SoCs.

---
v1 [Simon Horman]
* Do not set values to defaults, omit them and let the driver set the defaults
* Rewrote changelog

N.B. The communications failures have been reported by the BSP team,
however I did not observe them during testing with a salvator-x/M3-W-ES1.0

I have also exercised this on salvator-x/H3-ES1.0, which supports a maximum communication speed of 100Mbit/s. I did not observe communications failures during that testing.

My test-case was to bring up the system using NFS root and
run: netperf -H <HOST>

v0 [Kazuya Mizuguchi]

---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +1 -12
index dc1177c76aa5..5158ba3f9ce3 100644
@@ -497,18 +497,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
-		rxc-skew-ps = <900>;
-		rxdv-skew-ps = <0>;
-		rxd0-skew-ps = <0>;
-		rxd1-skew-ps = <0>;
-		rxd2-skew-ps = <0>;
-		rxd3-skew-ps = <0>;
-		txc-skew-ps = <900>;
-		txen-skew-ps = <0>;
-		txd0-skew-ps = <0>;
-		txd1-skew-ps = <0>;
-		txd2-skew-ps = <0>;
-		txd3-skew-ps = <0>;
+		rxc-skew-ps = <1500>;
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#3 lore raw

PATCH 3/5 arm64: dts: h3ulcb: Fix EthernetAVB PHY timing

In reply to Simon Horman

From: Vladimir Barinov <[email protected]>

Set PHY rxc-skew-ps to 1500 and all other values to their default values.

This is intended to to address failures in the case of 1Gbps communication using the by h3ulcb board with the KSZ9031RNX phy.

---
v1 [Simon Horman]
* Do not set values to defaults, omit them and let the driver set the defaults
* Rewrote changelog

N.B. I have not tested this patch as I do not have access to an h3ulcb

v0 [Vladimir Barinov]

---
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts +1 -12
index c5f8f69a4f5f..baaa9330cfab 100644
@@ -339,18 +339,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
-		rxc-skew-ps = <900>;
-		rxdv-skew-ps = <0>;
-		rxd0-skew-ps = <0>;
-		rxd1-skew-ps = <0>;
-		rxd2-skew-ps = <0>;
-		rxd3-skew-ps = <0>;
-		txc-skew-ps = <900>;
-		txen-skew-ps = <0>;
-		txd0-skew-ps = <0>;
-		txd1-skew-ps = <0>;
-		txd2-skew-ps = <0>;
-		txd3-skew-ps = <0>;
+		rxc-skew-ps = <1500>;
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#4 lore raw

PATCH 4/5 arm64: dts: r8a7796: Use rgmii-txid phy-mode for EthernetAVB

In reply to Simon Horman

From: Kazuya Mizuguchi <[email protected]>

Since commit 61fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR") the EthernetAVB driver enables tx and rx clock internal delay modes (TDM and RDM) depending on the phy mode as follows:

phy mode | ASPR delay mode
-----------+----------------
rgmii-id | TDM and RDM
rgmii-rxid | RDM
rgmii-txid | TDM

And prior to the above commit no internal delay mode settings were implemented for any phy mode.

With this and the above change present tx internal delay mode is enabled which has been observed to address failures in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the r8a7795 (H3) and r8a7796 (M3-W) SoCs.

With the above patch present but this patch present tx and rx internal delay modes are enabled; and with the above patch and this present absent no internal delay modes are enabled. In both cases failures have been observed when using 1Gbps communication in the environments described above.

---

[v1] Simon Horman
- Rewrote changelog

N.B. The communications faulres have been reported by the BSP team,
however I did not observe them during testing with a salvator-x/M3-W-ES1.0

My test-case was to bring up the system using NFS root and
run: netperf -H <HOST>

[v0] Kazuya Mizuguchi

---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/renesas/r8a7796.dtsi +1 -1
index c95ad177b097..1c1c1eae9cba 100644
@@ -483,7 +483,7 @@
 					  "ch24";
 			clocks = <&cpg CPG_MOD 812>;
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
-			phy-mode = "rgmii-id";
+			phy-mode = "rgmii-txid";
 			#address-cells = <1>;
 			#size-cells = <0>;
 			status = "disabled";
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#5 lore raw

PATCH 5/5 arm64: dts: r8a7796: salvator-x: Fix EthernetAVB PHY timing

In reply to Simon Horman

From: Kazuya Mizuguchi <[email protected]>

Set PHY rxc-skew-ps to 1500 and all other values to their default values.

This is intended to to address failures in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the r8a7795 (H3) and r8a7796 (M3-W) SoCs.

---
v1 [Simon Horman]
* Do not set values to defaults, omit them and let the driver set the defaults
* Rewrote changelog

N.B. The communications failures have been reported by the BSP team,
however I did not observe them during testing with a salvator-x/M3-W-ES1.0

My test-case was to bring up the system using NFS root and
run: netperf -H <HOST>

v0 [Kazuya Mizuguchi]

---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts +1 -12
index 61f4662db497..93ed23ab71bb 100644
@@ -172,18 +172,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
-		rxc-skew-ps = <900>;
-		rxdv-skew-ps = <0>;
-		rxd0-skew-ps = <0>;
-		rxd1-skew-ps = <0>;
-		rxd2-skew-ps = <0>;
-		rxd3-skew-ps = <0>;
-		txc-skew-ps = <900>;
-		txen-skew-ps = <0>;
-		txd0-skew-ps = <0>;
-		txd1-skew-ps = <0>;
-		txd2-skew-ps = <0>;
-		txd3-skew-ps = <0>;
+		rxc-skew-ps = <1500>;
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.7.0.rc3.207.g0ac5344
#6 lore raw

cover arm64: dts: r8a779[56]: EtherAVB Gigabit timing enhancements

In reply to Simon Horman
Quoted 9 lines · Simon Horman

Hi,

this series tweaks PHY settings to address communications failures reported for 1Gbit communication using EtherAVB. Gigabit is supported for R-Car H3 ES1.1+ and M3-W as of commit 0e98f9d5f0b4 ("ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W") which is present in net-next and should be included in v4.11.

This series is based on renesas-devel-20170130-v4.10-rc6

I have queued up this series for v4.12.