Fix nfs-mountd dependency on rpcbind
Subsystems (2)
PATCH 1/1 Fix nfs-mountd dependency on rpcbind
Following commit 91da135f - it replaced "rpcbind.target" by "rpcbind.socket" in some unit files - "rpcbind.socket" should also be added to "nfs-mountd.service" as a dependency to avoid race conditions.
Usually "rpcbind.socket" is either started as a "sockets.target" dependency, or as a dependency for "nfs-server.service", when unit files include it in "BindsTo" or "After". Unfortunately there is a possilibility to have "nfs-mountd.service" started when the rpcbind socket is not yet created:
systemd[1]: Starting NFS Mount Daemon...
systemd[1]: nfs-mountd.service: Control process exited, code=exited status=1 systemd[1]: Failed to start NFS Mount Daemon.
systemd[1]: nfs-mountd.service: Unit entered failed state. systemd[1]: nfs-mountd.service: Failed with result 'exit-code'.
Nowadays "nfs-mountd.service" uses "BindTo" directive to "nfs-server.service". That, per se, doesn't guarantee ordering for NFS server to start rpcbind and for nfs-mountd to depend on it.
https://bugs.launchpad.net/bugs/1590799
--- systemd/nfs-mountd.service | 1 + 1 file changed, 1 insertion(+)
systemd/nfs-mountd.service +1 -0
@@ -4,6 +4,7 @@ DefaultDependencies=no Requires=proc-fs-nfsd.mount After=proc-fs-nfsd.mount After=network.target local-fs.target +After=rpcbind.socket BindsTo=nfs-server.service [Service]
Signature · 1 line
2.9.3
Quoted 15 lines · Rafael David Tinoco
Following commit
91da135f- it replaced "rpcbind.target" by "rpcbind.socket" in some unit files - "rpcbind.socket" should also be added to "nfs-mountd.service" as a dependency to avoid race conditions.Usually "rpcbind.socket" is either started as a "sockets.target" dependency, or as a dependency for "nfs-server.service", when unit files include it in "BindsTo" or "After". Unfortunately there is a possilibility to have "nfs-mountd.service" started when the rpcbind socket is not yet created:
systemd[1]: Starting NFS Mount Daemon...
systemd[1]: nfs-mountd.service: Control process exited, code=exited status=1 systemd[1]: Failed to start NFS Mount Daemon.
systemd[1]: nfs-mountd.service: Unit entered failed state. systemd[1]: nfs-mountd.service: Failed with result 'exit-code'.
Quoted 7 lines
Nowadays "nfs-mountd.service" uses "BindTo" directive to "nfs-server.service". That, per se, doesn't guarantee ordering for NFS server to start rpcbind and for nfs-mountd to depend on it.
https://bugs.launchpad.net/bugs/1590799
Signed-off-by Rafael David Tinoco <[email protected]>
Thanks for finding this!
I would not be against adding
Wants=rpcbind.socket
but as you say, it isn't strictly needed.
Thanks,
NeilBrown
Quoted 18 lines
--- systemd/nfs-mountd.service | 1 + 1 file changed, 1 insertion(+)systemd/nfs-mountd.service +1
-0@@ -4,6 +4,7 @@ DefaultDependencies=no Requires=proc-fs-nfsd.mount After=proc-fs-nfsd.mount After=network.target local-fs.target +After=rpcbind.socket BindsTo=nfs-server.service [Service]Signature · 1 line
2.9.3
Quoted 15 lines · Rafael David Tinoco
Following commit
91da135f- it replaced "rpcbind.target" by "rpcbind.socket" in some unit files - "rpcbind.socket" should also be added to "nfs-mountd.service" as a dependency to avoid race conditions.Usually "rpcbind.socket" is either started as a "sockets.target" dependency, or as a dependency for "nfs-server.service", when unit files include it in "BindsTo" or "After". Unfortunately there is a possilibility to have "nfs-mountd.service" started when the rpcbind socket is not yet created:
systemd[1]: Starting NFS Mount Daemon...
systemd[1]: nfs-mountd.service: Control process exited, code=exited status=1 systemd[1]: Failed to start NFS Mount Daemon.
systemd[1]: nfs-mountd.service: Unit entered failed state. systemd[1]: nfs-mountd.service: Failed with result 'exit-code'.
Quoted 7 lines
Nowadays "nfs-mountd.service" uses "BindTo" directive to "nfs-server.service". That, per se, doesn't guarantee ordering for NFS server to start rpcbind and for nfs-mountd to depend on it.
https://bugs.launchpad.net/bugs/1590799
Signed-off-by Rafael David Tinoco <[email protected]>
Committed
steved.
Quoted 16 lines
--- systemd/nfs-mountd.service | 1 + 1 file changed, 1 insertion(+)systemd/nfs-mountd.service +1
-0@@ -4,6 +4,7 @@ DefaultDependencies=no Requires=proc-fs-nfsd.mount After=proc-fs-nfsd.mount After=network.target local-fs.target +After=rpcbind.socket BindsTo=nfs-server.service [Service]