net: dsa: Do not destroy invalid network devices
Subsystems (3)
PATCH 1/1 net: dsa: Do not destroy invalid network devices
dsa_slave_create() can fail, and dsa_user_port_unapply() will properly check for the network device not being NULL before attempting to destroy it. We were not setting the slave network device as NULL if dsa_slave_create() failed, so we would later on be calling dsa_slave_destroy() on a now free'd and unitialized network device, causing crashes in dsa_slave_destroy().
--- net/dsa/dsa2.c | 1 + 1 file changed, 1 insertion(+)
net/dsa/dsa2.c +1 -0
@@ -271,6 +271,7 @@ static int dsa_user_port_apply(struct dsa_port *port, u32 index,if (err) {dev_warn (ds->dev,"Failed to create slave %d: %d\n" , index, err); + ds->ports[index].netdev =NULL ;return err; }
Signature · 1 line
2.9.3
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Tue, 7 Feb 2017 23:10:13 -0800
Quoted 8 lines
dsa_slave_create()can fail, anddsa_user_port_unapply()will properly check for the network device not being NULL before attempting to destroy it. We were not setting the slave network device as NULL ifdsa_slave_create()failed, so we would later on be callingdsa_slave_destroy()on a now free'd and unitialized network device, causing crashes indsa_slave_destroy().Fixes 83c0afaec7b7 ("net: dsa: Add new binding implementation")Signed-off-by Florian Fainelli <[email protected]>
Applied and queued up for -stable, thanks.