ARM: DRA7: AM57xx: Enable SPL_DM
Subsystems (3)
cover ARM: DRA7: AM57xx: Enable SPL_DM
- Enable SPL_DM on all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.
Verified MMC, eMMC boot on DRA74-evm, DRA72-evm.
MMC boot on AM57xx-evm.
Lokesh Vutla (6):
tools: omapimage: Fix size in header
ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL
ARM: dts: AM57xx: Add generic dts for spl
ARM: dts: DRA7: Add generic dts for spl
configs: am57xx_evm: Enable SPL_DM
configs: dra7xx_evm: Enable SPL_DM
arch/arm/dts/Makefile | 3 ++- arch/arm/dts/am57xx-generic-spl.dts | 24 ++++++++++++++++++ arch/arm/dts/dra7-generic-spl.dts | 50 +++++++++++++++++++++++++++++++++++++ arch/arm/mach-omap2/u-boot-spl.lds | 2 ++ configs/am57xx_evm_defconfig | 7 ++++-- configs/am57xx_hs_evm_defconfig | 7 ++++-- configs/dra7xx_evm_defconfig | 7 ++++-- configs/dra7xx_hs_evm_defconfig | 7 ++++-- include/configs/am57xx_evm.h | 5 ---- include/configs/dra7xx_evm.h | 5 ---- include/configs/ti_omap5_common.h | 8 +----- tools/gpimage.c | 2 +- tools/omapimage.c | 2 +- 13 files changed, 101 insertions(+), 28 deletions(-) create mode 100644 arch/arm/dts/am57xx-generic-spl.dts create mode 100644 arch/arm/dts/dra7-generic-spl.dts
Signature · 1 line
2.11.0
PATCH 1/6 tools: omapimage: Fix size in header
The size field in GP header that is expected by ROM is size of the image + size of the header. But omapimage generates a gp header only with size of the image as size field. Fix it
--- tools/gpimage.c | 2 +- tools/omapimage.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tools/gpimage.c +1 -1
@@ -54,7 +54,7 @@ static void gpimage_set_header(void *ptr, struct stat *sbuf, int ifd, {struct gp_header *gph = (struct gp_header *)ptr; -gph_set_header (gph, sbuf->st_size -GPIMAGE_HDR_SIZE , params->addr,1 ); +gph_set_header (gph, sbuf->st_size, params->addr,1 ); }/*
tools/omapimage.c +1 -1
@@ -143,7 +143,7 @@ static void omapimage_set_header(void *ptr, struct stat *sbuf, int ifd, toc++;memset (toc,0xff ,sizeof (*toc)); -gph_set_header (gph, sbuf->st_size -OMAP_FILE_HDR_SIZE , +gph_set_header (gph, sbuf->st_size -OMAP_CH_HDR_SIZE , params->addr,0 );if (strncmp (params->imagename,"byteswap" ,8 ) ==0 ) {
Signature · 1 line
2.11.0
PATCH 1/6 tools: omapimage: Fix size in header
Quoted 5 lines · Lokesh Vutla
The size field in GP header that is expected by ROM is size of the image + size of the header. But omapimage generates a gp header only with size of the image as size field. Fix it
Signed-off-by Lokesh Vutla <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/96e58651/attachment.sig>
PATCH 2/6 ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL
In reply to Lokesh VutlaTo make SPL_OF_CONTROL work on OAP2+ SoCs, _image_binary_end must be defined in the linker script along with CONFIG_SPL_SEPARATE_BSS.
--- arch/arm/mach-omap2/u-boot-spl.lds | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/mach-omap2/u-boot-spl.lds +2 -0
@@ -46,6 +46,8 @@ SECTIONS *(.__end) } + _image_binary_end = .; + .bss : { . = ALIGN(4);
Signature · 1 line
2.11.0
PATCH 2/6 ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL
Quoted 4 lines · Lokesh Vutla
To make
SPL_OF_CONTROLwork on OAP2+ SoCs,_image_binary_endmust be defined in the linker script along withCONFIG_SPL_SEPARATE_BSS.Signed-off-by Lokesh Vutla <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/7856ee5d/attachment.sig>
PATCH 2/6 ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL
In reply to Lokesh VutlaQuoted 1 line · Lokesh Vutla
To make
SPL_OF_CONTROLwork on OAP2+ SoCs,_image_binary_endmust be
OMAP2+ ---> ^^^^^
Just a nitpick, but helps grepping for changes in git log.
Thank you,
ladis
Quoted 27 lines
defined in the linker script along with
CONFIG_SPL_SEPARATE_BSS.Signed-off-by Lokesh Vutla <[email protected]>--- arch/arm/mach-omap2/u-boot-spl.lds | 2 ++ 1 file changed, 2 insertions(+)arch/arm/mach-omap2/u-boot-spl.lds +2
-0@@ -46,6 +46,8 @@ SECTIONS *(.__end) } + _image_binary_end = .; + .bss : { . = ALIGN(4);Signature · 6 lines
2.11.0 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
PATCH 2/6 ARM: OMAP2+: define _image_binary_end to fix SPL_OF_CONTROL
Quoted 5 lines · Ladislav Michl
Quoted 1 line · Lokesh Vutla
To make
SPL_OF_CONTROLwork on OAP2+ SoCs,_image_binary_endmust beOMAP2+ ---> ^^^^^Just a nitpick, but helps grepping for changes in git log.
Oops. Updated version just posted.
Thanks and regards,
Lokesh
PATCH 3/6 ARM: dts: AM57xx: Add generic dts for spl
In reply to Lokesh VutlaAdd a generic dts file for spl that is used by all AM57xx based platforms.
--- arch/arm/dts/Makefile | 1 + arch/arm/dts/am57xx-generic-spl.dts | 24 ++++++++++++++++++++++++ configs/am57xx_evm_defconfig | 2 +- configs/am57xx_hs_evm_defconfig | 2 +- 4 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/am57xx-generic-spl.dts
arch/arm/dts/Makefile +1 -0
@@ -153,6 +153,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \ dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb \ dra72-evm-revc.dtb dra71-evm.dtb dtb-$(CONFIG_TARGET_AM57XX_EVM) += am57xx-beagle-x15.dtb \ + am57xx-generic-spl.dtb \ am57xx-beagle-x15-revb1.dtb \ am572x-idk.dtb \ am571x-idk.dtb
arch/arm/dts/am57xx-generic-spl.dts new file +24 -0
@@ -0,0 +1,24 @@ +/* + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * Based on "omap4.dtsi" + */ + +#include "am57xx-beagle-x15.dts" + +/{ + ocp { + u-boot,dm-pre-reloc; + }; +}; + +&uart3 { + u-boot,dm-pre-reloc; +}; + +&mmc1 { + u-boot,dm-pre-reloc; +};
configs/am57xx_evm_defconfig +1 -1
@@ -6,7 +6,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y CONFIG_SPL_SPI_SUPPORT=y CONFIG_ARMV7_LPAE=y CONFIG_SPL_STACK_R_ADDR=0x82000000 -CONFIG_DEFAULT_DEVICE_TREE="am57xx-beagle-x15" +CONFIG_DEFAULT_DEVICE_TREE="am57xx-generic-spl" CONFIG_FIT=y CONFIG_SPL_LOAD_FIT=y CONFIG_OF_BOARD_SETUP=y
configs/am57xx_hs_evm_defconfig +1 -1
@@ -9,7 +9,7 @@ CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000 CONFIG_SPL_SPI_FLASH_SUPPORT=y CONFIG_SPL_SPI_SUPPORT=y CONFIG_SPL_STACK_R_ADDR=0x82000000 -CONFIG_DEFAULT_DEVICE_TREE="am57xx-beagle-x15" +CONFIG_DEFAULT_DEVICE_TREE="am57xx-generic-spl" CONFIG_FIT=y CONFIG_FIT_IMAGE_POST_PROCESS=y CONFIG_SPL_LOAD_FIT=y
Signature · 1 line
2.11.0
PATCH 3/6 ARM: dts: AM57xx: Add generic dts for spl
Quoted 11 lines · Lokesh Vutla
Add a generic dts file for spl that is used by all AM57xx based platforms.
Signed-off-by Lokesh Vutla <[email protected]>--- arch/arm/dts/Makefile | 1 + arch/arm/dts/am57xx-generic-spl.dts | 24 ++++++++++++++++++++++++ configs/am57xx_evm_defconfig | 2 +- configs/am57xx_hs_evm_defconfig | 2 +- 4 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/am57xx-generic-spl.dts
I wonder if we shouldn't instead make use of the "-u-boot.dtsi" wildcard rules in scripts/Makefile.lib and have this say be omap5-u-boot.dtsi and be automatically included on all of the am57xx/dra7xx DTS files.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/e54de05c/attachment.sig>
PATCH 3/6 ARM: dts: AM57xx: Add generic dts for spl
Quoted 14 lines · Tom Rini
Quoted 11 lines · Lokesh Vutla
Add a generic dts file for spl that is used by all AM57xx based platforms.
Signed-off-by Lokesh Vutla <[email protected]>--- arch/arm/dts/Makefile | 1 + arch/arm/dts/am57xx-generic-spl.dts | 24 ++++++++++++++++++++++++ configs/am57xx_evm_defconfig | 2 +- configs/am57xx_hs_evm_defconfig | 2 +- 4 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 arch/arm/dts/am57xx-generic-spl.dts
Quoted 3 lines
I wonder if we shouldn't instead make use of the "
-u-boot.dtsi" wildcard rules inscripts/Makefile.liband have this say beomap5-u-boot.dtsiand be automatically included on all of the am57xx/dra7xx DTS files.
Nice one. I did not know this. Just posted updated series using omap5-u-boot.dtsi
Thanks and regards,
Lokesh
PATCH 4/6 ARM: dts: DRA7: Add generic dts for spl
In reply to Lokesh VutlaAdd a generic dts file for spl that is used by all DRA7 based platforms.
--- arch/arm/dts/Makefile | 2 +- arch/arm/dts/dra7-generic-spl.dts | 50 +++++++++++++++++++++++++++++++++++++++ configs/dra7xx_evm_defconfig | 2 +- configs/dra7xx_hs_evm_defconfig | 2 +- 4 files changed, 53 insertions(+), 3 deletions(-) create mode 100644 arch/arm/dts/dra7-generic-spl.dts
arch/arm/dts/Makefile +1 -1
@@ -151,7 +151,7 @@ dtb-$(CONFIG_ARCH_SOCFPGA) += \ socfpga_cyclone5_vining_fpga.dtb dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb \ - dra72-evm-revc.dtb dra71-evm.dtb + dra72-evm-revc.dtb dra71-evm.dtb dra7-generic-spl.dtb dtb-$(CONFIG_TARGET_AM57XX_EVM) += am57xx-beagle-x15.dtb \ am57xx-generic-spl.dtb \ am57xx-beagle-x15-revb1.dtb \
arch/arm/dts/dra7-generic-spl.dts new file +50 -0
50 lines not on this page · raw message
configs/dra7xx_evm_defconfig +1 -1
@@ -6,7 +6,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT=y CONFIG_SPL_SPI_SUPPORT=y CONFIG_ARMV7_LPAE=y CONFIG_SPL_STACK_R_ADDR=0x82000000 -CONFIG_DEFAULT_DEVICE_TREE="dra7-evm" +CONFIG_DEFAULT_DEVICE_TREE="dra7-generic-spl" CONFIG_FIT=y CONFIG_SPL_LOAD_FIT=y CONFIG_OF_BOARD_SETUP=y
configs/dra7xx_hs_evm_defconfig +1 -1
@@ -10,7 +10,7 @@ CONFIG_TI_SECURE_EMIF_PROTECTED_REGION_SIZE=0x01c00000 CONFIG_SPL_SPI_FLASH_SUPPORT=y CONFIG_SPL_SPI_SUPPORT=y CONFIG_SPL_STACK_R_ADDR=0x82000000 -CONFIG_DEFAULT_DEVICE_TREE="dra7-evm" +CONFIG_DEFAULT_DEVICE_TREE="dra7-generic-spl" CONFIG_FIT=y CONFIG_FIT_IMAGE_POST_PROCESS=y CONFIG_SPL_LOAD_FIT=y
Signature · 1 line
2.11.0
PATCH 5/6 configs: am57xx_evm: Enable SPL_DM
In reply to Lokesh VutlaEnable SPL_DM on all AM57xx based platforms.
--- configs/am57xx_evm_defconfig | 5 ++++- configs/am57xx_hs_evm_defconfig | 5 ++++- include/configs/am57xx_evm.h | 5 ----- 3 files changed, 8 insertions(+), 7 deletions(-)
configs/am57xx_evm_defconfig +4 -1
@@ -14,7 +14,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_SPL_OS_BOOT=y CONFIG_HUSH_PARSER=y
@@ -52,8 +54,10 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1 am572x-idk am571x-idk" CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
@@ -87,4 +91,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y
configs/am57xx_hs_evm_defconfig +4 -1
@@ -19,7 +19,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_HUSH_PARSER=y CONFIG_FASTBOOT=y
@@ -55,7 +57,9 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
@@ -85,4 +89,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y
include/configs/am57xx_evm.h +0 -5
@@ -121,11 +121,6 @@#define CONFIG_SYS_SPI_ARGS_OFFS 0x140000#define CONFIG_SYS_SPI_ARGS_SIZE 0x80000 -#ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_SPI -#undef CONFIG_DM_SPI_FLASH -#endif -/* SPI SPL */ #define CONFIG_TI_EDMA3 #define CONFIG_SPL_SPI_LOAD
Signature · 1 line
2.11.0
PATCH 6/6 configs: dra7xx_evm: Enable SPL_DM
In reply to Lokesh VutlaEnable SPL_DM on all DRA7 based platforms.
--- configs/dra7xx_evm_defconfig | 5 ++++- configs/dra7xx_hs_evm_defconfig | 5 ++++- include/configs/dra7xx_evm.h | 5 ----- include/configs/ti_omap5_common.h | 8 +------- 4 files changed, 9 insertions(+), 14 deletions(-)
configs/dra7xx_evm_defconfig +4 -1
@@ -14,7 +14,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_SPL_OS_BOOT=y CONFIG_HUSH_PARSER=y
@@ -52,8 +54,10 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm" CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
@@ -96,4 +100,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y
configs/dra7xx_hs_evm_defconfig +4 -1
@@ -20,7 +20,9 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL=y +CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_STACK_R=y +CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_DMA_SUPPORT=y CONFIG_HUSH_PARSER=y CONFIG_FASTBOOT=y
@@ -57,8 +59,10 @@ CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_ISO_PARTITION=y CONFIG_OF_CONTROL=y +CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIST="dra7-evm dra72-evm dra72-evm-revc dra71-evm" CONFIG_DM=y +CONFIG_SPL_DM=y # CONFIG_BLK is not set CONFIG_DFU_MMC=y CONFIG_DFU_RAM=y
@@ -101,4 +105,3 @@ CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_G_DNL_MANUFACTURER="Texas Instruments" CONFIG_G_DNL_VENDOR_NUM=0x0451 CONFIG_G_DNL_PRODUCT_NUM=0xd022 -CONFIG_SPL_OF_LIBFDT=y
include/configs/dra7xx_evm.h +0 -5
@@ -123,11 +123,6 @@#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0#define CONFIG_QSPI_QUAD_SUPPORT -#ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_SPI -#undef CONFIG_DM_SPI_FLASH -#endif -/* * Default to using SPI for environment, etc. * 0x000000 - 0x040000 : QSPI.SPL (256KiB)
include/configs/ti_omap5_common.h +1 -7
@@ -45,7 +45,7 @@* Hardware drivers */ #define CONFIG_SYS_NS16550_CLK 48000000 -#if defined(CONFIG_SPL_BUILD ) || !defined(CONFIG_DM_SERIAL ) +#if !defined(CONFIG_DM_SERIAL )#define CONFIG_SYS_NS16550_SERIAL #define CONFIG_SYS_NS16550_REG_SIZE (-4)#endif
@@ -163,14 +163,8 @@#define CONFIG_SPL_NAND_AM33XX_BCH /* ELM support */ #endif -/* -* Disable MMC DM for SPL build and can be re-enabled after adding -* DM support in SPL -*/ #ifdef CONFIG_SPL_BUILD -#undef CONFIG_DM_MMC#undef CONFIG_TIMER -#undef CONFIG_DM_ETH#endif #endif /* __CONFIG_TI_OMAP5_COMMON_H */
Signature · 1 line
2.11.0
cover ARM: DRA7: AM57xx: Enable SPL_DM
In reply to Lokesh VutlaQuoted 3 lines · Lokesh Vutla
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.
That's not a bad size growth, esp here where we can afford it. Did you experiment with going the board-data way? Also it looks like we're going the same DT for U-Boot proper now, will this work long term? Or do you need to switch to having U-Boot itself be loaded from a FIT image and given the correct board dtb? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/7b7d4abc/attachment.sig>
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 7 lines · Tom Rini
Quoted 3 lines · Lokesh Vutla
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Yeah, but I am worried about this size on am335x.
Quoted 1 line
experiment with going the board-data way? Also it looks like we're
hmm.. IIUC, board-data is duplication of same data that is available in DT. Anyways all the unsed nodes in DT are removed for SPL case. So, I used this approach.
Quoted 3 lines
going the same DT for U-Boot proper now, will this work long term? Or do you need to switch to having U-Boot itself be loaded from a FIT image and given the correct board dtb? Thanks!
The DT that is being introduced in this series will be used only by SPL. For U-Boot proper, a FIT image will be built using OF_LIST. I don't think we need to switch.
Thanks and regards,
Lokesh
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 5 lines · Lokesh Vutla
Quoted 2 lines · Tom Rini
On Wed, Feb 08, 2017 at 06:03:31PM +0530, Lokesh Vutla wrote:
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Yeah, but I am worried about this size on am335x.
Agreed, at least wrt HS platforms as well.
Quoted 6 lines
Quoted 2 lines
experiment with going the board-data way? Also it looks like we're
hmm.. IIUC, board-data is duplication of same data that is available in DT. Anyways all the unsed nodes in DT are removed for SPL case. So, I used this approach.
My understanding was that going this way (ala rockchip) does save space. We may also need to start saying that gcc-6 is required on these platforms in order to take advantage of having all of the unused strings really be discarded from the final binary.
Quoted 7 lines
Quoted 3 lines
going the same DT for U-Boot proper now, will this work long term? Or do you need to switch to having U-Boot itself be loaded from a FIT image and given the correct board dtb? Thanks!
The DT that is being introduced in this series will be used only by SPL. For U-Boot proper, a FIT image will be built using
OF_LIST. I don't think we need to switch.
Ah, I missed that already being set, sorry.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/374656a0/attachment.sig>
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 19 lines · Tom Rini
Quoted 5 lines · Lokesh Vutla
Quoted 2 lines · Tom Rini
On Wed, Feb 08, 2017 at 06:03:31PM +0530, Lokesh Vutla wrote:
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Yeah, but I am worried about this size on am335x.
Agreed, at least wrt HS platforms as well.
Quoted 3 lines
Quoted 2 lines
experiment with going the board-data way? Also it looks like we're
Quoted 8 lines
Quoted 3 lines
hmm.. IIUC, board-data is duplication of same data that is available in DT. Anyways all the unsed nodes in DT are removed for SPL case. So, I used this approach.
My understanding was that going this way (ala rockchip) does save space. We may also need to start saying that gcc-6 is required on these platforms in order to take advantage of having all of the unused strings really be discarded from the final binary.
Okay, Ill try this for am335x. I guess the current approach is fine for DRA7 and AM57?
Thanks and regards,
Lokesh
Quoted 11 lines
Quoted 8 lines
Quoted 4 lines
going the same DT for U-Boot proper now, will this work long term? Or do you need to switch to having U-Boot itself be loaded from a FIT image and given the correct board dtb? Thanks!
The DT that is being introduced in this series will be used only by SPL. For U-Boot proper, a FIT image will be built using
OF_LIST. I don't think we need to switch.Ah, I missed that already being set, sorry.
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 26 lines · Lokesh Vutla
Quoted 23 lines · Tom Rini
Quoted 5 lines · Lokesh Vutla
Quoted 2 lines · Tom Rini
On Wed, Feb 08, 2017 at 06:03:31PM +0530, Lokesh Vutla wrote:
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Yeah, but I am worried about this size on am335x.
Agreed, at least wrt HS platforms as well.
Quoted 6 lines
Quoted 2 lines
experiment with going the board-data way? Also it looks like we're
hmm.. IIUC, board-data is duplication of same data that is available in DT. Anyways all the unsed nodes in DT are removed for SPL case. So, I used this approach.
Quoted 7 lines
Quoted 4 lines
My understanding was that going this way (ala rockchip) does save space. We may also need to start saying that gcc-6 is required on these platforms in order to take advantage of having all of the unused strings really be discarded from the final binary.
Okay, Ill try this for am335x. I guess the current approach is fine for DRA7 and AM57?
Yes, this is fine for DRA7/AM57.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/bc361890/attachment.sig>
cover ARM: DRA7: AM57xx: Enable SPL_DM
In reply to Lokesh VutlaQuoted 5 lines · Lokesh Vutla
Quoted 2 lines · Tom Rini
On Wed, Feb 08, 2017 at 06:03:31PM +0530, Lokesh Vutla wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Yeah, but I am worried about this size on am335x.
I am also, I'm working to save about 30 bytes right now to include another boot mode into HS SPL, +7Kb will simply not work. It looks like you also get some of your saving from enabling simple_malloc, this is already enabled for AM335x-HS, so the size increase will likely be greater on the platform that needs it the most :(
Quoted 6 lines
Quoted 1 line
experiment with going the board-data way? Also it looks like we're
hmm.. IIUC, board-data is duplication of same data that is available in DT. Anyways all the unsed nodes in DT are removed for SPL case. So, I used this approach.
It is a duplication, but it will save us having to append and maintain yet another dts file. If the info is static across the platform, we don't gain anything by encoding it in DT. Plus we can drop the SPL_OF_CONTROL and save some space.
Andrew
Quoted 15 lines
Quoted 3 lines
going the same DT for U-Boot proper now, will this work long term? Or do you need to switch to having U-Boot itself be loaded from a FIT image and given the correct board dtb? Thanks!
The DT that is being introduced in this series will be used only by SPL. For U-Boot proper, a FIT image will be built using
OF_LIST. I don't think we need to switch.Thanks and regards,
Lokesh
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 12 lines · Andrew F. Davis
Quoted 11 lines · Lokesh Vutla
Quoted 7 lines · Tom Rini
Quoted 3 lines · Lokesh Vutla
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Quoted 8 lines
Quoted 2 lines
Yeah, but I am worried about this size on am335x.
I am also, I'm working to save about 30 bytes right now to include another boot mode into HS SPL, +7Kb will simply not work. It looks like you also get some of your saving from enabling
simple_malloc, this is already enabled for AM335x-HS, so the size increase will likely be greater on the platform that needs it the most :(
I know I said it only the other day but switching from gcc-4.x/5.x to 6.x saves a bunch of space, even on am335x hs. I guess my request is that you pick up a gcc-6.x (Debian/unstable, Fedora 25 or I assume Linaro) compiler for ARM and see converting am335x HS to SPL_DT is anywhere close to fitting in the constraint.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/c2f60f95/attachment.sig>
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 22 lines · Tom Rini
Quoted 12 lines · Andrew F. Davis
Quoted 11 lines · Lokesh Vutla
Quoted 7 lines · Tom Rini
Quoted 3 lines · Lokesh Vutla
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Quoted 8 lines
Quoted 2 lines
Yeah, but I am worried about this size on am335x.
I am also, I'm working to save about 30 bytes right now to include another boot mode into HS SPL, +7Kb will simply not work. It looks like you also get some of your saving from enabling
simple_malloc, this is already enabled for AM335x-HS, so the size increase will likely be greater on the platform that needs it the most :(
Quoted 6 lines
I know I said it only the other day but switching from gcc-4.x/5.x to 6.x saves a bunch of space, even on am335x hs. I guess my request is that you pick up a gcc-6.x (Debian/unstable, Fedora 25 or I assume Linaro) compiler for ARM and see converting am335x HS to
SPL_DTis anywhere close to fitting in the constraint.
I'm already using Linaro's gcc-6.x, I don't believe SPL fits anymore using the old compilers as it stands today.
Andrew
cover ARM: DRA7: AM57xx: Enable SPL_DM
Quoted 30 lines · Andrew F. Davis
Quoted 22 lines · Tom Rini
Quoted 12 lines · Andrew F. Davis
Quoted 11 lines · Lokesh Vutla
Quoted 7 lines · Tom Rini
Quoted 3 lines · Lokesh Vutla
- Enable
SPL_DMon all DRA7 and AM57xx based platforms.
- SPL uses a generic dts on all platforms with same defconfig.
- After this series SPL size is increased by ~7KB.That's not a bad size growth, esp here where we can afford it. Did you
Quoted 8 lines
Quoted 2 lines
Yeah, but I am worried about this size on am335x.
I am also, I'm working to save about 30 bytes right now to include another boot mode into HS SPL, +7Kb will simply not work. It looks like you also get some of your saving from enabling
simple_malloc, this is already enabled for AM335x-HS, so the size increase will likely be greater on the platform that needs it the most :(Quoted 6 lines
I know I said it only the other day but switching from gcc-4.x/5.x to 6.x saves a bunch of space, even on am335x hs. I guess my request is that you pick up a gcc-6.x (Debian/unstable, Fedora 25 or I assume Linaro) compiler for ARM and see converting am335x HS to
SPL_DTis anywhere close to fitting in the constraint.
Quoted 2 lines
I'm already using Linaro's gcc-6.x, I don't believe SPL fits anymore using the old compilers as it stands today.
You're enforcing the max size constraint today via the appropriate config option, right?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170208/78859963/attachment.sig>