smiapp: add CCP2 support

Add support for CCP2 connected SMIA sensors as found on the Nokia N900.

Signed-off-by Sebastian Reichel <[email protected]>

Signed-off-by Ivaylo Dimitrov <[email protected]>

Signed-off-by Pavel Machek <[email protected]>

drivers/media/i2c/smiapp/smiapp-core.c +1 -0

index 44f8c7e..c217bc6 100644
@@ -2997,13 +2997,19 @@ static struct smiapp_hwconfig *smiapp_get_hwconfig(struct device *dev)
 	switch (bus_cfg->bus_type) {
 	case V4L2_MBUS_CSI2:
 		hwcfg->csi_signalling_mode = SMIAPP_CSI_SIGNALLING_MODE_CSI2;
+		hwcfg->lanes = bus_cfg->bus.mipi_csi2.num_data_lanes;

drivers/media/i2c/smiapp/smiapp-core.c +2 -3

 		goto out_err;
 	}
 
-	hwcfg->lanes = bus_cfg->bus.mipi_csi2.num_data_lanes;
 	dev_dbg(dev, "lanes %u\n", hwcfg->lanes);
 
 	/* NVM size is not mandatory */

@@ -3017,8 +3023,8 @@ static struct smiapp_hwconfig *smiapp_get_hwconfig(struct device *dev)
 		goto out_err;
 	}
 
-	dev_dbg(dev, "nvm %d, clk %d, csi %d\n", hwcfg->nvm_size,
-		hwcfg->ext_clk, hwcfg->csi_signalling_mode);
+	dev_dbg(dev, "nvm %d, clk %d, mode %d\n",
+		hwcfg->nvm_size, hwcfg->ext_clk, hwcfg->csi_signalling_mode);
 
 	if (!bus_cfg->nr_of_link_frequencies) {
 		dev_warn(dev, "no link frequencies defined\n");

Besides this patch, what else is needed? The CSI-2 / CCP2 support is missing in V4L2 OF at least. It'd be better to have this all in the same set.

I pushed the two DT patches here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=ccp2>

Hi!

Quoted 3 lines

Besides this patch, what else is needed? The CSI-2 / CCP2 support is missing in V4L2 OF at least. It'd be better to have this all in the same set.

Quite a lot of is needed.

Quoted 3 lines

I pushed the two DT patches here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=ccp2>

Thanks for a branch. If you could the two patches that look ok there, it would mean less work for me, I could just mark those two as applied here.

Core changes for CSI2 support are needed.

There are core changes in notifier locking, and subdev support.

I need video-bus-switch, at least for testing.

I need subdev support for omap3isp, so that we can attach flash and focus devices.

Finally dts support on N900 can be enabled.

Quoted 7 lines

Quoted 3 lines

I pushed the two DT patches here:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=ccp2>

Thanks for a branch. If you could the two patches that look ok there, it would mean less work for me, I could just mark those two as applied here.

I think a verb could be missing from the sentence. :-) I'll send a pull request for the entire set, containing more than just the DT changes. Feel free to base yours on top of this.

A word of warning: I have patches to replace the V4L2 OF framework by V4L2 fwnode. The preliminary set (which is still missing V4L2 OF removal) is here, I'll post a refresh soon:

<URL:http://www.spinics.net/lists/linux-media/msg106160.html>

Let's see what the order ends up to be in the end. If the fwnode set is applicable first, then I'd like to rebase the lane parsing changes on top of that rather than the other way around --- it's easier that way.

Quoted 1 line

Quoted 1 line

Core changes for CSI2 support are needed.

CCP2? We could get these and the smiapp and possibly also the omap3isp patches in first, to avoid having to manage a large patchset. What do you think?

Quoted 7 lines

There are core changes in notifier locking, and subdev support.

I need video-bus-switch, at least for testing.

I need subdev support for omap3isp, so that we can attach flash and focus devices.

Quoted 1 line

Finally dts support on N900 can be enabled.

Yes! 8-)

I don't know if any euros were saved by using that video bus switch but it sure has caused a lot of hassle (and perhaps some gray hair) for software engineers. X-)