drm/vc4: Drop debug print at boot with DPI enabled.
Subsystems (3)
PATCH 1/1 drm/vc4: Drop debug print at boot with DPI enabled.
Unlike the other encoders in the driver, I've also dropped the debug dump function. There's only really one register to this device, and we have the debugfs reg entry still.
--- drivers/gpu/drm/vc4/vc4_dpi.c | 13 ------------- 1 file changed, 13 deletions(-)
drivers/gpu/drm/vc4/vc4_dpi.c +0 -13
@@ -144,17 +144,6 @@ static const struct { DPI_REG(DPI_ID), }; -static void vc4_dpi_dump_regs (struct vc4_dpi *dpi) -{ -int i; - -for (i =0 ; i <ARRAY_SIZE (dpi_regs); i++) { -DRM_INFO ("0x%04x (%s): 0x%08x\n" , - dpi_regs[i].reg, dpi_regs[i].name, -DPI_READ (dpi_regs[i].reg)); - } -} -#ifdef CONFIG_DEBUG_FS int vc4_dpi_debugfs_regs (struct seq_file *m,void *unused) {
@@ -416,8 +405,6 @@ static int vc4_dpi_bind(struct device *dev, struct device *master, void *data)if (IS_ERR (dpi->regs))return PTR_ERR (dpi->regs); -vc4_dpi_dump_regs (dpi); -if (DPI_READ (DPI_ID ) !=DPI_ID_VALUE ) {dev_err (dev,"Port returned 0x%08x for ID instead of 0x%08x\n" ,DPI_READ (DPI_ID ),DPI_ID_VALUE );
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Eric Anholt
Unlike the other encoders in the driver, I've also dropped the debug dump function. There's only really one register to this device, and we have the debugfs reg entry still.
Signed-off-by Eric Anholt <[email protected]>
Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy debug printers, there's drm_printer, which allows you to spam both dmesg and debugfs with the same code. Rob did that, I recently converted drm_mm, it's pretty cool.
Quoted 42 lines
--- drivers/gpu/drm/vc4/vc4_dpi.c | 13 ------------- 1 file changed, 13 deletions(-)drivers/gpu/drm/vc4/vc4_dpi.c +0
-13@@ -144,17 +144,6 @@ static const struct { DPI_REG(DPI_ID), }; -static void vc4_dpi_dump_regs (struct vc4_dpi *dpi) -{ -int i; - -for (i =0 ; i <ARRAY_SIZE (dpi_regs); i++) { -DRM_INFO ("0x%04x (%s): 0x%08x\n" , - dpi_regs[i].reg, dpi_regs[i].name, -DPI_READ (dpi_regs[i].reg)); - } -} -#ifdef CONFIG_DEBUG_FS int vc4_dpi_debugfs_regs (struct seq_file *m,void *unused) {@@ -416,8 +405,6 @@ static int vc4_dpi_bind(struct device *dev, struct device *master, void *data)if (IS_ERR (dpi->regs))return PTR_ERR (dpi->regs); -vc4_dpi_dump_regs (dpi); -if (DPI_READ (DPI_ID ) !=DPI_ID_VALUE ) {dev_err (dev,"Port returned 0x%08x for ID instead of 0x%08x\n" ,DPI_READ (DPI_ID ),DPI_ID_VALUE );Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Eric Anholt
AppliedQuoted 5 lines · Daniel Vetter
Quoted 4 lines · Eric Anholt
Unlike the other encoders in the driver, I've also dropped the debug dump function. There's only really one register to this device, and we have the debugfs reg entry still.
Quoted 8 lines
Quoted 1 line
Signed-off-by Eric Anholt <[email protected]>Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy debug printers, there's
drm_printer, which allows you to spam both dmesg and debugfs with the same code. Rob did that, I recently converteddrm_mm, it's pretty cool.Acked-by Daniel Vetter <[email protected]>
Merged to -next, thanks.
The drm printer stuff looks really promising! I'm also interested, though, in the debugfs_regset32 stuff that lets you just name your regs in a struct and pass it and your regs base address to the helper for creating the debugfs entry. I bet we can mash those two ideas together into something really nice.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel