Skip to contentSkip to conversation

Does anyone have test cases for mount namespaces?

DISCUSSION Theodore Ts'o 3 participants 3 messages Feb 8, 2017 – Feb 9, 2017 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

I'm trying to backport a security fix involving the mount namespaces (in fs/pnode.c), and I'm wondering if anyone has a set of sanity checks (ideally in the form of a shell script) which they use to make sure nothing has broken with respect to mount --make-shared, et. al.

I've really gotten spoiled with xfstests, and the mount namespaces code looks subtle and quick to anger, and I'd prefer to have something more substantial than "It builds! Release it to production!" :-)

Thanks,

- Ted

#1 lore raw

Hi Ted,

Quoted 10 lines · Theodore Ts'o

Hi,

I'm trying to backport a security fix involving the mount namespaces (in fs/pnode.c), and I'm wondering if anyone has a set of sanity checks (ideally in the form of a shell script) which they use to make sure nothing has broken with respect to mount --make-shared, et. al.

I've really gotten spoiled with xfstests, and the mount namespaces code looks subtle and quick to anger, and I'd prefer to have something more substantial than "It builds! Release it to production!" :-)

AFAIK, there's a test script from LTP does some mount namespace function and regression tests, e.g. --bind --make-private --make-shared --move

$LTP_SOURCE/testscripts/test_fs_bind.sh

And Zorro Lang has proposed some mount tests[1] for xfstests last May, but the tests never got reviewed & merged (hope they can be reviewed & committed by this opportunity :).

Thanks,
Eryu

[1] https://www.spinics.net/lists/fstests/msg03029.html

#2 lore raw
Quoted 19 lines · Eryu Guan

Hi Ted,

Quoted 10 lines · Theodore Ts'o

Hi,

I'm trying to backport a security fix involving the mount namespaces (in fs/pnode.c), and I'm wondering if anyone has a set of sanity checks (ideally in the form of a shell script) which they use to make sure nothing has broken with respect to mount --make-shared, et. al.

I've really gotten spoiled with xfstests, and the mount namespaces code looks subtle and quick to anger, and I'd prefer to have something more substantial than "It builds! Release it to production!" :-)

AFAIK, there's a test script from LTP does some mount namespace function and regression tests, e.g. --bind --make-private --make-shared --move

$LTP_SOURCE/testscripts/test_fs_bind.sh

Quoted 8 lines

And Zorro Lang has proposed some mount tests[1] for xfstests last May, but the tests never got reviewed & merged (hope they can be reviewed & committed by this opportunity :).

Thanks,
Eryu

[1] https://www.spinics.net/lists/fstests/msg03029.html

If Ted or someone would like to review these patches, I really appreciate that :)

Thanks,
Zorro