Skip to contentSkip to conversation

package/bluez-tools: new package

PATCH Superseded Bernd Kuhls 3 participants 3 messages Feb 8, 2017 – Feb 9, 2017

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/bluez-tools: new package

---
v2: added comment why autoreconf is needed (Romain)

 DEVELOPERS                           |  1 +
 package/Config.in                    |  1 +
 package/bluez-tools/Config.in        | 19 +++++++++++++++++++
 package/bluez-tools/bluez-tools.hash |  3 +++
 package/bluez-tools/bluez-tools.mk   | 24 ++++++++++++++++++++++++
 5 files changed, 48 insertions(+)
 create mode 100644 package/bluez-tools/Config.in
 create mode 100644 package/bluez-tools/bluez-tools.hash
 create mode 100644 package/bluez-tools/bluez-tools.mk
DEVELOPERS +1 -0
index b8ccb4615..5b4a0b18d 100644
@@ -150,6 +150,7 @@ N:	Bernd Kuhls <[email protected]>
 F:	package/apache/
 F:	package/apr/
 F:	package/apr-util/
+F:	package/bluez-tools/
 F:	package/clamav/
 F:	package/dovecot/
 F:	package/dovecot-pigeonhole/
package/Config.in +1 -0
index e85b23caf..cdf16aba0 100644
@@ -1484,6 +1484,7 @@ menu "Networking applications"
 	source "package/batctl/Config.in"
 	source "package/bcusdk/Config.in"
 	source "package/bind/Config.in"
+	source "package/bluez-tools/Config.in"
 	source "package/bluez_utils/Config.in"
 	source "package/bluez5_utils/Config.in"
 	source "package/bmon/Config.in"
package/bluez-tools/Config.in new file +19 -0
new file mode 100644
index 000000000..5a1b7d041
@@ -0,0 +1,19 @@
+config BR2_PACKAGE_BLUEZ_TOOLS
+	bool "bluez-tools"
+	depends on BR2_PACKAGE_BLUEZ_UTILS || BR2_PACKAGE_BLUEZ5_UTILS
+	depends on BR2_USE_MMU # dbus, libglib2
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_READLINE if BR2_PACKAGE_BLUEZ5_UTILS
+	help
+	  A set of tools to manage bluetooth devices for linux
+
+	  https://github.com/khvzak/bluez-tools
+
+comment "bluez-tools needs a toolchain w/ wchar, threads"
+	depends on BR2_PACKAGE_BLUEZ_UTILS || BR2_PACKAGE_BLUEZ5_UTILS
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/bluez-tools/bluez-tools.hash new file +3 -0
new file mode 100644
index 000000000..214fa5bdf
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 56204ddd1cc7890d60f6a47507755f786fa3ee28f1da370a32ca7d7e0795a953  bluez-tools-171181b6ef6c94aefc828dc7fd8de136b9f97532.tar.gz
+sha256 62ca98af63d2ae142dbc77995c6bd4c259eaba4a5832daa33ae9e3d585b9205f  bluez-tools-97efd293491ad7ec96a655665339908f2478b3d1.tar.gz
package/bluez-tools/bluez-tools.mk new file +24 -0
new file mode 100644
index 000000000..3f441039c
@@ -0,0 +1,24 @@
+################################################################################
+#
+# bluez-tools
+#
+################################################################################
+
+ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y)
+# this is the last version compatible with BlueZ 4 API
+BLUEZ_TOOLS_VERSION = 171181b6ef6c94aefc828dc7fd8de136b9f97532
+else
+BLUEZ_TOOLS_VERSION = 97efd293491ad7ec96a655665339908f2478b3d1
+endif
+BLUEZ_TOOLS_SITE = $(call github,khvzak,bluez-tools,$(BLUEZ_TOOLS_VERSION))
+# sources fetched from github, no configure script)
+BLUEZ_TOOLS_AUTORECONF = YES
+BLUEZ_TOOLS_DEPENDENCIES = host-pkgconf dbus dbus-glib
+
+ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y)
+BLUEZ_TOOLS_DEPENDENCIES += bluez_utils
+else
+BLUEZ_TOOLS_DEPENDENCIES += bluez5_utils readline
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 package/bluez-tools: new package

Hi Bernd,

Quoted 5 lines · Bernd Kuhls

---
v2: added comment why autoreconf is needed (Romain)

 DEVELOPERS                           |  1 +

This change should be in a separate patch.

[snip]

Quoted 18 lines
package/bluez-tools/bluez-tools.mk new file +12 -0
new file mode 100644
index 000000000..3f441039c
@@ -0,0 +1,24 @@
+################################################################################
+#
+# bluez-tools
+#
+################################################################################
+
+ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y)
+# this is the last version compatible with BlueZ 4 API
+BLUEZ_TOOLS_VERSION = 171181b6ef6c94aefc828dc7fd8de136b9f97532
+else
+BLUEZ_TOOLS_VERSION = 97efd293491ad7ec96a655665339908f2478b3d1
+endif

package/bluez-tools/bluez-tools.mk line 22

Quoted 10 lines
package/bluez-tools/bluez-tools.mk new file +10 -0
+BLUEZ_TOOLS_SITE = $(call github,khvzak,bluez-tools,$(BLUEZ_TOOLS_VERSION))
+# sources fetched from github, no configure script)
+BLUEZ_TOOLS_AUTORECONF = YES
+BLUEZ_TOOLS_DEPENDENCIES = host-pkgconf dbus dbus-glib
+
+ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y)
+BLUEZ_TOOLS_DEPENDENCIES += bluez_utils
+else
+BLUEZ_TOOLS_DEPENDENCIES += bluez5_utils readline
+endif

Version 171181b6ef6 (for bluez 4) also looks for readline when obex is enabled, which is the default.

Tested with bluez5 on Raspberry Pi 3.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH v2 1/1 package/bluez-tools: new package

Hello,

Quoted 3 lines · Baruch Siach
Quoted 1 line
 DEVELOPERS                           |  1 +  

This change should be in a separate patch.

Actually, our Buildroot manual says otherwise, so we discussed this at the Buildroot Developers meeting earlier this week. The conclusion of this discussion is that we in fact prefer to have the change to the DEVELOPERS file in the same patch as the patch adding the package.

We believe that having separate patches really adds additional burden, and increases the chance of merging a new package without the corresponding change to the DEVELOPERS (for example if someone submits a series adding N packages, just one patch updating the DEVELOPERS file, and we merge only the first few packages because the remaining ones are not yet ready).

Separating the change to DEVELOPERS file is actually causing more effort than the effort that will be required by the few people who will backport patches and have to handle a few conflicts in the DEVELOPERS file.

So we now prefer to have the DEVELOPERS file change in the patch adding the package.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com