Skip to contentSkip to conversation

staging: comedi: Fix incorrect type assignment

PATCH In review Karthik Nayak 3 participants 13 messages Feb 7, 2017 – Feb 9, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: comedi: Fix incorrect type assignment

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
 drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +3 -2
index cdb66eab1292..4f45a5c230ad 100644
@@ -1207,6 +1207,7 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	unsigned int old_iodwbsr_bits;
 	unsigned int old_iodwbsr1_bits;
 	unsigned int old_iodwcr1_bits;
+	__be32 serial_number;
 	int i;
 
 	/* IO Window 1 needs to be temporarily mapped to read the eeprom */
@@ -1223,10 +1224,10 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 
 	BUG_ON(serial_number_eeprom_length > sizeof(devpriv->serial_number));
 	for (i = 0; i < serial_number_eeprom_length; ++i) {
-		char *byte_ptr = (char *)&devpriv->serial_number + i;
+		char *byte_ptr = (char *)&serial_number + i;
 		*byte_ptr = ni_readb(dev, serial_number_eeprom_offset + i);
 	}
-	devpriv->serial_number = be32_to_cpu(devpriv->serial_number);
+	devpriv->serial_number = be32_to_cpu(serial_number);
 
 	for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
 		devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM + i);
drivers/staging/comedi/drivers/ni_stc.h +1 -1
index f27b545f83eb..b5eca0da71eb 100644
@@ -1031,7 +1031,7 @@ struct ni_private {
 
 	unsigned short ai_fifo_buffer[0x2000];
 	u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-	__be32 serial_number;
+	unsigned int serial_number;
 
 	struct mite *mite;
 	struct mite_channel *ai_mite_chan;
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 45 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
 drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +3 -2
index cdb66eab1292..4f45a5c230ad 100644
@@ -1207,6 +1207,7 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	unsigned int old_iodwbsr_bits;
 	unsigned int old_iodwbsr1_bits;
 	unsigned int old_iodwcr1_bits;
+	__be32 serial_number;
 	int i;
 
 	/* IO Window 1 needs to be temporarily mapped to read the eeprom */
@@ -1223,10 +1224,10 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 
 	BUG_ON(serial_number_eeprom_length > sizeof(devpriv->serial_number));
 	for (i = 0; i < serial_number_eeprom_length; ++i) {
-		char *byte_ptr = (char *)&devpriv->serial_number + i;
+		char *byte_ptr = (char *)&serial_number + i;
 		*byte_ptr = ni_readb(dev, serial_number_eeprom_offset + i);
 	}
-	devpriv->serial_number = be32_to_cpu(devpriv->serial_number);
+	devpriv->serial_number = be32_to_cpu(serial_number);
 
 	for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
 		devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM + i);
drivers/staging/comedi/drivers/ni_stc.h +0 -0
index f27b545f83eb..b5eca0da71eb 100644

drivers/staging/comedi/drivers/ni_stc.h struct ni_private { · line 1037

Quoted 8 lines
drivers/staging/comedi/drivers/ni_stc.h +1 -1
@@ -1031,7 +1031,7 @@ struct ni_private {
 
 	unsigned short ai_fifo_buffer[0x2000];
 	u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-	__be32 serial_number;
+	unsigned int serial_number;
 
 	struct mite *mite;
 	struct mite_channel *ai_mite_chan;

That looks fine, thanks!

(On a side note, nothing actually uses serial number, so the code that reads it from the EEPROM could just be ripped out.)

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#2 lore raw

Hello,

Quoted 68 lines · Ian Abbott
Quoted 56 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected
restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
 drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +1 -0
index cdb66eab1292..4f45a5c230ad 100644
@@ -1207,6 +1207,7 @@ static void m_series_init_eeprom_buffer(struct
 comedi_device *dev)
        unsigned int old_iodwbsr_bits;
        unsigned int old_iodwbsr1_bits;
        unsigned int old_iodwcr1_bits;
+       __be32 serial_number;
        int i;
 
        /* IO Window 1 needs to be temporarily mapped to read the eeprom

*/

drivers/staging/comedi/drivers/ni_pcimio.c +2 -2
@@ -1223,10 +1224,10 @@ static void m_series_init_eeprom_buffer(struct
 comedi_device *dev)
 
        BUG_ON(serial_number_eeprom_length >
 sizeof(devpriv->serial_number));
        for (i = 0; i < serial_number_eeprom_length; ++i) {
-               char *byte_ptr = (char *)&devpriv->serial_number + i;
+               char *byte_ptr = (char *)&serial_number + i;
                *byte_ptr = ni_readb(dev, serial_number_eeprom_offset +
 i);
        }
-       devpriv->serial_number = be32_to_cpu(devpriv->serial_number);
+       devpriv->serial_number = be32_to_cpu(serial_number);
        for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
                devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM

+ i);

drivers/staging/comedi/drivers/ni_stc.h +0 -0
index f27b545f83eb..b5eca0da71eb 100644

drivers/staging/comedi/drivers/ni_stc.h struct ni_private { · line 1037

Quoted 8 lines
drivers/staging/comedi/drivers/ni_stc.h +1 -1
@@ -1031,7 +1031,7 @@ struct ni_private {
 
        unsigned short ai_fifo_buffer[0x2000];
        u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-       __be32 serial_number;
+       unsigned int serial_number;
 
        struct mite *mite;
        struct mite_channel *ai_mite_chan;

That looks fine, thanks!

Quoted 5 lines

(On a side note, nothing actually uses serial number, so the code that reads it from the EEPROM could just be ripped out.)

Yea, I saw that, was assuming there might be a purposed use case scenario.

Do you want me to send another patch?

Signature · 2 lines
Regards,
Karthik Nayak
#3 lore raw
Quoted 20 lines · Karthik Nayak

Hello,

Quoted 17 lines · Ian Abbott
Quoted 16 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected
restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
 drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

[snip]

Quoted 7 lines
Quoted 5 lines

(On a side note, nothing actually uses serial number, so the code that reads it from the EEPROM could just be ripped out.)

Yea, I saw that, was assuming there might be a purposed use case scenario.

AFAICT it's never been used - not even to print a kernel log message or anything.

Quoted 1 line

Do you want me to send another patch?

If you want. If you plan to do so, could you indicate whether you are going to base the patch on top of this one, or whether this patch should be discarded. Thanks!

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#4 lore raw

Hi,

Quoted 40 lines · Ian Abbott
Quoted 23 lines · Karthik Nayak

Hello,

Quoted 19 lines · Ian Abbott
Quoted 17 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected
restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
 drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

[snip]

Quoted 8 lines
Quoted 6 lines

(On a side note, nothing actually uses serial number, so the code that reads
it from the EEPROM could just be ripped out.)

Yea, I saw that, was assuming there might be a purposed use case scenario.

AFAICT it's never been used - not even to print a kernel log message or anything.

Quoted 7 lines
Quoted 1 line

Do you want me to send another patch?

If you want. If you plan to do so, could you indicate whether you are going to base the patch on top of this one, or whether this patch should be discarded. Thanks!

Sure, I'll base it on top of the existing patch. I'll reply to the first patch with the second one.

Signature · 2 lines
Regards,
Karthik Nayak
#5 lore raw

PATCH 2/2 staging: comedi: drop unused variable from struct 'ni_private'

In reply to Karthik Nayak

Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment.

---

This is to be based on top of "staging: comedi: Fix incorrect type assignment" to which this is replied to.

 drivers/staging/comedi/drivers/ni_pcimio.c | 3 +--
 drivers/staging/comedi/drivers/ni_stc.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +1 -2
index 4f45a5c230ad..da4d3da071eb 100644
@@ -1222,12 +1222,11 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	writel(0x1 | old_iodwcr1_bits, mite->mmio + MITE_IODWCR_1);
 	writel(0xf, mite->mmio + 0x30);
 
-	BUG_ON(serial_number_eeprom_length > sizeof(devpriv->serial_number));
+	BUG_ON(serial_number_eeprom_length > sizeof(serial_number));
 	for (i = 0; i < serial_number_eeprom_length; ++i) {
 		char *byte_ptr = (char *)&serial_number + i;
 		*byte_ptr = ni_readb(dev, serial_number_eeprom_offset + i);
 	}
-	devpriv->serial_number = be32_to_cpu(serial_number);
 
 	for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
 		devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM + i);
drivers/staging/comedi/drivers/ni_stc.h +0 -1
index b5eca0da71eb..61138e86a455 100644
@@ -1031,7 +1031,6 @@ struct ni_private {
 
 	unsigned short ai_fifo_buffer[0x2000];
 	u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-	unsigned int serial_number;
 
 	struct mite *mite;
 	struct mite_channel *ai_mite_chan;
Signature · 1 line
2.11.1
#6 lore raw

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

Quoted 18 lines · Karthik Nayak

Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment.

---

This is to be based on top of "staging: comedi: Fix incorrect type assignment" to which this is replied to.

 drivers/staging/comedi/drivers/ni_pcimio.c | 3 +--
 drivers/staging/comedi/drivers/ni_stc.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +0 -0
index 4f45a5c230ad..da4d3da071eb 100644

drivers/staging/comedi/drivers/ni_pcimio.c static void m_series_init_eeprom_buffer(struct comedi_device *dev) · line 1224

Quoted 3 lines
drivers/staging/comedi/drivers/ni_pcimio.c +0 -0
@@ -1222,12 +1222,11 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	writel(0x1 | old_iodwcr1_bits, mite->mmio + MITE_IODWCR_1);
 	writel(0xf, mite->mmio + 0x30);
 

I think it would be preferable to remove the code from here ...

drivers/staging/comedi/drivers/ni_pcimio.c static void m_series_init_eeprom_buffer(struct comedi_device *dev) · line 1230

Quoted 7 lines
drivers/staging/comedi/drivers/ni_pcimio.c +1 -2
-	BUG_ON(serial_number_eeprom_length > sizeof(devpriv->serial_number));
+	BUG_ON(serial_number_eeprom_length > sizeof(serial_number));
 	for (i = 0; i < serial_number_eeprom_length; ++i) {
 		char *byte_ptr = (char *)&serial_number + i;
 		*byte_ptr = ni_readb(dev, serial_number_eeprom_offset + i);
 	}
-	devpriv->serial_number = be32_to_cpu(serial_number);

... to here. And remove the serial_number_eeprom_length, serial_number_eeprom_offset, and serial_number variables too. There is no need to continue reading the serial number bytes from the EEPROM.

Quoted 16 lines
drivers/staging/comedi/drivers/ni_pcimio.c +0 -0
 	for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
 		devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM + i);
drivers/staging/comedi/drivers/ni_stc.h +0 -1
index b5eca0da71eb..61138e86a455 100644
@@ -1031,7 +1031,6 @@ struct ni_private {
 
 	unsigned short ai_fifo_buffer[0x2000];
 	u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-	unsigned int serial_number;
 
 	struct mite *mite;
 	struct mite_channel *ai_mite_chan;
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#7 lore raw

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

Hey,

Quoted 40 lines · Ian Abbott
Quoted 21 lines · Karthik Nayak

Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment.

---

This is to be based on top of "staging: comedi: Fix incorrect type assignment"
to which this is replied to.

 drivers/staging/comedi/drivers/ni_pcimio.c | 3 +--
 drivers/staging/comedi/drivers/ni_stc.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +0 -0
index 4f45a5c230ad..da4d3da071eb 100644

drivers/staging/comedi/drivers/ni_pcimio.c static void m_series_init_eeprom_buffer(struct · line 1225

Quoted 4 lines
drivers/staging/comedi/drivers/ni_pcimio.c +0 -0
@@ -1222,12 +1222,11 @@ static void m_series_init_eeprom_buffer(struct
 comedi_device *dev)
        writel(0x1 | old_iodwcr1_bits, mite->mmio + MITE_IODWCR_1);
        writel(0xf, mite->mmio + 0x30);
 

I think it would be preferable to remove the code from here ...

drivers/staging/comedi/drivers/ni_pcimio.c static void m_series_init_eeprom_buffer(struct comedi_device *dev) · line 1230

Quoted 9 lines
drivers/staging/comedi/drivers/ni_pcimio.c +1 -2
-       BUG_ON(serial_number_eeprom_length >
 sizeof(devpriv->serial_number));
+       BUG_ON(serial_number_eeprom_length > sizeof(serial_number));
        for (i = 0; i < serial_number_eeprom_length; ++i) {
                char *byte_ptr = (char *)&serial_number + i;
                *byte_ptr = ni_readb(dev, serial_number_eeprom_offset +
 i);
        }
-       devpriv->serial_number = be32_to_cpu(serial_number);
Quoted 4 lines

... to here. And remove the serial_number_eeprom_length, serial_number_eeprom_offset, and serial_number variables too. There is no need to continue reading the serial number bytes from the EEPROM.

Ah! I'll do that and send a patch, thanks :)

Quoted 22 lines
Quoted 11 lines
        for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
                devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM

+ i);

drivers/staging/comedi/drivers/ni_stc.h +0 -0
index b5eca0da71eb..61138e86a455 100644

drivers/staging/comedi/drivers/ni_stc.h struct ni_private { · line 1036

Quoted 7 lines
drivers/staging/comedi/drivers/ni_stc.h +0 -1
@@ -1031,7 +1031,6 @@ struct ni_private {
 
        unsigned short ai_fifo_buffer[0x2000];
        u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-       unsigned int serial_number;
 
        struct mite *mite;
        struct mite_channel *ai_mite_chan;

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-

Signature · 2 lines
Regards,
Karthik Nayak
#8 lore raw

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

Hello,

Quoted 8 lines
Quoted 5 lines

... to here. And remove the serial_number_eeprom_length, serial_number_eeprom_offset, and serial_number variables too. There is no need to continue reading the serial number bytes from the EEPROM.

Ah! I'll do that and send a patch, thanks :)

Sorry for the multiple messages, now that we're deleting the whole block, I think it makes sense to
squash the commits, so I'll send one single patch.

Signature · 2 lines
Regards,
Karthik Nayak
#9 lore raw

PATCH 1/1 staging: comedi: Fix incorrect type assignment

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by removing the whole code block, since the variable 'serial_number' is only assigned but never used.

---
 drivers/staging/comedi/drivers/ni_pcimio.c | 9 ---------
 drivers/staging/comedi/drivers/ni_stc.h    | 1 -
 2 files changed, 10 deletions(-)
drivers/staging/comedi/drivers/ni_pcimio.c +0 -9
index cdb66eab1292..3a96913c025e 100644
@@ -1202,8 +1202,6 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	resource_size_t daq_phys_addr;
 	static const int Start_Cal_EEPROM = 0x400;
 	static const unsigned int window_size = 10;
-	static const int serial_number_eeprom_offset = 0x4;
-	static const int serial_number_eeprom_length = 0x4;
 	unsigned int old_iodwbsr_bits;
 	unsigned int old_iodwbsr1_bits;
 	unsigned int old_iodwcr1_bits;
@@ -1221,13 +1219,6 @@ static void m_series_init_eeprom_buffer(struct comedi_device *dev)
 	writel(0x1 | old_iodwcr1_bits, mite->mmio + MITE_IODWCR_1);
 	writel(0xf, mite->mmio + 0x30);
 
-	BUG_ON(serial_number_eeprom_length > sizeof(devpriv->serial_number));
-	for (i = 0; i < serial_number_eeprom_length; ++i) {
-		char *byte_ptr = (char *)&devpriv->serial_number + i;
-		*byte_ptr = ni_readb(dev, serial_number_eeprom_offset + i);
-	}
-	devpriv->serial_number = be32_to_cpu(devpriv->serial_number);
-
 	for (i = 0; i < M_SERIES_EEPROM_SIZE; ++i)
 		devpriv->eeprom_buffer[i] = ni_readb(dev, Start_Cal_EEPROM + i);
 
drivers/staging/comedi/drivers/ni_stc.h +0 -1
index f27b545f83eb..61138e86a455 100644
@@ -1031,7 +1031,6 @@ struct ni_private {
 
 	unsigned short ai_fifo_buffer[0x2000];
 	u8 eeprom_buffer[M_SERIES_EEPROM_SIZE];
-	__be32 serial_number;
 
 	struct mite *mite;
 	struct mite_channel *ai_mite_chan;
Signature · 1 line
2.11.1
maintainer
#10 lore raw
Quoted 9 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by removing the whole code block, since the variable 'serial_number' is only assigned but never used.

There's no such tag, sorry :(

And does this obsolete all of your other ones? Please make it obvious what I am supposed to do here.

I've now dropped all of these patches from my queue. please resend the proper one.

thanks,

greg k-h

#11 lore raw
Quoted 16 lines · Greg KH
Quoted 9 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

This is done by removing the whole code block, since the variable 'serial_number' is only assigned but never used.

There's no such tag, sorry :(

And does this obsolete all of your other ones? Please make it obvious what I am supposed to do here.

Quoted 7 lines

I've now dropped all of these patches from my queue. please resend the proper one.

thanks,

greg k-h

To add to that, I think the emphasis of the patch title and description should now be on the removal of serial_number, with fixing the sparse error as a useful side-effect/inspiration. The patch title should also mention ni_pcimio.

Thanks,
Ian.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#12 lore raw
In reply to Greg KH

Hello,

Quoted 6 lines · Greg KH
Quoted 5 lines · Karthik Nayak

This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int

Quoted 7 lines
Quoted 4 lines

This is done by removing the whole code block, since the variable 'serial_number' is only assigned but never used.

There's no such tag, sorry :(

Ah! This is common back in the Git community, I shall drop it :)

Quoted 6 lines

And does this obsolete all of your other ones? Please make it obvious what I am supposed to do here.

I've now dropped all of these patches from my queue. please resend the proper one.

That works! I'll send the patch again, lets ignore the previous patches.

Quoted 7 lines · Ian Abbott

To add to that, I think the emphasis of the patch title and description should now be on the removal of serial_number, with fixing the sparse error as a useful side-effect/inspiration. The patch title should also mention ni_pcimio.

Thanks,
Ian.

Makes sense, will make the necessary changes.

Signature · 2 lines
Regards,
Karthik Nayak