Skip to contentSkip to conversation

iio: 104-quad-8: Fix off-by-one error when addressing flag register

PATCH Applied William Breathitt Gray 3 participants 6 messages Feb 9, 2017 – Mar 15, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: 104-quad-8: Fix off-by-one error when addressing flag register

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
---
 drivers/iio/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +1 -1
index a5913e97945e..f9b8fc9ae13f 100644
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 
Signature · 1 line
2.11.1
maintainer Applied
#1 lore raw
Quoted 6 lines · William Breathitt Gray

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")

Applied to the fixes-togreg-post-rc1 branch of iio.git Clue to when this will go upstream is in the name ;)

Thanks,

Jonathan

Quoted 18 lines
---
 drivers/iio/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +1 -1
index a5913e97945e..f9b8fc9ae13f 100644
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 
#2 lore raw
Quoted 5 lines · Jonathan Cameron
Quoted 4 lines · William Breathitt Gray

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Quoted 8 lines
Quoted 2 lines
Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")

Applied to the fixes-togreg-post-rc1 branch of iio.git Clue to when this will go upstream is in the name ;)

Thanks,

Jonathan

Hi Jonathan,

I see that this fix made it into 4.11-rc1 but not the 4.10.2 release. Is this patch on track to appear in stable, or should I explicitly CC [email protected] to pick this up?

Thanks,

William Breathitt Gray

Quoted 18 lines
Quoted 18 lines
---
 drivers/iio/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +1 -1
index a5913e97945e..f9b8fc9ae13f 100644
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 
maintainer
#3 lore raw
Quoted 13 lines · William Breathitt Gray
Quoted 12 lines · Jonathan Cameron
Quoted 6 lines · William Breathitt Gray

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")

Applied to the fixes-togreg-post-rc1 branch of iio.git Clue to when this will go upstream is in the name ;)

Thanks,

Quoted 7 lines
Quoted 1 line

Jonathan

Hi Jonathan,

I see that this fix made it into 4.11-rc1 but not the 4.10.2 release. Is this patch on track to appear in stable, or should I explicitly CC [email protected] to pick this up?

I was half asleep and failed to tag this in the first place.

Send an email to [email protected] with the commit ID and a request that it is picked up. Cc me.

Jonathan

Quoted 28 lines

Thanks,

William Breathitt Gray

Quoted 12 lines
Quoted 12 lines
---
 drivers/iio/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +0 -0
index a5913e97945e..f9b8fc9ae13f 100644
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
Quoted 6 lines

drivers/iio/counter/104-quad-8.c static int quad8_read_raw(struct iio_dev *indio_dev, · line 82

Quoted 6 lines
drivers/iio/counter/104-quad-8.c +1 -1
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 21 lines · Jonathan Cameron
Quoted 13 lines · William Breathitt Gray
Quoted 12 lines · Jonathan Cameron
Quoted 6 lines · William Breathitt Gray

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")

Applied to the fixes-togreg-post-rc1 branch of iio.git Clue to when this will go upstream is in the name ;)

Thanks,

Quoted 7 lines
Quoted 1 line

Jonathan

Hi Jonathan,

I see that this fix made it into 4.11-rc1 but not the 4.10.2 release. Is this patch on track to appear in stable, or should I explicitly CC [email protected] to pick this up?

Quoted 11 lines

I was half asleep and failed to tag this in the first place.

Send an email to [email protected] with the commit ID and a request that it is picked up. Cc me.

Jonathan

Quoted 5 lines

Thanks,

William Breathitt Gray

Hello,

This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
104-quad-8: Fix off-by-one error when addressing flag register"). This fix should be merged into the 4.10 stable tree as well to fix an off-by-one error which causes garbage data to be read as count values -- effectively preventing proper usage of the driver.

This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8").

Thank you,

William Breathitt Gray

Quoted 24 lines
Quoted 23 lines
Quoted 12 lines
Quoted 12 lines
---
 drivers/iio/counter/104-quad-8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +0 -0
index a5913e97945e..f9b8fc9ae13f 100644
@@ -76,7 +76,7 @@ static int quad8_read_raw(struct iio_dev *indio_dev,
 			return IIO_VAL_INT;
 		}
 
Quoted 6 lines

drivers/iio/counter/104-quad-8.c static int quad8_read_raw(struct iio_dev *indio_dev, · line 82

Quoted 6 lines
drivers/iio/counter/104-quad-8.c +1 -1
-		flags = inb(base_offset);
+		flags = inb(base_offset + 1);
 		borrow = flags & BIT(0);
 		carry = !!(flags & BIT(1));
 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#5 lore raw
Quoted 36 lines · William Breathitt Gray
Quoted 21 lines · Jonathan Cameron
Quoted 13 lines · William Breathitt Gray
Quoted 12 lines · Jonathan Cameron
Quoted 6 lines · William Breathitt Gray

The flag register is offset by 1 from the respective channel data register. This patch fixes an off-by-one error when attempting to read a channel flag register where the base address was not properly offset.

Fixes 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")

Applied to the fixes-togreg-post-rc1 branch of iio.git Clue to when this will go upstream is in the name ;)

Thanks,

Quoted 7 lines
Quoted 1 line

Jonathan

Hi Jonathan,

I see that this fix made it into 4.11-rc1 but not the 4.10.2 release. Is this patch on track to appear in stable, or should I explicitly CC [email protected] to pick this up?

Quoted 11 lines

I was half asleep and failed to tag this in the first place.

Send an email to [email protected] with the commit ID and a request that it is picked up. Cc me.

Jonathan

Quoted 5 lines

Thanks,

William Breathitt Gray

Hello,

Quoted 8 lines

This patch was merged into Linus' tree as commit ca8d8e03b4c9 ("iio:
104-quad-8: Fix off-by-one error when addressing flag register"). This fix should be merged into the 4.10 stable tree as well to fix an off-by-one error which causes garbage data to be read as count values -- effectively preventing proper usage of the driver.

This patch fixes commit 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8").

Now queued up, thanks.

greg k-h